Patch Detail
Show a patch.
GET /api/patches/24860/?format=api
{ "id": 24860, "url": "https://patchwork.libcamera.org/api/patches/24860/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24860/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251028170847.2673396-8-rui.wang@ideasonboard.com>", "date": "2025-10-28T17:08:37", "name": "[v1,08/16] ipa: rkisp1: controls: define control block", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d7734e940d8a925994e6f144f8f133604c3431e5", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24860/mbox/", "series": [ { "id": 5539, "url": "https://patchwork.libcamera.org/api/series/5539/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5539", "date": "2025-10-28T17:08:30", "name": "[v1,01/16] ipa: rkisp1: algorithms: add Denoise base class shell", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5539/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24860/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24860/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73E1DC32CE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 17:09:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0925E60844;\n\tTue, 28 Oct 2025 18:09:19 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27B086080D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 18:09:15 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4638316CD;\n\tTue, 28 Oct 2025 18:07:26 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PAdCTdBY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761671246;\n\tbh=jV7eEV2O6t6DQUr2PmLI8Lue2KoK1wOeHnNaSiDF37A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PAdCTdBYed5eb4nFTTyAlV9LC5u5wxp2WrZwFeZxjSurMtvGlmrJl2Aziw19ztzCU\n\tKkRxL3neMQLmlw1YuL3uHD/HN0itswDzkgfelT39RkBWmxOK36NUT9Hwj3U7K0FgVv\n\tUgTYyUcbeYheub+22CGFre9v9UD7nhLzZUAULkSs=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v1 08/16] ipa: rkisp1: controls: define control block", "Date": "Tue, 28 Oct 2025 13:08:37 -0400", "Message-ID": "<20251028170847.2673396-8-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251028170847.2673396-1-rui.wang@ideasonboard.com>", "References": "<20251028170847.2673396-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Reserve the next free vendor allocation for rkisp1 and add the dedicated\ncontrol_ids_rkisp1.yaml. Hook the new YAML into the Meson build so the\ngenerated control headers expose the rkisp1 control namespace.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n include/libcamera/meson.build | 1 +\n src/libcamera/control_ids_rkisp1.yaml | 24 ++++++++++++++++++++++++\n src/libcamera/control_ranges.yaml | 4 +++-\n 3 files changed, 28 insertions(+), 1 deletion(-)\n create mode 100644 src/libcamera/control_ids_rkisp1.yaml", "diff": "diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 30ea76f9..3fd7ef94 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -39,6 +39,7 @@ controls_map = {\n 'draft': 'control_ids_draft.yaml',\n 'rpi/pisp': 'control_ids_rpi.yaml',\n 'rpi/vc4': 'control_ids_rpi.yaml',\n+ 'rkisp1': 'control_ids_rkisp1.yaml',\n },\n \n 'properties': {\ndiff --git a/src/libcamera/control_ids_rkisp1.yaml b/src/libcamera/control_ids_rkisp1.yaml\nnew file mode 100644\nindex 00000000..2f29d508\n--- /dev/null\n+++ b/src/libcamera/control_ids_rkisp1.yaml\n@@ -0,0 +1,24 @@\n+# SPDX-License-Identifier: LGPL-2.1-or-later\n+#\n+# Copyright (C) 2025, Ideas On Board\n+#\n+# RkISP1 specific control definitions\n+---\n+# Unless otherwise stated, all controls are bi-directional, i.e. they can be\n+# set through Request::controls() and returned out through Request::metadata().\n+vendor: rkisp1\n+controls:\n+ # --- RkISP1 DPF controls ---\n+ - DpfEnable:\n+ type: bool\n+ direction: inout\n+ description: |\n+ Enable or disable the Denoise Pre-Filter (DPF) block.\n+\n+ When disabled (false) the hardware DPF is forced off regardless of\n+ tuning or ISO level selection. When enabled (true) the algorithm may\n+ program parameters and adapt them per ISO band or manual overrides.\n+\n+ Reported in metadata as a boolean.\n+\n+...\ndiff --git a/src/libcamera/control_ranges.yaml b/src/libcamera/control_ranges.yaml\nindex 6752eb98..fc60de80 100644\n--- a/src/libcamera/control_ranges.yaml\n+++ b/src/libcamera/control_ranges.yaml\n@@ -15,6 +15,8 @@ ranges:\n rpi: 20000\n # Controls for debug metadata\n debug: 30000\n- # Next range starts at 40000\n+ # RkISP1 vendor controls\n+ rkisp1: 40000\n+ # Next range starts at 50000\n \n ...\n", "prefixes": [ "v1", "08/16" ] }