Patch Detail
Show a patch.
GET /api/patches/24851/?format=api
{ "id": 24851, "url": "https://patchwork.libcamera.org/api/patches/24851/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24851/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251028160453.3802642-2-antoine.bouyer@nxp.com>", "date": "2025-10-28T16:04:52", "name": "[v3,1/2] libcamera: pipeline_handler: Move useCount_ to protected", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "23427ce03a6eb7658ba82373bb4d44954c7aed05", "submitter": { "id": 218, "url": "https://patchwork.libcamera.org/api/people/218/?format=api", "name": "Antoine Bouyer", "email": "antoine.bouyer@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24851/mbox/", "series": [ { "id": 5538, "url": "https://patchwork.libcamera.org/api/series/5538/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5538", "date": "2025-10-28T16:04:51", "name": "imx8-isi: Move isi routing into acquireDevice", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5538/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24851/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24851/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD6BFC3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 16:03:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E7EC607F9;\n\tTue, 28 Oct 2025 17:03:07 +0100 (CET)", "from PA4PR04CU001.outbound.protection.outlook.com\n\t(mail-francecentralazlp170130007.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c20a::7])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7233D607D4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 17:03:04 +0100 (CET)", "from GVXPR04MB9831.eurprd04.prod.outlook.com (2603:10a6:150:11c::8)\n\tby VI2PR04MB10884.eurprd04.prod.outlook.com (2603:10a6:800:270::17)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9253.18;\n\tTue, 28 Oct 2025 16:03:02 +0000", "from GVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a]) by\n\tGVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a%6]) with mapi id 15.20.9253.018;\n\tTue, 28 Oct 2025 16:03:02 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"SGlCB4tS\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=dd+p4lWku+7UvC/5hlWAOYwrCK0OUIet1uHaaZMI+2cev8iwsk4NSCigcIXUdit+wNY9xCarzryAITy6eEPfSah9GikhvvcQFr+hgWI3k4BthkbAGOUPLUCPT5R3wYE5zyc//W4rvrgClzgKRPtQUigr+n62Ty4AIZJCNXJUhQIsMjMKSJQc/8LG1qUV9MhXLcBmpycFC5eqA7Rb9A96ulkW8bkA3/qBPxUTFul8eN1dDTFugo31y2kMCmu6dR0U/dkG9QRfJJq/7c88ZZpZewLXK5E8e5cyPsw3/TU5wmoWVTshHlulZPKsXRPQKkSlJ6B/UkJnchC7X/RJ79wKUw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=7tM1Rutr+tTQw/qGBV3/yYKcmjYHrVEaOjnIJUBek3U=;\n\tb=dWDmGspBXBJN/aqns2VDyIh1mT+GPh/TnnmCRfI+cHaCPxtJ9jtIKCNJ5qUdl5qlGbaOmrvChdss2qQhdZQ2Xvmuk6z4JNoDZBYqtc/ueaF29QMp+O0LBQDquXBz+v7cYhqcfPoopGt5bG74nol0khCCpymRPKKVlOl9hcMnyWPHq0U/RcJYIQ8MPvKI08Odb/joZRFGw6uS1kL++5WB5ZycjRgIa3QtVSk1X6XVKs5zbd3x1bDx283bM9EZvvgLjuEyauJlRR8HOdffXCmP5Hx5HKe6qj+LkaOcLWbJQb43WsZIN9S/Fk6boJ+p9SdDpYLFF36PGM0dKEzqsthp0A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=7tM1Rutr+tTQw/qGBV3/yYKcmjYHrVEaOjnIJUBek3U=;\n\tb=SGlCB4tSgIZJQLn0f3OBx/oHiC7+KSoFptpR709F/DSsd0LfSke3PcTF/F3Hpjncf1/hK0JOd4+UDsuFgNpgvT/2DmbMZthPkBvKE0/BAXRGnA575PFTZf5PMuR5Ob0KaLnueon5VZnrHFzcZkYHq1IV+aVYuPq576WEcr7aNcGuYn1/Ngf+b+WxJNapp8ZLrQau4jJK8j8cgyZPNKaP7zQEHunLoP7Bdcd7oUIMWpFuML9rq6XZxci8wQmND/uZIDMDqpBjmaEbUYoNOwlmBNqVopynrb3OpkIOuQRQEDm3sjGsLVCruh5ifYrjyo+3DA+2md9G4jk1LVdaIc9fYw==", "From": "Antoine Bouyer <antoine.bouyer@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "julien.vuillaumier@nxp.com, kieran.bingham@ideasonboard.com,\n\tAntoine Bouyer <antoine.bouyer@nxp.com>", "Subject": "[PATCH v3 1/2] libcamera: pipeline_handler: Move useCount_ to\n\tprotected", "Date": "Tue, 28 Oct 2025 17:04:52 +0100", "Message-Id": "<20251028160453.3802642-2-antoine.bouyer@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20251028160453.3802642-1-antoine.bouyer@nxp.com>", "References": "<20251028160453.3802642-1-antoine.bouyer@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR06CA0129.eurprd06.prod.outlook.com\n\t(2603:10a6:208:ab::34) To GVXPR04MB9831.eurprd04.prod.outlook.com\n\t(2603:10a6:150:11c::8)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "GVXPR04MB9831:EE_|VI2PR04MB10884:EE_", "X-MS-Office365-Filtering-Correlation-Id": "5e42a998-5fea-4da0-00e3-08de163b791f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|366016|1800799024|19092799006|52116014|376014|38350700014;", "X-Microsoft-Antispam-Message-Info": "w51uujEIrZHOPZmB2/AADlx9+J2Lo2Doubj2Hza1198Qyh67bRiG9GwaNBWZggPNaA2LrHJo8wvn4AP8/wL7XkPo60U1hn7RN5f72Zeeufv5vUPPCM6pKgy/vO288iTWJECoE3LHJmuBUmGA9hAxp5yGUrkLXSnbtEDqOFyV7M6oIbOxSo0oaoBBuYKcdVGzeHe663liO8yl7YOxD134tp22YS4+g5mChQaOIgkyf6KhGejND+CRpPaBgmlKlJlhjV869CXSEAYvrPhSokD5oM37fcSzN2AXsbmQfrsF/qXZ6NXMDz4krsMIIVFSexlrSH6al16ZskoW6x4NIf61fRUVcMdNq2QoqHM3ucXf2JwK/uYoP+ZZt/+NzpfvuqzZKc3mtTb8kVxoHZLnfsCnUUCHA5SmZMhy//OFjNZ2h80OGafEYkabBohz/o1mtQXKnSM8INJoyaXFS4ygRfLb3x1+uVEjajwKjiLTifQlXUsCiUxMVKyKRoRsjHOKmC91racTwwmZUlSC2yjnMeIlOCr0zl+AhTaPJy/q6VsmQLk4nHjPyp93CxftfPU6DlBGvox0PZG7WOFvZFKRXSYDbWT5elQ1EHeCGYrhCUt8UmB+ayVCKvNF8pOPpBT3VHsjJqOFMFvF10XwvVKD+OFdQX5P65cP4y+xkGJEbI3ffSyHo08gLA85LFbdrPgYfCQbJcfSZctb/kMkiYjsIBheDEMER8qoNGrQdUpnQ5c/4/Q/Evpk5u53KYkUvxqAtaVjS6Ql26aBDPLfy3VJG1idz6AOHo1DTNRC5V1S9zq+zNLzQ7HbgpaxvVsMm5rsJ1Bo/8r/Ecdzh+ERZhEjKEO8ZCcmSb7dXjDf7mJ4a8fBCEs5c/+iANgZFTxqc8FGxIzGXlHf6Gg5G1YUD7Ndr6mOxw5hvKN/bVrJh1Tqz5PaeCr5hGLrarckl4IYD5XRh7weQHRJcUxCn9wludziuY7nqCeGqYx4+u3YQReoqEEpAsdS/gWZ5cDDawwVqehXTMnfxyu55itCSG7q7+dYpbrMUQ9d1ybE/HWGBOiRaarBX7P2IBa8LAggn+Hx092z/bkq9os5LZgt57JFyiLnSDWpeTbIarTwflnQ/V76OUDXSot0YjC+5J66TJph06dZnvHQgCrvqImggfu22aOqnRZ2LlMch7O1tZdB1RybEzSjIPMkxtskOrREn9678yt3xtxR3AFk5/usn7OO0vG5nB6OSDhmYuZtu+9JnBVPcePvYLSAV7tocAqIHX9J38fW2Im42GEG81HtuwGXDldsaO3G7HfvejdsN8TqdTSkwfq89kmow3hjfhNt5c6IvtCcv3MxIpLO5y/Mq9eCvRZ8aWKYrSSNzzOQ+rzHfST8h+N/JxJmmxVDvVjirKT+FIBCl0NORJjSIz+J6MQf8NXp9AMmWZP6EYXS7zKwppPwU9iin9FUh5SuU+4twgbYe2sVyv+qPKYHKXAdGtbbRhxMOpScEM2UaJa8LD6+gFDdR/IfVkVPtkc94Dbmf6oV1Q4I/z5H", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:GVXPR04MB9831.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(366016)(1800799024)(19092799006)(52116014)(376014)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "sMWCiiT8E0aa4DxMLP/DyJiSthME1ejQc+1Li61VkC5JHG1EhSpKf0sLtcUo01F2Wruvn70kRD0LoM2+z9TRyRVplp2r9CsK0TqgcrZSAd7CCknuoGVUglr6wmTcqQDvs4r7IQvc3Wzf4Da3+rcb3s9UEZWU1fr9KCTPl+4SeHOVaKivvJEohuda6whnz8OwJrCmlkmw6udJvPrhlWS6qQwJQiR9FgBzOqXD9WbyzVqbzRzR1GGmO8xOvm3TiGYIpPqf6ilzDYbw40j52a29WmONYMvTQDQWdUQXngdW2wct8Y1LUnGKwUfFn6GY3cLTCb1TmV19PyGZuguhkVafMdLrg0AdjLLK1ranqyO3pk0gqN+87XLOPseREUrW7DviokU6HJ2BZ5U3s+RfStUzBrfwrU2pvrycb7ZN0zn9T8DBA5dTpeF8HqEX5UbxEoyEg0Anak6AzGcOtN9dV1RatwG6quW97o8zZ7LdwCW9VMSfhUP4gL0Z+2wCmYekkTTImfeNQ7YNVQSSgsburiYkXhwjZQ54QBlCSjwUOauUnZAxUfmLh46lyhOOreL0O26Eq9/mZWKnC2WaG11GVXgsR6QAovfgpYjdBXTUngsPnStFzLWwR6y3CAcDMyN5BbqRg+1fC8nhdEtRJnjju4oV+hhyJCgpKI2EZ2nbA8aSG1JiGrkwnWrHKE3X5q18FIv7vMdLJmd51j00EVS+ETrMFWb9x7iuTyESpjrX5ZPtYmsiHFebIOvURqqmJEDiuqA0kG57SClBsn5zR0J7s8f+1dAwHtQhzk0wqflBULlmMHyk4SYEZAiowei7a1C0fDYPGZOuQ2hjeGyC6GpwQz32uAjAwoS8QYK8/Xo5QAoqHtNTeJNn8sHi5eJQl6JVBi9VhGDxV8abvl5n7WMnRJ6hQYaqHXqnnsheRrlc55HqqA6PnO1mUJVGHUQozAXYG4Hap1j1cvsiBGKuOW/VTelozQ9FGAMoABLaVUuoGgJQj3DkSs3ba1/F1EVTjenZ62iXuc9XOezf8Dx3Sa7Wu8s+KaW+B68T4V0K2MCRkMVVYi0P5kd8SkeaLU5KAeVwxpb92OR0drIJJt6K4jwu/1g8ZGN21Y7oAV9FS4vX60i18HwSHJDdJizrtiufefR/U2IH7oTjPbFjOCZQrlQSRg2MStdDjoj3DT/eyXSXXLD89oEu1egIO1tLERMIBTlyHQzMne9YsC6y50ntSVt1DbUygK801z+BIDJ6zRZe5nagGhWtHdyS3mL3TLggeWupujTepFNhxscCPgJ6T8MwP7/PgzTaKujRUKWBOQwe52ojE8SE9qlKnaRwOshe/5aNFB4njh4NdyX/8K0q86FvxIrxRDCjUSku0wqQfXcvOvlkwbPSyMRxUsryxtuBWZD0e7hhWppoMHq1ODSreL1WkKtmxKusrCQiG78WophoY4DE6vMW/uP+t+5kWcBDtMcXTdW6XkbRXl6p/CfuKVyq8YL5FXQyuiShWoT/qvuP3Nnfssol2+ZmTeJ4CpC1Hu3Ztmsu+3cpzcPStv6lmpoCMT7sjP9irWK0PdCujhPjwukb3n2Opi/2Je6jjIXay+v9X5I+AUfOSIdEfIiBjlIUaAgPzQ==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "5e42a998-5fea-4da0-00e3-08de163b791f", "X-MS-Exchange-CrossTenant-AuthSource": "GVXPR04MB9831.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Oct 2025 16:03:02.6149\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "f3iH7ywlpuUNTG0cyIM8oOaw9j4ib+7WmP7u+Jy+oUC8sklJs49R9oaqvUPaclnMsEqlbQvgAZuidTDRZ9aSgg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI2PR04MB10884", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the useCount_ parameter to protected instead of private, so that\nPipelineHandler child classes could access it to verify whether the\nmedia device is already locked or not.\n\nSigned-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>\n---\n include/libcamera/internal/pipeline_handler.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex e89d6a33e398..4cefa3c7aba2 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -82,6 +82,7 @@ protected:\n \n \tCameraManager *manager_;\n \tconst unsigned int maxQueuedRequestsDevice_;\n+\tunsigned int useCount_;\n \n private:\n \tvoid unlockMediaDevices();\n@@ -96,7 +97,6 @@ private:\n \tstd::vector<std::weak_ptr<Camera>> cameras_;\n \n \tconst char *name_;\n-\tunsigned int useCount_;\n \n \tfriend class PipelineHandlerFactoryBase;\n };\n", "prefixes": [ "v3", "1/2" ] }