Patch Detail
Show a patch.
GET /api/patches/24837/?format=api
{ "id": 24837, "url": "https://patchwork.libcamera.org/api/patches/24837/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24837/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251028084650.13043-1-benjamin.mugnier@foss.st.com>", "date": "2025-10-28T08:46:50", "name": "ipa: rpi: vd56g3: Fix frameIntegrationDiff value", "commit_ref": "b1f09c013a01a82c739f0e30b71fd8d000ef5655", "pull_url": null, "state": "accepted", "archived": false, "hash": "40c0190c8fc85ebfe4406ea08977af29abf5acea", "submitter": { "id": 227, "url": "https://patchwork.libcamera.org/api/people/227/?format=api", "name": "Benjamin Mugnier", "email": "benjamin.mugnier@foss.st.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24837/mbox/", "series": [ { "id": 5535, "url": "https://patchwork.libcamera.org/api/series/5535/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5535", "date": "2025-10-28T08:46:50", "name": "ipa: rpi: vd56g3: Fix frameIntegrationDiff value", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5535/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24837/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24837/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3820AC3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 08:47:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A3A86079C;\n\tTue, 28 Oct 2025 09:47:36 +0100 (CET)", "from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[185.132.182.106])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1F7E603ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 09:47:34 +0100 (CET)", "from pps.filterd (m0241204.ppops.net [127.0.0.1])\n\tby mx07-00178001.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t59S71bnU3746626; Tue, 28 Oct 2025 09:47:32 +0100", "from osppr02cu001.outbound.protection.outlook.com\n\t(mail-norwayeastazon11013006.outbound.protection.outlook.com\n\t[40.107.159.6])\n\tby mx07-00178001.pphosted.com (PPS) with ESMTPS id 4a2s330ktf-1\n\t(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); \n\tTue, 28 Oct 2025 09:47:32 +0100 (CET)", "from DUZPR01CA0146.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:10:4bd::9) by AS8PR10MB5806.EURPRD10.PROD.OUTLOOK.COM\n\t(2603:10a6:20b:509::7) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9253.18;\n\tTue, 28 Oct 2025 08:47:30 +0000", "from DU2PEPF0001E9C5.eurprd03.prod.outlook.com\n\t(2603:10a6:10:4bd:cafe::41) by DUZPR01CA0146.outlook.office365.com\n\t(2603:10a6:10:4bd::9) with Microsoft SMTP Server (version=TLS1_3,\n\tcipher=TLS_AES_256_GCM_SHA384) id 15.20.9253.19 via Frontend\n\tTransport; Tue, 28 Oct 2025 08:48:21 +0000", "from smtpO365.st.com (164.130.1.44) by\n\tDU2PEPF0001E9C5.mail.protection.outlook.com (10.167.8.74) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.9275.10 via Frontend Transport; Tue, 28 Oct 2025 08:47:30 +0000", "from SHFDAG1NODE1.st.com (10.75.129.69) by smtpO365.st.com\n\t(10.250.44.67) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.57;\n\tTue, 28 Oct 2025 09:39:54 +0100", "from localhost (10.130.78.67) by SHFDAG1NODE1.st.com (10.75.129.69)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.57;\n\tTue, 28 Oct 2025 09:47:21 +0100" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=foss.st.com header.i=@foss.st.com\n\theader.b=\"NqFq4ems\"; dkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=jlpiW+RG9rPr1Yhe7g7LlSjIboICt9964UZsgi+SrYX3ehxD/vw1h2cbYmzZ3u5dyAepBoD+HtHxgG9u2M5OQrWnP9rLG5h5Fm9VteuyJOqdhfhBLawPUtx8fluE37hJLTbvCpBsfUW3UYfdPR3jljhSfvnac31hzDB9qFkTkwOLVlklOn44NfxfooFsi0cNemCbwFMN1zdCYprDmPovI2pLqoteROl7tQ7bhihcX/6vXbuon0mtb5vAy8yWcpZSOIvd/OxYU5kk7KTnfkXQAaEcn3Y63S2eaUQXcDFaMgYn4bQe8ZS5PEoIH9t/AnFpSQh8fFMHDbsYQMvrLqEFIw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=TrGSd+FVfjANbAJqr2PTDewFvSf9apEXeAyhmS9lNc8=;\n\tb=Kl83wg0UBKXEyem8pADHu/NaUouiMn3IVuFKamMuu7CRAVm3UQbVUEK4vq9TzslTvrKjsips6QbPdg/KqGKn/x+FXCoLqIh0qcGBk88SysX9okx68qvsEbJUU2dAxEb0lSOnDnOxLw4fdjjm8Mgc8iU9BA5w6Y+ctdymQjDjD4w36uG9o+egNN2gRxOF4U2oRFHD/xtxMXe9N60PEXBTHsfypzCeFyDYNoYs4FC5d/SW9JrNHzya/gl+X73mT9ksrcHEsg/0kfjrGPHD5WSPfAzu3rSF4bbYXEOsdl8vVgQOFd0nRi9/G5hSxWYObfWo9JjUCYcK3RSikP6jtV9jsg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=fail (sender ip is\n\t164.130.1.44)\n\tsmtp.rcpttodomain=lists.libcamera.org\n\tsmtp.mailfrom=foss.st.com;\n\tdmarc=fail (p=none sp=none pct=100) action=none\n\theader.from=foss.st.com; dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n\ts=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=TrGSd+FVfjANbAJqr2PTDewFvSf9apEXeAyhmS9lNc8=;\n\tb=NqFq4ems0s/dPDQ9vWD9yPtnBo8Z95c5j0uL/FT65py96eo5po0vB+jrpQDbyz7XjyhJDmoJ/Mtqib+2CWLW/4mJCTzkZ5Y+r7LT3mFLYY8v3/cA72vRdLUi/CT+FvQuDiWE4jbkW8TSib4/wap60PQuzsEI+cOcfWIEbyLMHQQlUQV9C3XRdnpLZr4BJefh5PXMhz1+DEbJ1wQ16nRIMn8loI0q/ggO2vhLcv70q1a04Bq1FdHmed2c6s7fNudHUE82RGTInT4KcrXIKJD6+ccYSY6hepev/46SImmiQgPu+sq+xhRDHKlEP5cXJ/uGiQST5KhBPRkgMXsJpfkHNw==", "X-MS-Exchange-Authentication-Results": "spf=fail (sender IP is 164.130.1.44)\n\tsmtp.mailfrom=foss.st.com; dkim=none (message not signed)\n\theader.d=none;dmarc=fail action=none header.from=foss.st.com;", "Received-SPF": "Fail (protection.outlook.com: domain of foss.st.com does not\n\tdesignate 164.130.1.44 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=164.130.1.44; helo=smtpO365.st.com;", "From": "Benjamin Mugnier <benjamin.mugnier@foss.st.com>", "To": "<libcamera-devel@lists.libcamera.org>", "CC": "Benjamin Mugnier <benjamin.mugnier@foss.st.com>, Jacopo Mondi\n\t<jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH] ipa: rpi: vd56g3: Fix frameIntegrationDiff value", "Date": "Tue, 28 Oct 2025 09:46:50 +0100", "Message-ID": "<20251028084650.13043-1-benjamin.mugnier@foss.st.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.130.78.67]", "X-ClientProxiedBy": "EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com\n\t(10.75.129.69)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DU2PEPF0001E9C5:EE_|AS8PR10MB5806:EE_", "X-MS-Office365-Filtering-Correlation-Id": "339dc454-67cf-4ebb-6e3a-08de15fea118", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|82310400026|36860700013|376014|1800799024; ", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?XNAlmDU3iigcNV+7U/plRTgejUpd?=\n\t=?utf-8?q?RDrLalWwRauY8Lr3/VdbJw4f8GxHUwrA429sMtj4feKfR9IZB/dchtY4?=\n\t=?utf-8?q?JcEezTsLtTKQL83bpIpbmqHvM7rTtgydZLJbeAx0Rjwn82beSKbKd02n?=\n\t=?utf-8?q?JGLCsMJutOLXAh+DfDWvEMlD99OaW51zYGJgzjpqcIPkJhkKgR/xAxzO?=\n\t=?utf-8?q?vZEnZAioSqfKPTFOLzcxSCKtkqehLAvhavf9QXfWcnQ+boSig7W4XOTH?=\n\t=?utf-8?q?Fqv+Hhzx83otXFKbBniCi6PqsfRxjcNbJOU3I73ncSlcWRZFHGgWtgNd?=\n\t=?utf-8?q?DZOF6fkggEBFccVMssQlPs2i5PhUmxVSryzRByAqYXCO02ThcT58IAVr?=\n\t=?utf-8?q?cnSQeg1qlUxyv4PJ5Llh4A05LozO7N+Ca//u6EIllJ7vPxC/fhrptfEm?=\n\t=?utf-8?q?VCTuiIpY06wodsk9JrRIpfGxYGOrwRLgUguviQYj+DnxKNhkIchdBFmO?=\n\t=?utf-8?q?dsmbwW7r5zhVOqCyJxhGGCpxOgCqCyvEgOBfSGkz6j0lpSClVylvq98G?=\n\t=?utf-8?q?+0HlVBOoV9DmwHBJGwJmp093Dkf/087QKOj2EZKTTx/MbLTgnB+cxOQc?=\n\t=?utf-8?q?YV8sa3qlNIjILrUHPU7yyWiDS7uOi5CQR5lTAsIHP0vd5iWr3KOCFc7v?=\n\t=?utf-8?q?d/CFYocTNPhaIlkfJvSIVJH/1q8Cg3Xy/xq9T2R5RZSDan8G3bH9M+Ho?=\n\t=?utf-8?q?msVRE0z6YpH2GWB2G6icWZSDOeTknMegwVaFJ6zOoMoSr2wrD8Yx0xzt?=\n\t=?utf-8?q?B4xRkPwgdKGdBUJ9SGiMjDHfAaX8O+l+JZHGV6wN9LuSXfiMV3IABMRh?=\n\t=?utf-8?q?BKpDat2/vdUMh8FbLUF1uHOpSaha34ZYcu4fP7cEpWId/dGIsIPwAduE?=\n\t=?utf-8?q?stsyAodkMB7q9ap/mKeg2Hk9WYytfwvkDOZpYC5ASXA+TcxAtIdl+yon?=\n\t=?utf-8?q?14zz0RXL64b683z7CVF9jg/+/Ll5PNnS145/mx8JNAT0LS2HK/77Ilss?=\n\t=?utf-8?q?btA3Xf7StqaKeFuQWEnj6gRgTpLQA9Zbesb4zLebB2Nl3k3q18yvyD64?=\n\t=?utf-8?q?KFLwsIgoNYXIxOm80oDNuiv9/ojr5RQKJz/Y3b8ooW9ceKyP6V6LE0Vy?=\n\t=?utf-8?q?Cu7vOl0Aw6q58e2Rm3aLswxPd1w1jNxpn2bhY/zq/On6UelNtjPqAEpe?=\n\t=?utf-8?q?iDFqeXxKytsxTdeff3BgEjfgLqVlttUWh6UijnbLKgpCFnOBDgUG87/I?=\n\t=?utf-8?q?qlJbYsuIu6MWC7hDYoHPS/JySnTPq7YOHZuTIlGvc9Z5qlmo9k5Zptvb?=\n\t=?utf-8?q?1Esbk1i3I9xtO6lxjffyInY4SNm12/ZDJHbySmKcM3mG7QXMkT9GxXy9?=\n\t=?utf-8?q?Xbt1augAaSJoZhBYcHSnNlNd6o2Bu4+TpC/sc51ExWqR5ysbGzaAn2gb?=\n\t=?utf-8?q?+MKLFIJl12tc+6D81f3Ut9iT3I+zrXg/Z8ulx7Fe8DErfTAXI8/L85rW?=\n\t=?utf-8?q?SSCsEjHNnbnSinAVAxC3yyXczexngUc9lHWkuCK+yOQ4vKILNEfcxzkz?=\n\t=?utf-8?q?lpnGi7MpMNe43EMUD/mtI9Kgaq3heZnljSqzCeMh2YXth8ZJuoTVH2+P?=\n\t=?utf-8?q?7z2jUb27sEYSkSylEW/K3acClumhAZptQn54Fwk=3D?=", "X-Forefront-Antispam-Report": "CIP:164.130.1.44; CTRY:IT; LANG:en; SCL:1; SRV:;\n\tIPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent;\n\tCAT:NONE; \n\tSFS:(13230040)(82310400026)(36860700013)(376014)(1800799024); DIR:OUT;\n\tSFP:1101; ", "X-OriginatorOrg": "foss.st.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Oct 2025 08:47:30.0366\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "339dc454-67cf-4ebb-6e3a-08de15fea118", "X-MS-Exchange-CrossTenant-Id": "75e027c9-20d5-47d5-b82f-77d7cd041e8f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;\n\tIp=[164.130.1.44]; \n\tHelo=[smtpO365.st.com]", "X-MS-Exchange-CrossTenant-AuthSource": "DU2PEPF0001E9C5.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR10MB5806", "X-Proofpoint-GUID": "zlmq2IREJj20YgdiRE7eToQC--9m1mf9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjUxMDI4MDA3NCBTYWx0ZWRfX498pEjar2EWh\n\tNcZmSlEkQ8v/7zZnhLP/ceU5jsLhmLqXc5D5JoKjNG0kmL6nzlwbL4+Ymb3KWWlJ5aOsT28fce+\n\tYn6ptBt5fikXGxFZoZ3hJJiQ9GOehLjaehlDZGf9zPebXGrHgOdi3gPMSyZXB+H1F8ECmzoJqwC\n\t2L/D1Es5HwBwyFh96trYP0dn73ZnYQAz3WYi/Q+y+dT66sdpnOt6SbHhKVIthEMxjDsiprNlG11\n\tsFtArWp5aQcaQbCyAFd64xleji1MlRhDe8VDphDI+rfL9p+2eas7OYcCRVb4U3aM2FS8DK4ls5j\n\tY/JCl3/TZ4gEP4YIuiPf0Fzgu+5y40VxBu0o7In/zeQAGihZWdnW/C5ROvTCT8RJRRrhFSbgKUV\n\tf88UR5Q92H1kFXwr2aUpEl9BB+F30w==", "X-Authority-Analysis": "v=2.4 cv=SMtPlevH c=1 sm=1 tr=0 ts=69008324 cx=c_pps\n\ta=V7bJpFG2U8+55D0nNporPg==:117 a=Tm9wYGWyy1fMlzdxM1lUeQ==:17\n\ta=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=WaRyL3-Hq7oA:10 a=IkcTkHD0fZMA:10\n\ta=x6icFKpwvdMA:10 a=s63m1ICgrNkA:10 a=KrXZwBdWH7kA:10\n\ta=VkNPw1HP01LnGYTKEx00:22 a=P1BnusSwAAAA:8 a=8b9GpE9nAAAA:8\n\ta=kkPV9tHtCx3pdp_N4Z8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n\ta=D0XLA9XvdZm18NrgonBM:22 a=T3LWEMljR5ZiDmsYVIUa:22", "X-Proofpoint-ORIG-GUID": "zlmq2IREJj20YgdiRE7eToQC--9m1mf9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.9,\n\tFMLib:17.12.80.40\n\tdefinitions=2025-10-28_03,2025-10-22_01,2025-03-28_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1011 suspectscore=0 adultscore=0\n\tlowpriorityscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2510020000\n\tdefinitions=main-2510280074", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In the vd56g3 user manual :\n\n MAX_EXPOSURE_COARSE = FRAME_LENGTH − EXP_COARSE_INTG_MARGIN − 7\n EXP_COARSE_INTG_MARGIN >= 68\n\nTherefore, frameIntegrationDiff is EXP_COARSE_INTG_MARGIN + 7, equals\n75. This value is coherent with the VD56G3_EXPOSURE_MARGIN in the kernel\ndriver source code.\n\nReported-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>\n---\n src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\nindex 140aabd802ad..8a58bc746711 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp\n@@ -23,7 +23,7 @@ private:\n \t * Smallest difference between the frame length and integration time,\n \t * in units of lines.\n \t */\n-\tstatic constexpr int frameIntegrationDiff = 61;\n+\tstatic constexpr int frameIntegrationDiff = 75;\n };\n \n CamHelperVd56g3::CamHelperVd56g3()\n", "prefixes": [] }