Patch Detail
Show a patch.
GET /api/patches/24794/?format=api
{ "id": 24794, "url": "https://patchwork.libcamera.org/api/patches/24794/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24794/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251024085130.995967-29-stefan.klug@ideasonboard.com>", "date": "2025-10-24T08:50:52", "name": "[v1,28/35] pipline: rkisp1: Reinstantiate maxQueuedRequestsDevice limit", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0c02d1814399a7136577a88e6d8559ed32871575", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24794/mbox/", "series": [ { "id": 5524, "url": "https://patchwork.libcamera.org/api/series/5524/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5524", "date": "2025-10-24T08:50:24", "name": "rkisp1: pipeline rework for PFC", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5524/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24794/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24794/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E53EBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Oct 2025 08:53:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3D5E60904;\n\tFri, 24 Oct 2025 10:53:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51BD060904\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Oct 2025 10:53:03 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D1A2B4B0C; \n\tFri, 24 Oct 2025 10:51:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dVEwnGoi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295877;\n\tbh=aXgtbQH79QP9gzpvn2U4Rsbd91eeA3SDfppS/QzkxFM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dVEwnGoi/Dgv7TubQQJ4BwWi203wX6VaQlMXanXjI77H/GQzKVlV6A3qzrIVbkd55\n\tukmb/JpGR4STbi95n2MAUHl7YlNPZbWM+KA0CV1b70X+k6mIrj4d1YkKK+ZqlyedDq\n\tDrVtj+5uykdaJObo7nSwJBjNSWbVatLw5VP+dlxo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 28/35] pipline: rkisp1: Reinstantiate\n\tmaxQueuedRequestsDevice limit", "Date": "Fri, 24 Oct 2025 10:50:52 +0200", "Message-ID": "<20251024085130.995967-29-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251024085130.995967-1-stefan.klug@ideasonboard.com>", "References": "<20251024085130.995967-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the pipeline rework, the maxQueuedRequestsDevice should not be\nnecessary anymore, as prepare() and therefore the calculation for the\nISP regulation is called only as late as possible when a params buffer\nwas dequeued.\n\nHowever with unlimited maxQueuedRequestsDevice all the incoming requests\nget immediately queued to the ipa with the sensor sequence number that\nwas anticipated for that request at queueRequestDevice time. Now when\nthe correction tries to mitigate dropped sequence numbers, it will call\ncomputeParams() with sensor frame numbers that were not anticipated for\nthe requests queued to the IPA. There still might be a better solution\nto this, but reinstantiating the limit reduces the effect.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex cd9364cb8950..2d78721be63a 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -764,7 +764,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n */\n \n PipelineHandlerRkISP1::PipelineHandlerRkISP1(CameraManager *manager)\n-\t: PipelineHandler(manager), hasSelfPath_(true)\n+\t: PipelineHandler(manager, kRkISP1MinBufferCount), hasSelfPath_(true)\n {\n }\n \n", "prefixes": [ "v1", "28/35" ] }