Patch Detail
Show a patch.
GET /api/patches/24759/?format=api
{ "id": 24759, "url": "https://patchwork.libcamera.org/api/patches/24759/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24759/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251023144841.403689-33-stefan.klug@ideasonboard.com>", "date": "2025-10-23T14:48:33", "name": "[v2,32/35] libcamera: Add and implement LensDewarpEnable control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f33833a5cd0fd093e102f03b6c238e846458db36", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24759/mbox/", "series": [ { "id": 5520, "url": "https://patchwork.libcamera.org/api/series/5520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5520", "date": "2025-10-23T14:48:01", "name": "Full dewarper support on imx8mp", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24759/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24759/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4E7AC3346\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Oct 2025 14:50:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15BE560861;\n\tThu, 23 Oct 2025 16:50:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACDFF607ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Oct 2025 16:50:22 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BA53A1D2B; \n\tThu, 23 Oct 2025 16:48:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XDi+9YIC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230917;\n\tbh=9UZZaXIngu5Dle1/LCtUV/S6Q1vKVbwh4WpHag52gY0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XDi+9YICZg/R3BeX9Md8+S4EX5EVbm3h5oAANFpDNvGDRZB+x76PtmJ5PGX2bfs0g\n\tis2b2FhVu6773JSRHoiCsxo0ygoNgM1dG3frCsCAt+Mz4ZEfWtWPH+9k/xQHkOCCDy\n\ttp9nFG1cZf8B0ITQ/zXGfniIzxCp90TLXlstJjKg=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 32/35] libcamera: Add and implement LensDewarpEnable\n\tcontrol", "Date": "Thu, 23 Oct 2025 16:48:33 +0200", "Message-ID": "<20251023144841.403689-33-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "References": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a LensDewarpEnable control to enable or disable lens dewarping if it\nis configured. Implement it for the dw100 converter.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Merged control definition and usage into one patch\n- Improved control description\n- Fixed actual handling of LensDewarpEnable control that got lost in a\n previous rebase\n---\n src/libcamera/control_ids_core.yaml | 7 +++++++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 26 ++++++++++++++++++++++--\n 2 files changed, 31 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex f781865859ac..3bcb475fd102 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1346,4 +1346,11 @@ controls:\n reduces the WdrExposureValue until the amount of pixels that are close\n to saturation is lower than this value.\n \n+ - LensDewarpEnable:\n+ type: bool\n+ direction: inout\n+ description: |\n+ Enable or disable lens dewarping. This control is only available if lens\n+ dewarp parameters are configured in the tuning file.\n+\n ...\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 2280a5554f5a..da3cfc0ffdeb 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1492,6 +1492,14 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\t\t\t\t\t\t\t maxCrop);\n \t\t}\n \n+\t\tif (data->dewarpParams_.has_value()) {\n+\t\t\tif (dewarper_->supportsRequests())\n+\t\t\t\tcontrols[&controls::LensDewarpEnable] = ControlInfo(false, true, true);\n+\t\t\telse\n+\t\t\t\tLOG(RkISP1, Warning)\n+\t\t\t\t\t<< \"dw100 kernel driver has no requests support.\"\n+\t\t\t\t\t \" No dynamic configuration possible.\";\n+\t\t}\n \t}\n \n \t/* Add the IPA registered controls to list of camera controls. */\n@@ -1765,8 +1773,15 @@ void PipelineHandlerRkISP1::imageBufferReady(FrameBuffer *buffer)\n \t\tavailableDewarpRequests_.pop();\n \t}\n \n+\tbool update = false;\n \tauto &vertexMap = dewarper_->vertexMap(&data->mainPathStream_);\n \n+\tconst auto &lensDewarpEnable = request->controls().get(controls::LensDewarpEnable);\n+\tif (lensDewarpEnable) {\n+\t\tvertexMap.setLensDewarpEnable(*lensDewarpEnable);\n+\t\tupdate = true;\n+\t}\n+\n \t/* Handle scaler crop control. */\n \tconst auto &crop = request->controls().get(controls::ScalerCrop);\n \tif (crop) {\n@@ -1775,9 +1790,12 @@ void PipelineHandlerRkISP1::imageBufferReady(FrameBuffer *buffer)\n \t\t\t\t<< \"Dynamically setting ScalerCrop requires a \"\n \t\t\t\t \"dw100 driver with requests support\";\n \t\tvertexMap.setScalerCrop(*crop);\n-\t\tdewarper_->applyVertexMap(&data->mainPathStream_, dewarpRequest);\n+\t\tupdate = true;\n \t}\n \n+\tif (update)\n+\t\tdewarper_->applyVertexMap(&data->mainPathStream_, dewarpRequest);\n+\n \t/*\n \t * Queue input and output buffers to the dewarper. The output\n \t * buffers for the dewarper are the buffers of the request, supplied\n@@ -1809,7 +1827,11 @@ void PipelineHandlerRkISP1::imageBufferReady(FrameBuffer *buffer)\n \t\t}\n \t}\n \n-\trequest->metadata().set(controls::ScalerCrop, vertexMap.effectiveScalerCrop());\n+\tauto &meta = request->metadata();\n+\tmeta.set(controls::ScalerCrop, vertexMap.effectiveScalerCrop());\n+\n+\tif (vertexMap.dewarpParamsValid())\n+\t\tmeta.set(controls::LensDewarpEnable, vertexMap.lensDewarpEnable());\n }\n \n void PipelineHandlerRkISP1::dewarpRequestReady(V4L2Request *request)\n", "prefixes": [ "v2", "32/35" ] }