Patch Detail
Show a patch.
GET /api/patches/24758/?format=api
{ "id": 24758, "url": "https://patchwork.libcamera.org/api/patches/24758/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24758/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251023144841.403689-32-stefan.klug@ideasonboard.com>", "date": "2025-10-23T14:48:32", "name": "[v2,31/35] pipeline: rkisp1: Load dewarp parameters from tuning file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "daf1cf771583fbf449ea4907b98d6b0ac6f1b039", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24758/mbox/", "series": [ { "id": 5520, "url": "https://patchwork.libcamera.org/api/series/5520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5520", "date": "2025-10-23T14:48:01", "name": "Full dewarper support on imx8mp", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24758/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24758/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD7F2C3345\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Oct 2025 14:50:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C26F60854;\n\tThu, 23 Oct 2025 16:50:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB1D0607ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Oct 2025 16:50:19 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E9D741D2B; \n\tThu, 23 Oct 2025 16:48:34 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rjZt7oqs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230915;\n\tbh=X/atkDhziiN20cDoi0BOYNgnetYnqG9uNQt3YQGpzB0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rjZt7oqssZ0l9tqK/gPPgeEO1gmvYLMUdlYePc4UzShTFsj7OiNNXLu11Fv7l9MDI\n\tGBBnzKvWPSq5V73ucLFUO69wQkKFpVm0W6zqt9ximW5W3YI2xqYR6lcn1IEFkOpQ39\n\tHOpjGytt79UQz1zbJXlsH1nxaFzQiwikZpqnxgUQ=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 31/35] pipeline: rkisp1: Load dewarp parameters from\n\ttuning file", "Date": "Thu, 23 Oct 2025 16:48:32 +0200", "Message-ID": "<20251023144841.403689-32-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "References": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Load the dewarp parameters from the tuning file.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Dropped unused variable\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 33 +++++++++++++++++++++++-\n 1 file changed, 32 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex eaf82d0f1097..2280a5554f5a 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -125,6 +125,11 @@ public:\n \t */\n \tMediaPipeline pipe_;\n \n+\tstruct DewarpParms {\n+\t\tMatrix<double, 3, 3> cm;\n+\t\tstd::vector<double> coeffs;\n+\t};\n+\tstd::optional<DewarpParms> dewarpParams_;\n \tbool canUseDewarper_;\n \tbool usesDewarper_;\n \n@@ -458,8 +463,30 @@ int RkISP1CameraData::loadTuningFile(const std::string &path)\n \n \tconst auto &algos = (*data)[\"algorithms\"].asList();\n \tfor (const auto &algo : algos) {\n-\t\tif (algo.contains(\"Dewarp\"))\n+\t\tconst auto ¶ms = algo[\"Dewarp\"];\n+\t\tif (params) {\n \t\t\tcanUseDewarper_ = true;\n+\t\t\tDewarpParms dp;\n+\t\t\tif (params[\"cm\"]) {\n+\t\t\t\tconst auto &cm = params[\"cm\"].get<Matrix<double, 3, 3>>();\n+\t\t\t\tif (!cm) {\n+\t\t\t\t\tLOG(RkISP1, Error) << \"Dewarp parameters are missing 'cm' value\";\n+\t\t\t\t\treturn -EINVAL;\n+\t\t\t\t}\n+\t\t\t\tdp.cm = *cm;\n+\t\t\t}\n+\n+\t\t\tif (params[\"coefficients\"]) {\n+\t\t\t\tconst auto &coeffs = params[\"coefficients\"].getList<double>();\n+\t\t\t\tif (!coeffs) {\n+\t\t\t\t\tLOG(RkISP1, Error) << \"Dewarp parameters 'coefficients' value is not a list\";\n+\t\t\t\t\treturn -EINVAL;\n+\t\t\t\t}\n+\t\t\t\tdp.coeffs = *coeffs;\n+\t\t\t}\n+\n+\t\t\tdewarpParams_ = dp;\n+\t\t}\n \t}\n \n \treturn 0;\n@@ -1050,6 +1077,10 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\t\t\tauto &vertexMap = dewarper_->vertexMap(cfg.stream());\n \t\t\t\tvertexMap.setSensorCrop(sensorCrop);\n \t\t\t\tvertexMap.setTransform(config->combinedTransform());\n+\t\t\t\tif (data->dewarpParams_) {\n+\t\t\t\t\tvertexMap.setDewarpParams(data->dewarpParams_->cm,\n+\t\t\t\t\t\t\t\t data->dewarpParams_->coeffs);\n+\t\t\t\t}\n \t\t\t\tdata->properties_.set(properties::ScalerCropMaximum, sensorCrop);\n \n \t\t\t\t/*\n", "prefixes": [ "v2", "31/35" ] }