Patch Detail
Show a patch.
GET /api/patches/24752/?format=api
{ "id": 24752, "url": "https://patchwork.libcamera.org/api/patches/24752/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24752/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251023144841.403689-26-stefan.klug@ideasonboard.com>", "date": "2025-10-23T14:48:26", "name": "[v2,25/35] pipeline: rkisp1: Drop rawFormat variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "90b2e02bc180a310bcf3281339c91b29cd4c83b8", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24752/mbox/", "series": [ { "id": 5520, "url": "https://patchwork.libcamera.org/api/series/5520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5520", "date": "2025-10-23T14:48:01", "name": "Full dewarper support on imx8mp", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24752/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24752/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC74DC3341\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Oct 2025 14:50:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E53760844;\n\tThu, 23 Oct 2025 16:50:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B92426082F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Oct 2025 16:50:01 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 99B9F177F; \n\tThu, 23 Oct 2025 16:48:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kcZiKNGt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230896;\n\tbh=j/3WsFB4D2Uta3xMCM/dsUMW3xNcA+oJ/oLjccHCkWw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kcZiKNGtnHGy0KqC+44eRhTEqii1l2/9oXsOkwKZRh1HfGmErqvC7CaH2sxPUxkkn\n\tU3Lu43P2pAcwAij9F/+xmQE5EUm1J+dhFB3/2X27COB922gj20zEvXltVlmbbLhmAS\n\tTyaYeBV60E+iNshCJz/+OJrWDEAYenMFqGaTYwGU=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 25/35] pipeline: rkisp1: Drop rawFormat variable", "Date": "Thu, 23 Oct 2025 16:48:26 +0200", "Message-ID": "<20251023144841.403689-26-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "References": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In raw mode we know there is only a single configuration so there\nis no need to iterate over all configurations to find the format.\nDrop that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 35cb54c812bc..d7bb30f20668 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -677,21 +677,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t}\n \n \t/* Select the sensor format. */\n-\tPixelFormat rawFormat;\n \tSize maxSize;\n \n \tfor (const StreamConfiguration &cfg : config_) {\n-\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n-\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n-\t\t\trawFormat = cfg.pixelFormat;\n-\n \t\tmaxSize = std::max(maxSize, cfg.size);\n \t}\n \n \tstd::vector<unsigned int> mbusCodes;\n \n-\tif (rawFormat.isValid()) {\n-\t\tmbusCodes = { rawFormats.at(rawFormat) };\n+\tif (isRaw) {\n+\t\tmbusCodes = { rawFormats.at(config_[0].pixelFormat) };\n \t} else {\n \t\tstd::transform(rawFormats.begin(), rawFormats.end(),\n \t\t\t std::back_inserter(mbusCodes),\n", "prefixes": [ "v2", "25/35" ] }