Patch Detail
Show a patch.
GET /api/patches/24741/?format=api
{ "id": 24741, "url": "https://patchwork.libcamera.org/api/patches/24741/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24741/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251023144841.403689-14-stefan.klug@ideasonboard.com>", "date": "2025-10-23T14:48:14", "name": "[v2,13/35] libcamera: converter_v4l2_m2m: Add debug logging for formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "73e187ff83386d147ee1e5832e386a52db4f5a19", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24741/mbox/", "series": [ { "id": 5520, "url": "https://patchwork.libcamera.org/api/series/5520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5520", "date": "2025-10-23T14:48:01", "name": "Full dewarper support on imx8mp", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24741/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24741/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 033C0C32D4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Oct 2025 14:49:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53CCF6080B;\n\tThu, 23 Oct 2025 16:49:26 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31ED660809\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Oct 2025 16:49:25 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3B6A6EFE;\n\tThu, 23 Oct 2025 16:47:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UU6CE6j3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230860;\n\tbh=IPeWjIvsK/SnFf3hCJYPEyCivN39LUmhW+Z5pIM09yA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UU6CE6j3RvO/Zw07Tws3/P1W5I//2vwgQRjYu1BCQmCPPQDQ/AZtw77rKJ0dKnyoY\n\twA8fhWuxPctrRDRRGCv4Vrv53kgOfZrnrwrMLwwHl1Ahld59O2N9SGZxWcbgA8O1aU\n\tp+CUsMFdo5mmVn4l4HQpS/SOmPW40csT5XQktn+4=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 13/35] libcamera: converter_v4l2_m2m: Add debug logging\n\tfor formats", "Date": "Thu, 23 Oct 2025 16:48:14 +0200", "Message-ID": "<20251023144841.403689-14-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "References": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Getting the requested input/output format is crucial for debugging. Add\nlog statements for that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tag\n---\n src/libcamera/converter/converter_v4l2_m2m.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex 48e49f143cf1..37377ab24952 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -111,6 +111,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n \tformat.planesCount = 1;\n \tformat.planes[0].bpl = inputCfg.stride;\n \n+\tLOG(Converter, Debug) << \"Set input format to: \" << format;\n \tint ret = m2m_->output()->setFormat(&format);\n \tif (ret < 0) {\n \t\tLOG(Converter, Error)\n@@ -133,6 +134,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n \tformat.fourcc = videoFormat;\n \tformat.size = outputCfg.size;\n \n+\tLOG(Converter, Debug) << \"Set output format to: \" << format;\n \tret = m2m_->capture()->setFormat(&format);\n \tif (ret < 0) {\n \t\tLOG(Converter, Error)\n", "prefixes": [ "v2", "13/35" ] }