Patch Detail
Show a patch.
GET /api/patches/24715/?format=api
{ "id": 24715, "url": "https://patchwork.libcamera.org/api/patches/24715/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24715/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251021182716.29274-6-mzamazal@redhat.com>", "date": "2025-10-21T18:27:12", "name": "[v13,5/8] libcamera: simple: Don't enforce conversion with an added raw stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "12f67abee8003fab22ab492c200d7e13af2249f8", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24715/mbox/", "series": [ { "id": 5515, "url": "https://patchwork.libcamera.org/api/series/5515/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5515", "date": "2025-10-21T18:27:07", "name": "Enable raw streams with software ISP", "version": 13, "mbox": "https://patchwork.libcamera.org/series/5515/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24715/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24715/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4129C3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Oct 2025 18:27:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CC086079F;\n\tTue, 21 Oct 2025 20:27:51 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73DA560797\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Oct 2025 20:27:49 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-606-4BWJqpx9Nhez40JGwd08tw-1;\n\tTue, 21 Oct 2025 14:27:45 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id D3BC01800744; Tue, 21 Oct 2025 18:27:43 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.124])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 2FC6A18004D4; Tue, 21 Oct 2025 18:27:40 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"U9jtllET\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1761071268;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=myltGW/2P/zn16ebDCflq8jc7WTbSgO/SUdlQHaoSbs=;\n\tb=U9jtllETCV3umHJCxFWiwOXwtCFp1DSBPvSR+B4RwRjj4pCHa9NuagmUraNso7Nk0ueZxX\n\tnNq1tyHrsxJON2F5l1iBl7yaUoXfLy8bTCXmfGPytPVXXIg4+wExqruuND1B91m5H8zKBi\n\ttkeiMsdE3Lba9otwtV5P5e5hZaU9R2o=", "X-MC-Unique": "4BWJqpx9Nhez40JGwd08tw-1", "X-Mimecast-MFC-AGG-ID": "4BWJqpx9Nhez40JGwd08tw_1761071263", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>, Umang Jain <uajain@igalia.com>", "Subject": "[PATCH v13 5/8] libcamera: simple: Don't enforce conversion with an\n\tadded raw stream", "Date": "Tue, 21 Oct 2025 20:27:12 +0200", "Message-ID": "<20251021182716.29274-6-mzamazal@redhat.com>", "In-Reply-To": "<20251021182716.29274-1-mzamazal@redhat.com>", "References": "<20251021182716.29274-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "B9mTEsd7HqWV0CTltMAGIs7IO86UaKauZkW-78hGfwo_1761071263", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a raw stream is requested, either alone or together with a\nprocessed stream, it can be produced without conversion. Let's amend\nthe corresponding check on the number of configurations, so that the\nmere presence of a raw stream doesn't enforce conversion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 1943b6e72..703917a68 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1228,7 +1228,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t * require any conversion, similar to raw capture use cases). This is\n \t * left as a future improvement.\n \t */\n-\tneedConversion_ = config_.size() > 1;\n+\tneedConversion_ = config_.size() > 1 + (rawFormat ? 1 : 0);\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n", "prefixes": [ "v13", "5/8" ] }