Patch Detail
Show a patch.
GET /api/patches/24709/?format=api
{ "id": 24709, "url": "https://patchwork.libcamera.org/api/patches/24709/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24709/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251021080651.401753-2-barnabas.pocze@ideasonboard.com>", "date": "2025-10-21T08:06:51", "name": "[RFC,v1,2/2] libcamera: camera_sensor_properties: Add imx708 variants", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "157957ab5a319b81ba900c2f259f0b1ecfba4c4d", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24709/mbox/", "series": [ { "id": 5514, "url": "https://patchwork.libcamera.org/api/series/5514/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5514", "date": "2025-10-21T08:06:50", "name": "[RFC,v1,1/2] libipa: camera_sensor_helper: Add imx708", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5514/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24709/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24709/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD579C32CE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Oct 2025 08:06:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FA306076C;\n\tTue, 21 Oct 2025 10:06:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 145656075A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Oct 2025 10:06:55 +0200 (CEST)", "from pb-laptop.local (185.221.141.231.nat.pool.zt.hu\n\t[185.221.141.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6601149B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Oct 2025 10:05:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aMehpIFO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761033911;\n\tbh=oWdCvliiAUzpF7sw87NlQ6l4f4MQN31TRczEezald6c=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=aMehpIFOfN3Gi7E4Q0znw7HokMD3q7LHNqqv6ZkV0aEYcz8TQq0oFA/E67LPoe+H+\n\tuvcVZU/Y/o12kMRuQZxCD/4pI98sXhA5E/5VM/R2yqtNOwUoc9suLmOBnDWTLHNvNj\n\tXe8JXz5qPNe72mfXYrLK94xL6ZLOVXgif7Smk8xk=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 2/2] libcamera: camera_sensor_properties: Add imx708\n\tvariants", "Date": "Tue, 21 Oct 2025 10:06:51 +0200", "Message-ID": "<20251021080651.401753-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.1.dirty", "In-Reply-To": "<20251021080651.401753-1-barnabas.pocze@ideasonboard.com>", "References": "<20251021080651.401753-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The imx708 variants (wide, noir) were missing from the camera property\ndatabase. So add them with the same values as the base model since the\nlack of infrared filter / wide angle lens have no effect on these properties.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n .../sensor/camera_sensor_properties.cpp | 48 +++++++++++++++++++\n 1 file changed, 48 insertions(+)", "diff": "diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex b217363d8..9ca01fd87 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -325,6 +325,54 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t.hblankDelay = 3\n \t\t\t},\n \t\t} },\n+\t\t{ \"imx708_wide\", {\n+\t\t\t.unitCellSize = { 1400, 1400 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n+\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 3,\n+\t\t\t\t.hblankDelay = 3\n+\t\t\t},\n+\t\t} },\n+\t\t{ \"imx708_noir\", {\n+\t\t\t.unitCellSize = { 1400, 1400 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n+\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 3,\n+\t\t\t\t.hblankDelay = 3\n+\t\t\t},\n+\t\t} },\n+\t\t{ \"imx708_wide_noir\", {\n+\t\t\t.unitCellSize = { 1400, 1400 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n+\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 3,\n+\t\t\t\t.hblankDelay = 3\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov2685\", {\n \t\t\t.unitCellSize = { 1750, 1750 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "RFC", "v1", "2/2" ] }