Patch Detail
Show a patch.
GET /api/patches/24708/?format=api
{ "id": 24708, "url": "https://patchwork.libcamera.org/api/patches/24708/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24708/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251021080651.401753-1-barnabas.pocze@ideasonboard.com>", "date": "2025-10-21T08:06:50", "name": "[RFC,v1,1/2] libipa: camera_sensor_helper: Add imx708", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1ecc2530677b5a59090c17cfbf32328aa0fde4d3", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24708/mbox/", "series": [ { "id": 5514, "url": "https://patchwork.libcamera.org/api/series/5514/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5514", "date": "2025-10-21T08:06:50", "name": "[RFC,v1,1/2] libipa: camera_sensor_helper: Add imx708", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5514/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24708/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24708/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27A97C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Oct 2025 08:06:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9BBA60769;\n\tTue, 21 Oct 2025 10:06:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6AB860757\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Oct 2025 10:06:54 +0200 (CEST)", "from pb-laptop.local (185.221.141.231.nat.pool.zt.hu\n\t[185.221.141.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 787E51387;\n\tTue, 21 Oct 2025 10:05:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PcHKjAbz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761033911;\n\tbh=fnJIQywSh1uz7dx31rDPvbe306BL5cGXYnbF+W5DOYw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PcHKjAbzlDU5VWhJlgeD0RDJXwZ35qZb+BRfT/zGnwBLVGWiKoHdzjte1WHuxYkf7\n\t/hnnZQc7bN8eTIWLGE+qFdIQmTOOI8CbP0YwozI+Df3hgjoEctwXAjm/oDSWiE8u/B\n\tsM9Ephe9dDhWwNSs9uPt/NZPTWcjyFdT58KOlH9c=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "Subject": "[RFC PATCH v1 1/2] libipa: camera_sensor_helper: Add imx708", "Date": "Tue, 21 Oct 2025 10:06:50 +0200", "Message-ID": "<20251021080651.401753-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.1.dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Daniel Scally <dan.scally@ideasonboard.com>\n\nThe imx708 sensor driver has long been available, especially in raspberry pi\nkernels; and the raspberry pi ipa modules had the corresponding helper classes\nsince 952ef94ed78d71 in 2023. The camera sensor properties database also has\nan entry for it, but the camera sensor helper classes are missing from the\ncommon libipa component.\n\nSo add camera sensor helper classes for all four variants of the sensor\n(wide, noir). The gain calculation matches that in the raspberry pi ipa.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n[Add variants, rewrite commit message.]\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 25 +++++++++++++++++++++++++\n 1 file changed, 25 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex ef3bd0d62..829743a6d 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -642,6 +642,31 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n \n+class CameraSensorHelperImx708 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx708()\n+\t{\n+\t\tgain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n+\n+class CameraSensorHelperImx708Wide : public CameraSensorHelperImx708\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx708_wide\", CameraSensorHelperImx708Wide)\n+\n+class CameraSensorHelperImx708NoIR : public CameraSensorHelperImx708\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx708_noir\", CameraSensorHelperImx708NoIR)\n+\n+class CameraSensorHelperImx708WideNoIR : public CameraSensorHelperImx708\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx708_wide_noir\", CameraSensorHelperImx708WideNoIR)\n+\n class CameraSensorHelperOv2685 : public CameraSensorHelper\n {\n public:\n", "prefixes": [ "RFC", "v1", "1/2" ] }