Patch Detail
Show a patch.
GET /api/patches/24675/?format=api
{ "id": 24675, "url": "https://patchwork.libcamera.org/api/patches/24675/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24675/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-31-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:42", "name": "[v3,30/39] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "52de320fc793e81625d308a3eb0c7cf29cf8db59", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24675/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24675/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24675/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B830C3336\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6BA460675;\n\tWed, 15 Oct 2025 03:23:40 +0200 (CEST)", "from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n\t[IPv6:2a00:1450:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC5A26063E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:25 +0200 (CEST)", "by mail-ej1-x62a.google.com with SMTP id\n\ta640c23a62f3a-b456d2dc440so958991066b.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:25 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"dpNMUCDJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491405; x=1761096205;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vlxxasN0ecjXETyHLhtP9Pf8S9g55SSgsBs4xwRJHHw=;\n\tb=dpNMUCDJSqZtl/3cRwVcmJSqUksp5HRgqV6pbvIs8DcCxR0JMV1OxrIqkJaeUNCgoy\n\tYPqY+LSiRcJ+dDfY4XBBMFdkFSM1h82wHet5fuVi3KqbRxHKNQUJNkORT1eVRASRnawW\n\t7qnzXk0igkSC00kC8feYf4JBSC2UQI47l8wYj4QgrYg9uo2LlGHaetrHrcG056nZgjPD\n\tN2o8ilnGd36QV2kZkDlg6H681yxZb7+KgUFDOyUKMxJ5pt/jo4exeVFf+7KJDsJOOW8C\n\t0httu2yHVcFwlsuXI+zkmQdWG38kZwOkn63w8P8BHhjojw4qrvL8lofvpPOyTdkY3mHH\n\tfHgQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491405; x=1761096205;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=vlxxasN0ecjXETyHLhtP9Pf8S9g55SSgsBs4xwRJHHw=;\n\tb=bMkpKvQVYlj1PIYo86PBqQsg/Jcm4PVrEvUxYuBLiooxeXrZCu30oqethuo5I7F/BM\n\tNRwuQ/FfXoU21urhfkm5PrCvGxkt4VQ9KHMxXIDzpsXtL9HH8BUXGbC4H7T83jv0H10f\n\t/UzH5aHHiEA6xrFpna//saZSPsfOoUgfzIzlbOvRkxqAfMXDm7upx86QqFt+3VDl8/mr\n\tilP0SwjuVacmBcfY4wzwjBevvOFShG/xzu+rxAydT5tqa3vY5bWm9JLkdiEpyP4uyrvf\n\twYCLXS8qHzK6l4MdsnabBCTBZ6g3bOh7AdMwujd0wZTqYiRN7gfsMXdDQEnoeIYcZLpM\n\th7cg==", "X-Gm-Message-State": "AOJu0YwvXR+bBFcEU3b9/yAT0sTFrhwjauZ8EfclGp7ar0RtF5b+tgeM\n\tkdsHY3II6bYKo0IAPf+dEBFjs2UynOaMNmxVofewH0peJLXyJBFw5lmUAkyC9UpD4x91q5kamM/\n\tlEyuP", "X-Gm-Gg": "ASbGncvw1HpoZEo6Q64tj+l3CzoJad0x5Q1bcyxiNDRCrWV/7xoyOW1uCUxqvdE5BWC\n\tFKk9RszjTs3ztmjbL0OdUw0rsODvyk0Emas2CwGNWeNBDT9gd/JZRqloiD/UYOB2oUsqYwOk42g\n\tiuk4BEfqR3/ZVoFxyU+7jY+nJcdydTGdLfgviHqr72bOXh+9xxWI1xw50xjUUo1ijJZb2PzXtJw\n\tXZoa/NCYBqFI3PWY2nuIF3DBi2gqRBOUM1D4QVBnBAVobRdz71mGVeo1lVwCeSiGPrXa+/IhcE+\n\tkTlvR87LTRzEq7CKquetvadVQD8cjaGr65qSDCY5pD4/aOCyOJyP20M5zYV93CZB7w2GrlTvoYa\n\tAglflD6jjdSjZ8h1kBMfL0uXQyoID7KtOs4GjG69mNk0h8CFXYZkWzYgYxeQhRdjQFPzlFHR1NB\n\tkWf4d4h5hvNgvNJZfuKMB7UH8n8BrOkCtbo23RS18/", "X-Google-Smtp-Source": "AGHT+IFBUJTiB1Z3S/Crac+zc8WhPxXUZ0v2LfqkzpKPezrNPgq6WOdPcTS0ZGL0dFbn85J5FyYfFA==", "X-Received": "by 2002:a17:907:7f0e:b0:b3f:33f6:fb57 with SMTP id\n\ta640c23a62f3a-b50a9d59a3bmr2596712266b.9.1760491405031; \n\tTue, 14 Oct 2025 18:23:25 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 30/39] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output", "Date": "Wed, 15 Oct 2025 02:22:42 +0100", "Message-ID": "<20251015012251.17508-31-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 4 ++++\n include/libcamera/internal/shaders/bayer_unpacked.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex 90bd6457..c0632eb1 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -268,5 +268,9 @@ void main(void)\n \trgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nindex 5955c2ea..74ce1509 100644\n--- a/include/libcamera/internal/shaders/bayer_unpacked.frag\n+++ b/include/libcamera/internal/shaders/bayer_unpacked.frag\n@@ -163,5 +163,9 @@ void main(void) {\n \trgb.b = texture2D(red_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+\tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v3", "30/39" ] }