Patch Detail
Show a patch.
GET /api/patches/24673/?format=api
{ "id": 24673, "url": "https://patchwork.libcamera.org/api/patches/24673/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24673/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-29-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:40", "name": "[v3,28/39] libcamera: shaders: Use highp not mediump for float precision", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dc97ff110d1bd4a28ed89752f81742ba2939ed68", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24673/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24673/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24673/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C463CC3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C1086066F;\n\tWed, 15 Oct 2025 03:23:38 +0200 (CEST)", "from mail-ed1-x532.google.com (mail-ed1-x532.google.com\n\t[IPv6:2a00:1450:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4DFD60645\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:23 +0200 (CEST)", "by mail-ed1-x532.google.com with SMTP id\n\t4fb4d7f45d1cf-63bc12a5608so3493505a12.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:23 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:22 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eS964H8E\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491403; x=1761096203;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=cUJFqDYki3YK+OJOP8bMQTtCqTPkXZk+/ynvLttZF9w=;\n\tb=eS964H8EYu44WC6Zy83SQPahoeuDNj3I7NL7bOa9mz8zGmXWewzr8hW9M+NjJ/EW4c\n\t7l7+mzJ561/wkRP9kpPFZkOjXsHiOIbzGGEyjHFFBM9jFt2ramj9+JLYZkEtjU+OiASv\n\ta0gj5GiHyCRFAPd3uvam5D18hWJrKM8pqhk0PwEQ5M1S8hyS2peWQXkw7WTUqnO8iwjx\n\tHptT1ZQbqlkg12SX33rhdiaqEQ9M7RlWLYP1P1xnXvbv1jsgHyYM7LlBCw9aPnrNjMNm\n\tTRLFfisem6GOlRCSp93cSEDoEqxnZYue6BDaEa47fEyY8yMkNSlkLqpdMcfSeYrfK/8I\n\tOlLQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491403; x=1761096203;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=cUJFqDYki3YK+OJOP8bMQTtCqTPkXZk+/ynvLttZF9w=;\n\tb=STuTw+75DoInmC8KK7vBmj/9f6L/NFAGu8XubkyptcMQ2L6yLzmBusPsnxpnmVKsS8\n\tfwKClx4L1FcERExRIqpq28S/awmCoSMRdqHc0FXjlbM8QMER7E+Ot/MvupOdI0I6MjwJ\n\t8iJGejNaSVhwCXUbJrzEuNMikHkrU87M5HmSEApYMU0xI7y8LWjFJ04UO+QGKCv/GCUo\n\tZg98HH8saCHL9ScIrX9yvIqfqeWu6OD6iJSqzTyfo71K3bnprMmEdGRBzmNkygwAs9X5\n\t9SZEGYtoYxBpyryU6TfCo+3oUxAWMpP7AT+Plyt+eN2sZG4m2p2wGsIPqngXgdCe3sER\n\t49og==", "X-Gm-Message-State": "AOJu0Yx73lwz9mWNDS6YE9XI+KDPihNmCH1kd2WK+aPl2H4v1xBTck9g\n\t+MNo3IlwtEl9/t+12MayDvo7C+Q8r4K7FNvJgFdc7CuwtFl5IvFl9qlRkDlcXCyiisR6oo0jHuH\n\trtg/R", "X-Gm-Gg": "ASbGncsauuvzb+FX8PCnVvYvJ+zsyqGJxFwECodJ0VhVuHwaUCy7Y7x0BtyU26TFuIj\n\t3ycfVV2n9Ll0AVuV6VgaPw6jZyok4aHH8cQbUWCjjgte0H8m0rIcHjjjnNXSi1/jWVd+yu3Imhg\n\tBTFZcqD4QCBOv+IYFfFQp1xfCkHzJ9k9F5fWDAJIpxAygWNH9Z8RSsdAFVBg+0IotNFeZ97mtLh\n\thfHPjFVmpl1bEJL7wOZistXqFpC5DqFiDOVg20w5ofsLgmHqp7HVEnKaOLE1Kw4Z0HI9m5SybnO\n\t87lGcx0z8EmJGDc0v77bV3HPwcTMX+63L/tnT++FSGFF3ESaymQmBGST61MgYvH67nIdcGM5Gl3\n\tej5EKnpJRqutlI/Xn5eIv7wW7SA/Qo2aX57ULNwvqdP3u1g20KMOZUSSJJZH+b0bON90UVpO54q\n\tZzQ7O/81ra9/mbPJEe/bRjTTgSrfU05A==", "X-Google-Smtp-Source": "AGHT+IFSMbKpMbjpGdMVpH2uytKNLVHQzenA1MeNQFgBcbhGDEMycMaQkuaQmwP+XhsaszSS3BN3hw==", "X-Received": "by 2002:a17:906:4fc3:b0:b41:12bf:e3aa with SMTP id\n\ta640c23a62f3a-b50aab9c91dmr2937146466b.16.1760491403108; \n\tTue, 14 Oct 2025 18:23:23 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 28/39] libcamera: shaders: Use highp not mediump for float\n\tprecision", "Date": "Wed, 15 Oct 2025 02:22:40 +0100", "Message-ID": "<20251015012251.17508-29-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We get better sample resolution with highp instead of mediump.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/RGB.frag | 2 +-\n include/libcamera/internal/shaders/YUV_2_planes.frag | 2 +-\n include/libcamera/internal/shaders/YUV_3_planes.frag | 2 +-\n include/libcamera/internal/shaders/YUV_packed.frag | 2 +-\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 2 +-\n include/libcamera/internal/shaders/bayer_unpacked.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/shaders/RGB.frag b/include/libcamera/internal/shaders/RGB.frag\nindex 4c374ac9..72439589 100644\n--- a/include/libcamera/internal/shaders/RGB.frag\n+++ b/include/libcamera/internal/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_2_planes.frag b/include/libcamera/internal/shaders/YUV_2_planes.frag\nindex 1d5d1206..d286f117 100644\n--- a/include/libcamera/internal/shaders/YUV_2_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_3_planes.frag b/include/libcamera/internal/shaders/YUV_3_planes.frag\nindex 8f788e90..8e3e0b4a 100644\n--- a/include/libcamera/internal/shaders/YUV_3_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_packed.frag b/include/libcamera/internal/shaders/YUV_packed.frag\nindex b9ef9d41..3c9e3e39 100644\n--- a/include/libcamera/internal/shaders/YUV_packed.frag\n+++ b/include/libcamera/internal/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex f53f5575..19b13ad0 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nindex 7e35ca88..aa7a1b00 100644\n--- a/include/libcamera/internal/shaders/bayer_unpacked.frag\n+++ b/include/libcamera/internal/shaders/bayer_unpacked.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n", "prefixes": [ "v3", "28/39" ] }