Patch Detail
Show a patch.
GET /api/patches/24672/?format=api
{ "id": 24672, "url": "https://patchwork.libcamera.org/api/patches/24672/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24672/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-28-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:39", "name": "[v3,27/39] libcamera: shaders: Rename bayer_8 to bayer_unpacked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "92563517212ccf09b73afa366b2a799656c6a24c", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24672/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24672/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24672/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1497BC3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93FAD6063E;\n\tWed, 15 Oct 2025 03:23:37 +0200 (CEST)", "from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D929560646\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:22 +0200 (CEST)", "by mail-ej1-x630.google.com with SMTP id\n\ta640c23a62f3a-b5a8184144dso331942966b.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:22 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:21 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"cAghXbyb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491402; x=1761096202;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=cRVEHiEipQ6SvLkbWQz7JxYpu6YoVwpwlf26Fgb4Ok4=;\n\tb=cAghXbybVOjiARJYDXzLUK6HhgyfEaNPl79RTMyYQD48RqCy+Ban5QAYE6DL3gtzef\n\tXWBUoNnHO8441OyVnEZqjFbGvWiLwRGfXoRruEZFSpIapvzoJ8Iv8YtiP0Zn9eBhUkmU\n\t/Ag3je40QueVMg07Y47M9n89YMcthKWsiDUGh72vzm5IKEF3KxNU4v66mWEkGf5on5L3\n\tc40zOdRSmC2lTCT/e89TbCwYphyxa84iQyUehq+5hWy9bG81R3TWhlZw7gy2zSV5Wc7K\n\tvNoa4oQtIGeFpJyFro+NIebBWT0/Hp1jlcSw87CZb9A0EWwtgVMRA3GjypjcA/vGohJv\n\t4K/Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491402; x=1761096202;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=cRVEHiEipQ6SvLkbWQz7JxYpu6YoVwpwlf26Fgb4Ok4=;\n\tb=tNejZXNqsEjukjDOACOgipKR0GxfQOdmr7vK08WIpaiPPvLg5Y3GOebB1k59jz+lzs\n\tk47HEGKfDz3vPffhqgL9ZXXlAdht6xdaJPuXpgVxBh+9B+J8qsvK/gMncMcY/M+NYLZ/\n\txVZX/Mu1PtCzHBsL75Yg0/WWrp7m38pj6i+4AQTIqIBrlkGznEUYDWZqa0CEcEmHxNgn\n\t9QcBJMBkl1SM25ku93vMnjmRBbATUKDUFkb6FSvXorZLmKyDZxMyTh91ZnIARZoPuqdq\n\tEhTD8kU0uSAx8DYPAL239P4FbUGFyNQFbyRuqrFukkI8xEyXfQgAMf/IuSivT9fr6xmZ\n\tAoFQ==", "X-Gm-Message-State": "AOJu0Ywx2B8DW38EKTYkxC6+688fvcH+DxoDg7mHjIG3xCWl5a7/nbBj\n\t80PmmVdIffwlyDrEJJA2rhJDJuEavjiWUEzYN6YmQ2mWfTl/cxth7XVpQNE1yFMBCv3VNsXGrEn\n\t3VjYp", "X-Gm-Gg": "ASbGnctaHZz+ffyT73/3JK0j+FOXZdMsxB8ksgmXgabJ4ulxm/5kM2lyDlP8ce2rpRg\n\tjFUBo/yFJ8JHVUB7D3xes5EmDic2h5QfrL/ph5D/Fh3VsE8WvEsYM/nJj8NEK2+8rNq8DVU3shz\n\tdfWPILA6+CNgA8XDihm2jLYmv1gO5Q/BSCLTUKxgdM5AW27TeoDYToqL1nhynL/NdT5Dsj7AjrF\n\tCD6dP/zouQF566SxSkyVloIRnR2JlJaZqW2Btd3s+jfrkvZMyfp6I0fqzZMDT8+TyDPXdE2BmmP\n\tPiy3xe7rWHl82jdJiUpbmgFQd8QVc7Cwzf1TTN+EdI0FmME3y5SOnGYeHugJllN2BTS8qBFmnzg\n\tbx9a9hygrxh482v8DhK9BLabUfqFI1ZwYu8xo9Vaj0sg7uz+EkTfhl5NZOczYZ4LkynYgKao46D\n\t46jNbG97RwI7FwYuERLYstVeESQybtew==", "X-Google-Smtp-Source": "AGHT+IEBfgYNNf/Ho6kVraoSYcIxbAZ4znSAoOR5FV3Ef+EGq1LYYlpP143JvZ1qE8RNV6+TEZaZtw==", "X-Received": "by 2002:a17:907:6d25:b0:b40:52:19c2 with SMTP id\n\ta640c23a62f3a-b50aaa9c937mr2825866366b.20.1760491402094; \n\tTue, 14 Oct 2025 18:23:22 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 27/39] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked", "Date": "Wed, 15 Oct 2025 02:22:39 +0100", "Message-ID": "<20251015012251.17508-28-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Milan Zamazal <mzamazal@redhat.com>\n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n include/libcamera/internal/shaders/meson.build | 4 ++--\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename include/libcamera/internal/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename include/libcamera/internal/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)", "diff": "diff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from include/libcamera/internal/shaders/bayer_8.frag\nrename to include/libcamera/internal/shaders/bayer_unpacked.frag\ndiff --git a/include/libcamera/internal/shaders/bayer_8.vert b/include/libcamera/internal/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from include/libcamera/internal/shaders/bayer_8.vert\nrename to include/libcamera/internal/shaders/bayer_unpacked.vert\ndiff --git a/include/libcamera/internal/shaders/meson.build b/include/libcamera/internal/shaders/meson.build\nindex 386b342d..dd441a57 100644\n--- a/include/libcamera/internal/shaders/meson.build\n+++ b/include/libcamera/internal/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\ndiff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 04f9d706..32dfa51b 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t<file>../../../../../include/libcamera/internal/shaders/YUV_3_planes.frag</file>\n \t<file>../../../../../include/libcamera/internal/shaders/YUV_packed.frag</file>\n \t<file>../../../../../include/libcamera/internal/shaders/bayer_1x_packed.frag</file>\n-\t<file>../../../../../include/libcamera/internal/shaders/bayer_8.frag</file>\n-\t<file>../../../../../include/libcamera/internal/shaders/bayer_8.vert</file>\n+\t<file>../../../../../include/libcamera/internal/shaders/bayer_unpacked.frag</file>\n+\t<file>../../../../../include/libcamera/internal/shaders/bayer_unpacked.vert</file>\n \t<file>../../../../../include/libcamera/internal/shaders/identity.vert</file>\n </qresource>\n </RCC>\ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 70f60065..95965ab7 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\n", "prefixes": [ "v3", "27/39" ] }