Patch Detail
Show a patch.
GET /api/patches/24667/?format=api
{ "id": 24667, "url": "https://patchwork.libcamera.org/api/patches/24667/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24667/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-23-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:34", "name": "[v3,22/39] libcamera: software_isp: debayer: Introduce a stop() callback to the debayer object", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5e8cbe1d9cf4b3d6a4b59695cb30ec69304d7042", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24667/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24667/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24667/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78A35C3334\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E314560654;\n\tWed, 15 Oct 2025 03:23:30 +0200 (CEST)", "from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com\n\t[IPv6:2a00:1450:4864:20::52c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A11C060626\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:17 +0200 (CEST)", "by mail-ed1-x52c.google.com with SMTP id\n\t4fb4d7f45d1cf-63b9da57cecso5187733a12.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:17 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:16 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eBekZxVF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491397; x=1761096197;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TcjrI2pwXI63DofETtDiLdp+t1mdKMGi9/omHCjy1Os=;\n\tb=eBekZxVF510LuS8z4/4PVRserTpqdxmUlBeVXs6u7xAjhFkeqDic+6pJXLb0TQ2zKT\n\tIE9o0cV0BlmhBJ3HhUIBsB+yIAutUISgHuqjVnUdmECYw2krgfKhTScYtvHiosr54Wdi\n\tZgYVeB4VSLyO8yiHaDSJbYTuDCJFL4v+wLrJXJ5iQhA608tntRTW0SInIRBIP3tneH61\n\t9yCQQQ+Mh0ZSW2tXdTtLZi/02hD/QglPkOfcMpSugmC2Lb2qPfcXi6YgWf0EsEi52yp9\n\tc3w3MRWXCRPegSQhjwgxb2cR37vSJ67mvnJBedjBhU+yCU/DFXyuXzTfkiRnXWKRjUQS\n\tIyqQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491397; x=1761096197;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TcjrI2pwXI63DofETtDiLdp+t1mdKMGi9/omHCjy1Os=;\n\tb=dhrxFfWYG8BrsoSh/wDIBZcYRGW1/NQqIxLowkm20yF30C25KofKOlTE0qWWSg0xwo\n\tbT/5tu3q5vF+dLwED9L9KaX93tpA9pJPForJvKJ12jt/QNMbzSbco8q+KxsSHI1y9sAV\n\tTnYhAxkgRQm69DzI5pwjkjxfOoTX8YLR40ubjesYUQamsKs6qF4Ev7CgAjFkOZeXj/Iv\n\tVfXwJnwGJ4VxeRmFQj6hWMgLe4s/WxbCYerXfCKuT7F49zdHBp5bWVRC9ZDihtA4pkZu\n\tndGVi/12zuFaiZOizKCbH07Pj9qa1bHZuaGzSPu7XxR/C3t7fClbLZy9t+ioh59MvUaU\n\tX/zg==", "X-Gm-Message-State": "AOJu0YxAUkdwmDlBL666QEIBJ77t/jSw73sSmra+2mvfMF/s2mOTvLRh\n\tWaLs7lVDJ7nZjQooOPJavovuny4PzUvfqH2az+hiJhREwbKz6PnFfHYwegNWh5HbpbYhGfHzH0x\n\tRpSFM", "X-Gm-Gg": "ASbGncustIXdmZNX8zpFO855ZDObj4YGQrvX7mDy8hZ/UZaXz2sCwFW7n6zgUkE3qYw\n\te0CJxxkdvlhahQjifK3jSqXFCgv8jMU3KORZjv5h3mzMFBtjot0lIeIZ4ki+Yiua+1SCv/FEGBi\n\tKpVoPa+FZqa6aN76pFW6RulV42jwq/E24jl+iPiWhgWQ3KVDqQKppMWCU+gdkSh0Kwl2Ps2xEyK\n\t1qJfaxaAu3NXMO9tATrwxK1s6XwMXiw5vqPHMC/Ffj9Q2iHshjOqeYeu4NbXxpwUqs3Q7Gm6hoa\n\tch3FjfJa9mHI78FgGEXTL7bXvboCbHsomHO7Y36IboUYNxfVTym+2K4qcl0nMBRbRgH9/NLxd+O\n\tr0SK7mMIBvmmf0USHSiw+NDt1g53yDPHJhYLTam8QvkUlMWsNkX2foRg/yOa68EMZ1TdPXZbD9C\n\tOFqyasgpiKRqKTcUZidz8m0727aHaOag==", "X-Google-Smtp-Source": "AGHT+IEJioIdjnrx0V+L342PmGSB6hPcUzAql28Sl5XMO2Le0FyjbgD7NcMhc0qd6fitrz8IKmp1lQ==", "X-Received": "by 2002:a17:907:26c5:b0:b3b:f19:ac7c with SMTP id\n\ta640c23a62f3a-b50aba9e59bmr2630102466b.36.1760491396758; \n\tTue, 14 Oct 2025 18:23:16 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 22/39] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object", "Date": "Wed, 15 Oct 2025 02:22:34 +0100", "Message-ID": "<20251015012251.17508-23-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The eGL class wants to be able to teardown its sync_ data member\nproperly but, doing so in the destructor means we can't make the eGL\ncontext current and thus can't tear down the sync primitive properly.\n\nIntroduce a stop() method to the debayer class which triggers from the\nsoftisp's stop method, allowing a controlled and appropriate tear-down\nof debayer-egl and egl class related data well before the destructors\nget invoked.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.h | 1 +\n src/libcamera/software_isp/debayer_cpu.h | 1 +\n src/libcamera/software_isp/software_isp.cpp | 3 +++\n 3 files changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex c5eb0d38..8fa281c7 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -48,6 +48,7 @@ public:\n \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) = 0;\n \n \tvirtual void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params) = 0;\n+\tvirtual void stop() = 0;\n \n \tvirtual SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) = 0;\n \ndiff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex ff72eaba..3cc07028 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -38,6 +38,7 @@ public:\n \tstd::tuple<unsigned int, unsigned int>\n \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n \tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params);\n+\tvoid stop() {}\n \tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n \n \t/**\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex df72b1c3..1f984a52 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -366,6 +366,9 @@ int SoftwareIsp::start()\n */\n void SoftwareIsp::stop()\n {\n+\tdebayer_->invokeMethod(&Debayer::stop,\n+\t\t\t ConnectionTypeQueued);\n+\n \tispWorkerThread_.exit();\n \tispWorkerThread_.wait();\n \n", "prefixes": [ "v3", "22/39" ] }