Patch Detail
Show a patch.
GET /api/patches/24658/?format=api
{ "id": 24658, "url": "https://patchwork.libcamera.org/api/patches/24658/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24658/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-14-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:25", "name": "[v3,13/39] libcamera: software_isp: Make output DMA sync contingent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bbc24e3404e986b0c8daa2edfa4d9c57eda948ad", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24658/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24658/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24658/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EB7BC3332\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 265CA60628;\n\tWed, 15 Oct 2025 03:23:18 +0200 (CEST)", "from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A733960623\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:08 +0200 (CEST)", "by mail-ej1-x632.google.com with SMTP id\n\ta640c23a62f3a-b3ee18913c0so965014666b.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:08 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:06 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ejfU1W1M\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491388; x=1761096188;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=X8BVCiPsJ20OX+RnXwnsSBdZMAPl34rKU86maQCSeW8=;\n\tb=ejfU1W1M/9pERQ11XOjaGMik5kYIUJBzDewTrM4h1noTNJbS+1RuyeTCj1kSZcr/9z\n\t29GVpImqM6iMeUnzRrtow/05xhmBm70WFXDT54hmUvRf1QzQAYbW02rKg/2J+XHuwe+k\n\tT4mBNy9voTnjqs9j6/Y1y9PglVIs4OfjPDAogjMZNuzZXTyF18AJG00a6R0RDpZ4uc0L\n\t1YiYqRy/Q4BBh+h1DdDbsWEDYT+jw6gWxGPKsnaefYfdqXNzbTg+P76rkviCZ/PomcvQ\n\tqvDDOER272UHI26jqjDKOo1W4bMelJC9tYWnu+2Wp2fPWZVWqlKynynGQmunoMbk0Dk6\n\tzQ5Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491388; x=1761096188;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=X8BVCiPsJ20OX+RnXwnsSBdZMAPl34rKU86maQCSeW8=;\n\tb=B36fP/hYT8U2uzulLkfwPiZPFWGWDnQ0+p00BvkIoDUbntwURV7QpWWcNIoAbS604+\n\t9Lw/Ksk/iQKxA2lmig8F6WvCKHSijxMWhFJAPntTmPtbiVtz8aKIoqt+fbpLqE1NvPcp\n\tYUaOuXw0wwDih2KlEhjfDi/PnE2iKWudxLiQ29wQqGRJxsxvJ2ua4uVrSqCsZO5Aq4e1\n\tcJD4H2G1Y3NW49sxzArfjB3YO2ZlnAJBgL8ZaI47c/lJluOwD6rkKmtLkfDU3JAyZ8Vd\n\tE9s9zTEpew6f2vRV9zPHCu4xNNQoZMlHChUTpUvgFbamKwhW+Hvn9OB8UQgyJjV6BYwO\n\tBgpQ==", "X-Gm-Message-State": "AOJu0Yx+DJnzx0XhdJ+F+5W4lSKAq5EP/B0K6eyJ4dLfyokXxzgqQmUL\n\tsG670Oc4dpvnBXIpOymVJqtvJESCfNGanCATASuZ9vej+njBJvXxGEVkoVN5QPil/z3nhKJ0gct\n\tJ2VlE", "X-Gm-Gg": "ASbGnctMg95wQM58LiEA9S0py9F6rpV8Kb7AAa2PnXPZyaIWkWo0haeib1bwOaKWU7y\n\tj7GsGKpZmGvb33gztmfkEgw+6Moso+YOsLllZNztS/X5yI+5AnlKJJgWVBNCHc+ybDlnYxj0J6l\n\tPeNdEJ24txsSGfxHhILqcQhtTJXG2CKe2qnxp1ty4MliyHVCDutAKPDsEXg1LQvnG85oslB5dfA\n\tvYznpP2lNikDBJ2RDMwuVjK3FQ6GOspryWdhzBe16xRX6f1S3OiHjB0tG40j6BHw2Dii+RSl5W+\n\tSFinhTPuv63CaNMUSAcXcX2EvtSKiTRhXYNaDDcRDMFhP7ifzShATOoDecsFxz8Nt3YpXdGDW2P\n\tN/+DgBVBtrzNMm5gdjrPbLU/Xy2l9p4+DkZJlBxwdbuUpFhU0vXURhyLn8rFMd5Ty+jGfPeYn27\n\t2o70FUmt9+R3NIkt9YLw4mO7IGfHUECnLstQG4+eDI", "X-Google-Smtp-Source": "AGHT+IFwl/PRrmj32I33SAQDCfAv33qd36LXUt5m8+CiEiErR8C1iWDyb7pV6Ix70JVs1HGjr3D2GA==", "X-Received": "by 2002:a17:907:7f8a:b0:b40:448d:cdb0 with SMTP id\n\ta640c23a62f3a-b50aba9f873mr2792191566b.41.1760491387938; \n\tTue, 14 Oct 2025 18:23:07 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie, Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v3 13/39] libcamera: software_isp: Make output DMA sync\n\tcontingent", "Date": "Wed, 15 Oct 2025 02:22:25 +0100", "Message-ID": "<20251015012251.17508-14-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The DMA sync output buffer from the GPU need only have its cache\ninvalidated if the CPU is going to modify the buffer. Right now this is\nnot required for gpuisp so only act on the output buffer if it is\nnon-null.\n\nSuggested-by: Robert Mader <robert.mader@collabora.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 847067aa..96737c45 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -223,8 +223,10 @@ void Debayer::dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *inpu\n \tfor (const FrameBuffer::Plane &plane : input->planes())\n \t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n \n-\tfor (const FrameBuffer::Plane &plane : output->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\tif (output) {\n+\t\tfor (const FrameBuffer::Plane &plane : output->planes())\n+\t\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\t}\n }\n \n } /* namespace libcamera */\n", "prefixes": [ "v3", "13/39" ] }