Patch Detail
Show a patch.
GET /api/patches/24649/?format=api
{ "id": 24649, "url": "https://patchwork.libcamera.org/api/patches/24649/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24649/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-5-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:16", "name": "[v3,04/39] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8da0e9fb46d79d4b5aa0d845428e9003b11c74ec", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24649/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24649/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24649/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78758C3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA48C605FF;\n\tWed, 15 Oct 2025 03:23:03 +0200 (CEST)", "from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F76D6060A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:22:59 +0200 (CEST)", "by mail-ej1-x630.google.com with SMTP id\n\ta640c23a62f3a-b3ee18913c0so965005166b.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:22:59 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.22.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:22:58 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"fZe0xwMW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491379; x=1761096179;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Iq/QQZnzG0Y02cPlHt1zWbTY7RnwaVpFXzmCvziIA+w=;\n\tb=fZe0xwMWMGo8C6oUdOa/l40J7hzAs5KkvvyTHKyCzyNo9TyJZQLY+n6yj6a716qGE2\n\tBuU4aOvwbIxALS9ZpisJtT9QYM67bcOgFIQQnXWwnfhUlHHFc/PU5MAFC820QofLouuk\n\t6/2xdPiunkrMKbpi+T2OmULkB1wpKO2v0JOYC1UrGV2yeo77y6iUhK0FxzMsdywhRiR1\n\tOYVMJ/ti/E6Q7xADyN8ZpWb23QTbkLISevHgt2Ius2TFqA568xwVnv8FOpPsqj63fKwT\n\tgjmPfzgyqUzj8OEJ/vfsEAGY5jbWFgWGqTc1KOVVWTy5U8DYLb8Kecgr2Rcy69vE90m5\n\tAk8g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491379; x=1761096179;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Iq/QQZnzG0Y02cPlHt1zWbTY7RnwaVpFXzmCvziIA+w=;\n\tb=luaSZO7i69z7xAIgqiLLUdLuWB8VJHn56dC9W5dD9ZjKoGWJAvDaUwbiioTNdwghr5\n\t1wbwxhh5NGXPUMrZjJ2lQjkgDrFhUq7zl+G+X9Pg4bDSHfwNYRz9QDeZ3GHlKRxtleuW\n\tM/GkrAe1EA+vC537PtoCOPivMrNJXeulhAriZ+dDxK+dbuYNG6pcmsFKy/0H30Dn5/Sd\n\tipb9YCV4Z/zV9Z8Qdq9qYiJR8eEDhlx0UDA6XF40i1DEUQ9PZuVlEQcKQcIXfdFd2Lo1\n\tZJ2vvpnBeqO7yumnJYedRi39n9t2o08xVDQrymmag7mhTiomCT0DsSbkWXbB8iro17O0\n\tpYFg==", "X-Gm-Message-State": "AOJu0YziFSph9pxJwuGk2iDr0kHFIMzzejNNS4skoR48ud2cc0jF0rKX\n\tmTTdIB3OvIMyd6EHI8qERQmWLpBZP0hM+PP4W3Oi4MTnnOmo8Uyu30Vgzt477Ao7zevNogG2V9T\n\tQ/wYb", "X-Gm-Gg": "ASbGncvWKj/T7YdUE4f8X+ySdMkjXkdVqlH0+2Lw7fPITalHt4T8Wr8jJZZUO4sNtqD\n\thAtTzcbR2ax1Z3ZNQVauW66/RF0T3YoqB3e2Ivzf0rEPmpMy3zQlm+Js/7B1hidcQbPZ/Bb7uoy\n\t5Uzpu6h7BqsmeQxbTQZYccfAm786cvWcuoLToYtq6qBjIR4bIuIKJrgYGctWrHt3GGFt0FLkORB\n\tEQgC5v6mwW5bjEcqMVdNf9YsDkKgQzTUUxtrROxSQo88ZcaQ3VyOGAH0kX8w2tbnuI1Ctm8iy6P\n\tcji+b2UB4n91/9E6D8nW1jkA3Hn7+07pRPG89GQ2+GCrZ+BtvqvzLq04i1uBrMBPePd68wThC54\n\tCtMfqIDpbb0FD0eBnQ4zX+1QQDULr1s7TozifJIlkcZmzy40CrOrFaDRXXoER4PACVr3EoXEoqP\n\t7EdJExu78YURVPkn8+eHfA31yJe3X7gOhtXuWKhahK", "X-Google-Smtp-Source": "AGHT+IFV7v50DkMRAyePLHrzpFA9FM4KFCTak0EP0i1/fA8DD4uhz+zlRSUno72VWuZKT5drN37Svw==", "X-Received": "by 2002:a17:906:fa0e:b0:b55:a883:63c4 with SMTP id\n\ta640c23a62f3a-b55a8841f25mr1816867066b.10.1760491378718; \n\tTue, 14 Oct 2025 18:22:58 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie, Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 04/39] libcamera: swstats_cpu: Update statsProcessFn() /\n\tprocessLine0() documentation", "Date": "Wed, 15 Oct 2025 02:22:16 +0100", "Message-ID": "<20251015012251.17508-5-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\nUpdate the documentation of the statsProcessFn() / processLine0() src[]\npointer argument to take into account that swstats_cpu may also be used\nwith planar input data or with non Bayer single plane input data.\n\nThe statsProcessFn typedef is private, so no documentation is generated\nfor it. Move the new updated src[] pointer argument documentation to\nprocessLine0() so that it gets included in the generated docs.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 4f7bdd23..9c03338a 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -72,6 +72,19 @@ namespace libcamera {\n * patternSize height == 1.\n * It'll process line 0 and 1 for input formats with patternSize height >= 2.\n * This function may only be called after a successful setWindow() call.\n+ *\n+ * This function takes an array of src pointers each pointing to a line in\n+ * the source image.\n+ *\n+ * Bayer input data requires (patternSize_.height + 1) src pointers, with\n+ * the middle element of the array pointing to the actual line being processed.\n+ * Earlier element(s) will point to the previous line(s) and later element(s)\n+ * to the next line(s). See the DebayerCpu::debayerFn documentation for details.\n+ *\n+ * Planar input data requires a src pointer for each plane, with src[0] pointing\n+ * to the line in plane 0, etc.\n+ *\n+ * For non Bayer single plane input data only a single src pointer is required.\n */\n \n /**\n", "prefixes": [ "v3", "04/39" ] }