Patch Detail
Show a patch.
GET /api/patches/24609/?format=api
{ "id": 24609, "url": "https://patchwork.libcamera.org/api/patches/24609/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24609/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251013063820.90805-2-uajain@igalia.com>", "date": "2025-10-13T06:38:18", "name": "[v2,1/3] gstreamer: Shorten function name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9553939a209303af9c24c90b983a490db4daaac1", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24609/mbox/", "series": [ { "id": 5493, "url": "https://patchwork.libcamera.org/api/series/5493/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5493", "date": "2025-10-13T06:38:17", "name": "gstreamer: some assorted fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5493/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24609/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24609/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 813DDBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Oct 2025 06:38:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 342B460453;\n\tMon, 13 Oct 2025 08:38:09 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 842C26045C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Oct 2025 08:38:06 +0200 (CEST)", "from [49.36.127.56] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1v8CC5-008oXX-7j; Mon, 13 Oct 2025 08:38:05 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"lJLyW+Ul\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:Content-Type:MIME-Version:References:\n\tIn-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=S+UfEgWxtxZ1NRta7y9s8lVpYyFQeWqMkWL6rKxu3uo=;\n\tb=lJLyW+Ulv3lrJRX4dtaceSyd6M\n\tqD7wZYEcyIij7MVtdxZjJNDb3d0BzJUtpF1mO6kM1uwykqxQnh2K5J/0+0le9ZTDhoH7s3hibHh9D\n\t6uehONZciIvQtzxX1bn9IBMTIjRS51XKCZBnV15bKadf/JiMq1LKIdG5TY25R+63mrzrPIJ4t+x9u\n\tZtAsnQXPpNe++s5eSJZ8R+0CaZCs03mxT7OYLLEz5+LiiV/r53Q9CXi7y43mamMlxIlv7j9RMiApR\n\t3fnuPh+vFDfM+rh1V5JeCMZMhEPWmkco1xYvPCEbt3FKpYqv6wOJ4XvuRmBp4aAotl0G0+PPqXZij\n\tTIrJMy8w==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>, Umang Jain\n\t<uajain@igalia.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v2 1/3] gstreamer: Shorten function name", "Date": "Mon, 13 Oct 2025 12:08:18 +0530", "Message-ID": "<20251013063820.90805-2-uajain@igalia.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251013063820.90805-1-uajain@igalia.com>", "References": "<20251013063820.90805-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Shorten the following utility function name:\n\tgst_libcamera_stream_configuration_to_caps()\nto\n\tgst_libcamera_stream_cfg_to_caps()\n\nComestic fix only for slight readability enhancement.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 4 ++--\n src/gstreamer/gstlibcamera-utils.h | 4 ++--\n src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n 3 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex bfb094c9..09f274b5 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n }\n \n GstCaps *\n-gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg,\n-\t\t\t\t\t GstVideoTransferFunction transfer)\n+gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg,\n+\t\t\t\t GstVideoTransferFunction transfer)\n {\n \tGstCaps *caps = gst_caps_new_empty();\n \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\ndiff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 35df56fb..06ea9289 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -16,8 +16,8 @@\n #include <gst/video/video.h>\n \n GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n-GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n-\t\t\t\t\t\t GstVideoTransferFunction transfer);\n+GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n+\t\t\t\t\t GstVideoTransferFunction transfer);\n void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n \t\t\t\t\t GstCaps *caps, GstVideoTransferFunction *transfer);\n void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps);\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 79a025a5..9ff90d9a 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\tGstPad *srcpad = state->srcpads_[i];\n \t\tconst StreamConfiguration &stream_cfg = state->config_->at(i);\n \n-\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n+\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n \t\tgst_libcamera_framerate_to_caps(caps, element_caps);\n \n \t\tif (status == CameraConfiguration::Adjusted &&\n@@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\tGstBufferPool *video_pool = nullptr;\n \t\tGstVideoInfo info;\n \n-\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n+\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n \n \t\tgst_video_info_from_caps(&info, caps);\n \t\tgst_libcamera_pad_set_video_info(srcpad, &info);\n", "prefixes": [ "v2", "1/3" ] }