Patch Detail
Show a patch.
GET /api/patches/24598/?format=api
{ "id": 24598, "url": "https://patchwork.libcamera.org/api/patches/24598/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24598/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251012142052.90611-3-robert.mader@collabora.com>", "date": "2025-10-12T14:20:51", "name": "[v5,2/3] pipeline: simple: Increase internal buffers for software ISP to 4", "commit_ref": "9e2ced29425c400f1129d007fa31508e2029bc3d", "pull_url": null, "state": "accepted", "archived": false, "hash": "d383f9ef6c421f18559d950c1aa55bb3a8aa17bd", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24598/mbox/", "series": [ { "id": 5487, "url": "https://patchwork.libcamera.org/api/series/5487/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5487", "date": "2025-10-12T14:20:49", "name": "pipeline: simple: Allow buffer counts from 1 to 32", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5487/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24598/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24598/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBDB5BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 12 Oct 2025 14:21:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 946336044D;\n\tSun, 12 Oct 2025 16:21:33 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE0906043B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 12 Oct 2025 16:21:31 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1760278886446138.07378562727797; \n\tSun, 12 Oct 2025 07:21:26 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"LcWfVXQX\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1760278888; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=m5orL+soW89HZF2436xtcZfe1UIS1GuLGI8VIkC/uzqnq1vNxEKOjcRtiL05ty0jgBeZSDZntM+E/pbcLQrXvbL2N/2PCdO///ftWWppkPcFPklIJYJA6Dx4zQwxQ2A7oejJ/SQ/3OZSS+KwYO3CUN9042ycf7M2rGtPU8NzKRM=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760278888;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=GkEByCVGx7IzlUYp8SwPyh4VMxUfk3wni3VtX4Iv8Rc=; \n\tb=IQBytGo5vJq9q8AHu780K3ERqAqpKGLCkKYy6G1QOH/R1W+XgQBo26MJ3PKN+x+PK6/zHCm54Br8hhXnWXDD+OA5aEE8pxggNfQKhdJndNqJPdL3F+VaXYihAdACimzGIL3nS99KXtYsz3HKysXzokYJBVLI7WiX17Q4ooh0KH0=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760278888;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=GkEByCVGx7IzlUYp8SwPyh4VMxUfk3wni3VtX4Iv8Rc=;\n\tb=LcWfVXQXm8fs6rzJIagydJFZTsj73nn3gK08UjbIgHiVcyeaO7CiQy6M8DPBC4r6\n\tV7tDG4AxTFoO9b3+wK6Dm7iTmOk7C1KQBlJ6AXVz1cWqUU7VPG7yUixI7O61aARaIX4\n\tzeC/MGF0nZsEsB7RAKOvq/+u+XH67sXJNiz4cCa8=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v5 2/3] pipeline: simple: Increase internal buffers for\n\tsoftware ISP to 4", "Date": "Sun, 12 Oct 2025 16:20:51 +0200", "Message-ID": "<20251012142052.90611-3-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251012142052.90611-1-robert.mader@collabora.com>", "References": "<20251012142052.90611-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Simple Pipeline handler supports a variety of hardware with\ndifferent capabilities and performances.\n\nTo improve performance and reliability of the cameras across the\nsupported range, increase the number of internal buffers to 4.\n\nThis allows lower performance devices more opportunity to process the\nframes and increases stability.\n\nAlign the Simple Pipeline handler and Soft ISP buffering with the other\nhardware based platforms and use 4 internal buffers.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\n\n---\n\nThis has been applied in postmarketOS since Oct 2024 and has fixed issues\nreported by users.\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6e8271346..6a2ffe624 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -418,7 +418,7 @@ protected:\n \n private:\n \tstatic constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n-\tstatic constexpr unsigned int kNumInternalBuffers = 3;\n+\tstatic constexpr unsigned int kNumInternalBuffers = 4;\n \n \tstruct EntityData {\n \t\tstd::unique_ptr<V4L2VideoDevice> video;\n", "prefixes": [ "v5", "2/3" ] }