Patch Detail
Show a patch.
GET /api/patches/24597/?format=api
{ "id": 24597, "url": "https://patchwork.libcamera.org/api/patches/24597/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24597/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251012142052.90611-2-robert.mader@collabora.com>", "date": "2025-10-12T14:20:50", "name": "[v5,1/3] pipeline: simple: Initialize maxQueuedRequestsDevice to 4", "commit_ref": "d82780801db776038ecbe1c181446f7b4e098dba", "pull_url": null, "state": "accepted", "archived": false, "hash": "29c3bacc9faad0f9303cf638498e9c7a9a1cae5f", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24597/mbox/", "series": [ { "id": 5487, "url": "https://patchwork.libcamera.org/api/series/5487/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5487", "date": "2025-10-12T14:20:49", "name": "pipeline: simple: Allow buffer counts from 1 to 32", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5487/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24597/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24597/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE6EEC3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 12 Oct 2025 14:21:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 054AD60448;\n\tSun, 12 Oct 2025 16:21:31 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 695D5603ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 12 Oct 2025 16:21:28 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 176027888398845.66199855487878;\n\tSun, 12 Oct 2025 07:21:23 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"Ba7MqWmE\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1760278884; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=c4fGGDcAc8Bb1msb5b944AD+JTUWG3dsHQXGafV9ewwD76oSehgpuJmLe9RuboY8Cs6ValP6K3GsVNwNtaqocld6kXRiSsnguK4Pz0HXirRz/zPU88m9DGwTdogjQE3ZKZH24dbf0HTeV3DrrgBeUo7ifgtpOD+VMIDEzaIl6+0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760278884;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=eD++56ezFeHc76bmVc8rSqAjz/JrJETUCJxii0+Wbws=; \n\tb=NMCscxgAx/VyBlDIwFbk9p5LqEu1Td4DMufaHyBcywElxYCL4RB9eURp6/4RwtneKscF8cOANP9Mxznmx12z/yka2sVyyJB37z8zfBDueFnQb7tm9WWdWc5A/soe+Tj1jWCOvFyFyPaF8Fgo7bRX3zJ8dAk1gHQiRaC9nuEY6yw=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760278884;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=eD++56ezFeHc76bmVc8rSqAjz/JrJETUCJxii0+Wbws=;\n\tb=Ba7MqWmE630UuQKEf2KyeiB3f7E+annt+TcmJFmCtNt+r845RLRIMdm3s9MbrhDM\n\tQJI33NjYoOpX3gwSOZK1Jky7eBHmSvGn1IsMDeNTNS8MSChc9dJ2ouArLXFd4WDmIFi\n\t8jjq+sURU6yXhtW8+id71+9pN098wl/DVnEXJoC4=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 1/3] pipeline: simple: Initialize maxQueuedRequestsDevice\n\tto 4", "Date": "Sun, 12 Oct 2025 16:20:50 +0200", "Message-ID": "<20251012142052.90611-2-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251012142052.90611-1-robert.mader@collabora.com>", "References": "<20251012142052.90611-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to prepare for the pipeline handler to support higher buffer\ncounts than 4, limit the number of queued requests to this number as\napps otherwise may exhaust the limit of frame contexts (see\nipa::soft::kMaxFrameContexts => 16).\n\nSuggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nTested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c816cffc9..6e8271346 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -417,6 +417,7 @@ protected:\n \tint queueRequestDevice(Camera *camera, Request *request) override;\n \n private:\n+\tstatic constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n \tstatic constexpr unsigned int kNumInternalBuffers = 3;\n \n \tstruct EntityData {\n@@ -1273,7 +1274,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n */\n \n SimplePipelineHandler::SimplePipelineHandler(CameraManager *manager)\n-\t: PipelineHandler(manager), converter_(nullptr)\n+\t: PipelineHandler(manager, kMaxQueuedRequestsDevice),\n+\t converter_(nullptr)\n {\n }\n \n", "prefixes": [ "v5", "1/3" ] }