Patch Detail
Show a patch.
GET /api/patches/24595/?format=api
{ "id": 24595, "url": "https://patchwork.libcamera.org/api/patches/24595/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24595/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251011160335.50578-8-kieran.bingham@ideasonboard.com>", "date": "2025-10-11T16:03:35", "name": "[RFC,7/7] ipa: softipa: Confine black level configuration", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f8454e9e00b1693976842b2f4d20e128f914f8a0", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24595/mbox/", "series": [ { "id": 5486, "url": "https://patchwork.libcamera.org/api/series/5486/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5486", "date": "2025-10-11T16:03:28", "name": "Preparatory cleanup for libipa rework.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5486/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24595/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24595/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72F5EC3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 11 Oct 2025 16:03:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A5DC6045D;\n\tSat, 11 Oct 2025 18:03:50 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FC6960444\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 Oct 2025 18:03:44 +0200 (CEST)", "from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD89D1440;\n\tSat, 11 Oct 2025 18:02:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cW03qz9Y\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760198527;\n\tbh=nxf7Xf9wsexXXjyeHfSxMTXDkiecYW9cv9lUMG4B/t4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cW03qz9YR7xG+OiCLVJgwA49u2TGKvW3tPIA3/2V8erzI3qQcHm+Livg9bqdyGKWX\n\tcQgt4fHQo1ulZrv286x1Ft/IfryGjrSnTX5sombKMOaPY5TuTuD87vkgCSsJ65jBNI\n\tPxlmCLjoxxvQKWGIumuJqFhwgKdDi1dXdApgUHlo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[RFC PATCH 7/7] ipa: softipa: Confine black level configuration", "Date": "Sat, 11 Oct 2025 17:03:35 +0100", "Message-ID": "<20251011160335.50578-8-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251011160335.50578-1-kieran.bingham@ideasonboard.com>", "References": "<20251011160335.50578-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the black level handling entirely into the blc module.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/simple/algorithms/blc.cpp | 11 +++++++++++\n src/ipa/simple/soft_simple.cpp | 10 ----------\n 2 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex 370385afc683..060006d350ee 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -40,10 +40,21 @@ int BlackLevel::init([[maybe_unused]] IPAContext &context,\n int BlackLevel::configure(IPAContext &context,\n \t\t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n {\n+\t/*\n+\t * The black level from camHelper_ is a 16 bit value, software ISP\n+\t * works with 8 bit pixel values, both regardless of the actual\n+\t * sensor pixel width. Hence we obtain the pixel-based black value\n+\t * by dividing the value from the helper by 256.\n+\t */\n+\tcontext.configuration.black.level =\n+\t\tcontext.camHelper->blackLevel().value() / 256;\n+\n \tif (definedLevel_.has_value())\n \t\tcontext.configuration.black.level = definedLevel_;\n+\n \tcontext.activeState.blc.level =\n \t\tcontext.configuration.black.level.value_or(16);\n+\n \treturn 0;\n }\n \ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 68ddf71e9f24..caae2c586e9b 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -227,16 +227,6 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo,\n \t\t\t(context_.configuration.agc.againMax -\n \t\t\t context_.configuration.agc.againMin) /\n \t\t\t100.0;\n-\t\tif (context_.camHelper->blackLevel().has_value()) {\n-\t\t\t/*\n-\t\t\t * The black level from camHelper_ is a 16 bit value, software ISP\n-\t\t\t * works with 8 bit pixel values, both regardless of the actual\n-\t\t\t * sensor pixel width. Hence we obtain the pixel-based black value\n-\t\t\t * by dividing the value from the helper by 256.\n-\t\t\t */\n-\t\t\tcontext_.configuration.black.level =\n-\t\t\t\tcontext_.camHelper->blackLevel().value() / 256;\n-\t\t}\n \t} else {\n \t\t/*\n \t\t * The camera sensor gain (g) is usually not equal to the value written\n", "prefixes": [ "RFC", "7/7" ] }