Patch Detail
Show a patch.
GET /api/patches/24577/?format=api
{ "id": 24577, "url": "https://patchwork.libcamera.org/api/patches/24577/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24577/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251010092226.41228-3-robert.mader@collabora.com>", "date": "2025-10-10T09:22:26", "name": "[v4,3/3] pipeline: simple: Initialize maxQueuedRequestsDevice to 4", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c07f3b8f9be458a87b3052e78e819c236e6c3055", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24577/mbox/", "series": [ { "id": 5482, "url": "https://patchwork.libcamera.org/api/series/5482/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5482", "date": "2025-10-10T09:22:24", "name": "[v4,1/3] pipeline: simple: Allow buffer counts from 1 to 32", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5482/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24577/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24577/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F47DC3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Oct 2025 09:23:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DE426B599;\n\tFri, 10 Oct 2025 11:23:11 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8BC8613AB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Oct 2025 11:23:09 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1760088185982806.8245937455339;\n\tFri, 10 Oct 2025 02:23:05 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"XcUMeiVd\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1760088187; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=UyAvrZR7tY6ln19yW15dCqjJyT4SmSfuHLnFii/70fQZkyJQYjAZm2wp3vA8OCSMzsOXeOzSAAAhdXRBN0eHlyvwFk7WDuTvYhHkXDwSHAYyC8LiWb4rUL7wMEafrysiltGH4GK591HaQ8eRnGCzXezbBIvHfErq2v+A2J+HcMY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760088187;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=8lcTgiz/DVIok3LYZLg2U1P8XsmQ7i4ZElFOGyyw9C0=; \n\tb=cnHvESd0zZ5tBV4DWPy5d15ZL8s9bvI5bavs0od+nq2GuujXDJ5xthwnmcuvRZy2lHn8vHHEWPjT82YH7BmHf3AJDmkhqNth+8rVWCXQe7CmOIJWe/FFQuJBCLVfDJxzE1eCf/DrZ7oi6LAWDJGfws25cgiVnn6m+fLvtjuH83s=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760088187;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=8lcTgiz/DVIok3LYZLg2U1P8XsmQ7i4ZElFOGyyw9C0=;\n\tb=XcUMeiVdNIcmB6Ieh7QVMR3arEM1bp4Oc1CesfQwHPprx4ylT6fcNOFgXti3fJbz\n\t3BfBJYoPmPxxVKhHqASpw2zEeS3uw/x4qQ0QgEtpIJKA3lodOaoHYjauZoLd4tdA1jA\n\tPlBPA/PSXCoK4gr05Fbhy05vCdYDNnKdDf7VD9uI=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v4 3/3] pipeline: simple: Initialize maxQueuedRequestsDevice\n\tto 4", "Date": "Fri, 10 Oct 2025 11:22:26 +0200", "Message-ID": "<20251010092226.41228-3-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251010092226.41228-1-robert.mader@collabora.com>", "References": "<20251010092226.41228-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the pipeline handler supports high buffer counts, apps may\nqueue more requests, exhausting e.g. frame contexts (see\nipa::soft::kMaxFrameContexts => 16).\n\nThus limit the number of queued requests to 4, corresponding to the\nthe previous buffer limit.\n\nSuggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c4cb7c391..dec9f6514 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -420,6 +420,7 @@ protected:\n \tint queueRequestDevice(Camera *camera, Request *request) override;\n \n private:\n+\tstatic constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n \tstatic constexpr unsigned int kNumInternalBuffers = 4;\n \n \tstruct EntityData {\n@@ -1287,7 +1288,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n */\n \n SimplePipelineHandler::SimplePipelineHandler(CameraManager *manager)\n-\t: PipelineHandler(manager), converter_(nullptr)\n+\t: PipelineHandler(manager, kMaxQueuedRequestsDevice),\n+\t converter_(nullptr)\n {\n }\n \n", "prefixes": [ "v4", "3/3" ] }