Patch Detail
Show a patch.
GET /api/patches/24560/?format=api
{ "id": 24560, "url": "https://patchwork.libcamera.org/api/patches/24560/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24560/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251003121821.659081-4-naush@raspberrypi.com>", "date": "2025-10-03T12:15:54", "name": "[v2,3/4] ipa: rpi: pisp: Add a DecompandAlgorithm class", "commit_ref": "413f03a7384fc675025c258c69bcd26b7ccb159d", "pull_url": null, "state": "accepted", "archived": false, "hash": "9de6ce4f0ec0b3c6a754892863f82dbc103308f9", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24560/mbox/", "series": [ { "id": 5477, "url": "https://patchwork.libcamera.org/api/series/5477/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5477", "date": "2025-10-03T12:15:51", "name": "Raspberry Pi: Decompanding support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5477/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24560/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24560/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB531C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Oct 2025 12:18:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A42F56B614;\n\tFri, 3 Oct 2025 14:18:37 +0200 (CEST)", "from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C847A6B5FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Oct 2025 14:18:32 +0200 (CEST)", "by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-401ce0cae36so85143f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 03 Oct 2025 05:18:32 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4255d8f02a8sm7812529f8f.39.2025.10.03.05.18.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 03 Oct 2025 05:18:31 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"adHMWele\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1759493912; x=1760098712;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=/MXPwOONyQGMGD5pq4Uaj2ICO0nNlOgDyk5ZR9DdQiM=;\n\tb=adHMWelewUBRt+w7tmXO+h03ERAkvGSPOu29LMYOK7FIN2GQcraHs2ssnc+YtYJ0pS\n\tR7kbTnHbi5kPEqr0iGDjnVkMQVgPUvGDPvDfJRy/5Q2RoKSpCWjOPLSzZWlRd/3o2A+k\n\thFyYGt6pYq0OEM5eEW1U3gr6MYwi0TZ5NLs1t+uI8SB+/vR7pYAAzbzno+yDMa+fKJr9\n\tiZ+z7Y7wfyy5C/1uxvxzwHfb2w07ZzF9V3TEQJ74RE7BUvxEFTaEu7C3wX/ZomzujTdq\n\twn+U8KQYOSduTT7rE86qf2S5bvX5PXtyhq1wdqeGsiguRiXJiur5EgavdriNIFSobugF\n\taFZQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1759493912; x=1760098712;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=/MXPwOONyQGMGD5pq4Uaj2ICO0nNlOgDyk5ZR9DdQiM=;\n\tb=NZ4xRL4ydbdYsbd8p4nc0mwkO6VvffPO0fIJNe105weWIJ6yvnc8j4P3QLWbBGU/SN\n\tPQ36j+KzWobdRPW90hi8rV49JWojyeX+2YCzWZgp8MH6GTKNsGwS0tUE5brXVBg0S7RA\n\t6U2fWZaA0NoEb+gHGD92W3iA3WD2+ifmoqhljDdJNC43u7pKnMwVUpEvtl8djFYU4aYz\n\tBIXMKebINEADDrJUiTAV9xhfLWBX+fR9OgBAeGzdU93tENEPH6cQUQnM/uj97Rv0uSfd\n\tts2z2TI8HYkimxu4x1/ctu8i0/Bb0INgo/lJNmN34emHCaht6wEqg4KdPLd2BoI8VRzA\n\tpisg==", "X-Gm-Message-State": "AOJu0YxNM0OF4B6rUKTDiKzQ4SSbh31YU24ptgrv6fKd3kz+FVFKO6Er\n\t+SunHudzBoq2lmwnfAc4JhBu4m1QR6iLmeWBih6tMGtYMLGBKIcd/J2SKwe8AbIovKzWPnyqf89\n\tdYmYm", "X-Gm-Gg": "ASbGncvaFvk3Y4spND0cOGRngfXEcdj0KnSzP8swMe8f94VUbEbZBkleR6kl9WVxtth\n\tWR0uArRtTrwQ+6TwKe4T3MwBaxUwcYATeec3Bk1LvtO7buGZHXEUOGErr2b/8NXxdePEEoZLspA\n\tkkfc2nKvT3cLPre4i+bsX5lwPM+Tet62lmNXdOMaqjsFlz95RQroZDBTObn5p6YDCwRocN/R5Wk\n\t4auir9j6zK3N0LDoq2SjpqUxhAQXNdswAoST6KuwgJUof92eFBM100YbcqUl5BxVsEdYqhZKiwK\n\t2pUJbrzsu4OWqI86UgZadpXAYdmlZBEnRGVXUJITHfxvpGirasAWyu55f8KEI0oaB6vbDTCUuFZ\n\tCAOTe0H9gY+psBdVisNzMGDi7MMzCMFkRgnuIcBjvXk+v2PxjBpQX3/gdabx8gkaRwA==", "X-Google-Smtp-Source": "AGHT+IFxeYXsi9FsnoldHMUOsk6OgHe1YdgXE4ZYQF0N5Zps/YyAT9Bv22th5JAkOpBbzGLWNcWypQ==", "X-Received": "by 2002:a05:6000:1861:b0:3f7:f02b:d7a with SMTP id\n\tffacd0b85a97d-42567171f1bmr859654f8f.5.1759493912013; \n\tFri, 03 Oct 2025 05:18:32 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>,\n\tNick Hollinghurst <nick.hollinghurst@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v2 3/4] ipa: rpi: pisp: Add a DecompandAlgorithm class", "Date": "Fri, 3 Oct 2025 13:15:54 +0100", "Message-ID": "<20251003121821.659081-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251003121821.659081-1-naush@raspberrypi.com>", "References": "<20251003121821.659081-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The decompand algorithm implementation will subclass the\nDecompandAlgorithm class. This will be needed for setting the initial\ndecompand values in a future commit.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nTested-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>\n---\n src/ipa/rpi/controller/decompand_algorithm.h | 24 ++++++++++++++++++++\n src/ipa/rpi/controller/rpi/decompand.cpp | 2 +-\n src/ipa/rpi/controller/rpi/decompand.h | 5 ++--\n 3 files changed, 27 insertions(+), 4 deletions(-)\n create mode 100644 src/ipa/rpi/controller/decompand_algorithm.h", "diff": "diff --git a/src/ipa/rpi/controller/decompand_algorithm.h b/src/ipa/rpi/controller/decompand_algorithm.h\nnew file mode 100644\nindex 000000000000..f19f8c109323\n--- /dev/null\n+++ b/src/ipa/rpi/controller/decompand_algorithm.h\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2025, Raspberry Pi Ltd\n+ *\n+ * Decompand control algorithm interface\n+ */\n+#pragma once\n+\n+#include \"libipa/pwl.h\"\n+\n+#include \"algorithm.h\"\n+\n+namespace RPiController {\n+\n+class DecompandAlgorithm : public Algorithm\n+{\n+public:\n+\tDecompandAlgorithm(Controller *controller = NULL)\n+\t\t: Algorithm(controller)\n+\t{\n+\t}\n+};\n+\n+} /* namespace RPiController */\ndiff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp\nindex 2036750f82f4..5b4c2e5524af 100644\n--- a/src/ipa/rpi/controller/rpi/decompand.cpp\n+++ b/src/ipa/rpi/controller/rpi/decompand.cpp\n@@ -13,7 +13,7 @@ LOG_DEFINE_CATEGORY(RPiDecompand)\n #define NAME \"rpi.decompand\"\n \n Decompand::Decompand(Controller *controller)\n-\t: Algorithm(controller)\n+\t: DecompandAlgorithm(controller)\n {\n }\n \ndiff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h\nindex 38b26a21e6d5..0f2a9b3bbdc4 100644\n--- a/src/ipa/rpi/controller/rpi/decompand.h\n+++ b/src/ipa/rpi/controller/rpi/decompand.h\n@@ -2,10 +2,9 @@\n \n #include <libipa/pwl.h>\n \n+#include \"../decompand_algorithm.h\"\n #include \"../decompand_status.h\"\n \n-#include \"algorithm.h\"\n-\n namespace RPiController {\n \n struct DecompandConfig {\n@@ -13,7 +12,7 @@ struct DecompandConfig {\n \tlibcamera::ipa::Pwl decompandCurve;\n };\n \n-class Decompand : public Algorithm\n+class Decompand : public DecompandAlgorithm\n {\n public:\n \tDecompand(Controller *controller = nullptr);\n", "prefixes": [ "v2", "3/4" ] }