Patch Detail
Show a patch.
GET /api/patches/24551/?format=api
{ "id": 24551, "url": "https://patchwork.libcamera.org/api/patches/24551/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24551/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251002133523.293413-4-naush@raspberrypi.com>", "date": "2025-10-02T13:26:06", "name": "[v1,3/4] ipa: rpi: pisp: Add a DecompandAlgorithm class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d7311a3816b2a905358c400990744606d57affb2", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24551/mbox/", "series": [ { "id": 5474, "url": "https://patchwork.libcamera.org/api/series/5474/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5474", "date": "2025-10-02T13:26:03", "name": "Raspberry Pi: Decompanding support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5474/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24551/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24551/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EB87C3310\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Oct 2025 13:35:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8ACC96B5F9;\n\tThu, 2 Oct 2025 15:35:37 +0200 (CEST)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3148C6B5F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Oct 2025 15:35:32 +0200 (CEST)", "by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-46e310e64f4so1319195e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 02 Oct 2025 06:35:32 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-46e6918bdebsm40396015e9.9.2025.10.02.06.35.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 Oct 2025 06:35:31 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"XZBC5onu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1759412131; x=1760016931;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=i8zkLLTT4paFP9gI8ujDezDawHht0wHhmVNglan8uqo=;\n\tb=XZBC5onuj2f6DaoShFJxZ9hkY1XtwxEec8mrNi8zSjU1M5mZchTsDGtKkTLZ3TpKi4\n\tmDzQ5/7JuaMZkPK8zhSkfUB/Kjin2tHbAB13TPeCuI0EEhgKfkZsqA6u22tV5M/YNWQT\n\tC2RSyZsao0q+yFEVGwh7ptUWR+PF6QhUmrVFtit19u5d+pdA3AyEZQXhzTayX/fGzCwf\n\t313jueEQswCvC93NPgfy5mU7qGg8QkTYmC+ED4RUpZaEZT/Qz3/ejk+/9MNUc7z55rx4\n\tKndCbXESWakSP4ePHSaSSHqNFuYLbhujlv39lM4SADTfRodzx5UFG2Sw3NzpkJeLGugU\n\t1eLg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1759412131; x=1760016931;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=i8zkLLTT4paFP9gI8ujDezDawHht0wHhmVNglan8uqo=;\n\tb=fc1qgH07CDVD9XsrixXW2IH5P1i7brqHCq0tKX2KMEBT+iJHn4ssZbruURIJHf/cI3\n\txNqdK+i4ams2QVPhB+wlY5RMDhTcyJElK1siZXNjMWhrO51HMSnqX9lsV9+0y2btbxMO\n\t7XtGqHV+WyZSUGsp5YRKakBAyRBlOp49Yrv1W4g8BL+bEZb968Ey5mq/tKwNPhZb5XGI\n\tYy7iTZYjl6JitGAnkiRKN7rJACTdj5u1SoQnrT3GrIGAE836R68NP+C3FJn5plvM3Krp\n\tK9cyU5CGmNwgYVKvyoY6+S4ygomgMmuOaRup5455G8Lrua5Xt5gokvGE1G9f6/VxImoQ\n\tleXA==", "X-Gm-Message-State": "AOJu0YzxwHwOyr8/3aR7XvV1LViOftP8CfYTuJdW6GOx7133yCrlrEOK\n\tVXkea+SqxCqW3I3+AG/d+JgpTGla9ZO1ftkaJ0AiEwvJAxmeQ6rLXM/EvNZWks5w4Yryy+GsDXS\n\tr+ool", "X-Gm-Gg": "ASbGncuQPFpJV6YNDkSz7fsDs9Kbhhkf175Teg7hG8npkQ6M2YwJdZuwQGRHhMCrpyn\n\tr4l52tf9Amg3hw/Dh1p1hOLB0ZMU+gC1Urbpvk4mSwo2Io2VeG+Yu6NtIQksnGRRc7ZbQTIFxm5\n\tuUgeoPL7X/VnrDtepytqZ4BjX+WdhQ92z4S1XvdmCTucpISQk9BJe5Xnz/KLwCxu+OLF8eZBkjF\n\tPIg9iYAaK5JXln1GIY6qJcczB8YqRb1QrEhUlbJkMBXZC7u1u8HKquDhjsijLiTEboqsLRgGLoj\n\tKQfvUW5DiLmy3KGIlchm2+AdztoD125EjR8A3/oIlubpmB55kZFlpnFpD+O0z3d9+bOlw53btQ5\n\tsnojvqRgwy1JB2OanTxz/qgFXODfU+OnalSsXBz58iXybs90JTEwcX3cCAl/wcd6C/O6trI8CRo\n\txv", "X-Google-Smtp-Source": "AGHT+IEfkaTkpx3vw745W8zu4nzidFM4Ihg33zZZ4gLntUHsF0WEiQCdrQ/TAtGskmYgJqFN9s9jjw==", "X-Received": "by 2002:a05:600c:4ec6:b0:46e:354d:d1b1 with SMTP id\n\t5b1f17b1804b1-46e612862c8mr30189545e9.3.1759412131508; \n\tThu, 02 Oct 2025 06:35:31 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>,\n\tNick Hollinghurst <nick.hollinghurst@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v1 3/4] ipa: rpi: pisp: Add a DecompandAlgorithm class", "Date": "Thu, 2 Oct 2025 14:26:06 +0100", "Message-ID": "<20251002133523.293413-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251002133523.293413-1-naush@raspberrypi.com>", "References": "<20251002133523.293413-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The decompand algorithm implementation will subclass the\nDecompandAlgorithm class. This will be needed for setting the initial\ndecompand values in a future commit.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/controller/decompand_algorithm.h | 24 ++++++++++++++++++++\n src/ipa/rpi/controller/rpi/decompand.cpp | 2 +-\n src/ipa/rpi/controller/rpi/decompand.h | 5 ++--\n 3 files changed, 27 insertions(+), 4 deletions(-)\n create mode 100644 src/ipa/rpi/controller/decompand_algorithm.h", "diff": "diff --git a/src/ipa/rpi/controller/decompand_algorithm.h b/src/ipa/rpi/controller/decompand_algorithm.h\nnew file mode 100644\nindex 000000000000..f19f8c109323\n--- /dev/null\n+++ b/src/ipa/rpi/controller/decompand_algorithm.h\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2025, Raspberry Pi Ltd\n+ *\n+ * Decompand control algorithm interface\n+ */\n+#pragma once\n+\n+#include \"libipa/pwl.h\"\n+\n+#include \"algorithm.h\"\n+\n+namespace RPiController {\n+\n+class DecompandAlgorithm : public Algorithm\n+{\n+public:\n+\tDecompandAlgorithm(Controller *controller = NULL)\n+\t\t: Algorithm(controller)\n+\t{\n+\t}\n+};\n+\n+} /* namespace RPiController */\ndiff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp\nindex 911b04bc0da0..b450436806e1 100644\n--- a/src/ipa/rpi/controller/rpi/decompand.cpp\n+++ b/src/ipa/rpi/controller/rpi/decompand.cpp\n@@ -13,7 +13,7 @@ LOG_DEFINE_CATEGORY(RPiDecompand)\n #define NAME \"rpi.decompand\"\n \n Decompand::Decompand(Controller *controller)\n-\t: Algorithm(controller)\n+\t: DecompandAlgorithm(controller)\n {\n }\n \ndiff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h\nindex 5ef35946efa5..321a561ab141 100644\n--- a/src/ipa/rpi/controller/rpi/decompand.h\n+++ b/src/ipa/rpi/controller/rpi/decompand.h\n@@ -2,10 +2,9 @@\n \n #include <libipa/pwl.h>\n \n+#include \"../decompand_algorithm.h\"\n #include \"../decompand_status.h\"\n \n-#include \"algorithm.h\"\n-\n namespace RPiController {\n \n struct DecompandConfig {\n@@ -13,7 +12,7 @@ struct DecompandConfig {\n \tlibcamera::ipa::Pwl decompandCurve;\n };\n \n-class Decompand : public Algorithm\n+class Decompand : public DecompandAlgorithm\n {\n public:\n \tDecompand(Controller *controller = NULL);\n", "prefixes": [ "v1", "3/4" ] }