Patch Detail
Show a patch.
GET /api/patches/24542/?format=api
{ "id": 24542, "url": "https://patchwork.libcamera.org/api/patches/24542/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24542/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251001-v4l2-params-v4-1-8f2b4779205e@ideasonboard.com>", "date": "2025-10-01T15:42:30", "name": "[v4,1/5] include: linux: Add v4l2-isp.h", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5878ea8aa36e549bf2d5081127ec29f94353e77d", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24542/mbox/", "series": [ { "id": 5472, "url": "https://patchwork.libcamera.org/api/series/5472/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5472", "date": "2025-10-01T15:42:29", "name": "ipa: libipa: Introduce V4L2Params", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5472/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24542/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24542/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F4E2C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Oct 2025 15:42:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE9516B614;\n\tWed, 1 Oct 2025 17:42:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EEBC6B5AA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Oct 2025 17:42:45 +0200 (CEST)", "from [192.168.1.102] (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C101B4C7;\n\tWed, 1 Oct 2025 17:41:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a6qhkqvU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759333275;\n\tbh=m6UKSto21lH4DyPU8izBwOOwuVC+d0tBZtGMWkTJvDE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=a6qhkqvUZGMpBItdTAOeBW7oFczT3NDMSK2ERS7ZNzpHVhH+lisEHJsNceDZiyOJy\n\tE+EbionFVctvo0ESuuPbmU+AzLa35CWISKP3CGAaaysrj6vmjOl5EU8vnKf+6mQI5I\n\tI6HwzVgra5xbpFvC+xer4isNfKxe1WHxDzLqiCBk=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 01 Oct 2025 17:42:30 +0200", "Subject": "[PATCH v4 1/5] include: linux: Add v4l2-isp.h", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251001-v4l2-params-v4-1-8f2b4779205e@ideasonboard.com>", "References": "<20251001-v4l2-params-v4-0-8f2b4779205e@ideasonboard.com>", "In-Reply-To": "<20251001-v4l2-params-v4-0-8f2b4779205e@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tAntoine Bouyer <antoine.bouyer@nxp.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5197;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=m6UKSto21lH4DyPU8izBwOOwuVC+d0tBZtGMWkTJvDE=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBo3UvyQNIKJkqHidqx9in5nDygJirqobfZhiDKb\n\tW1nZEHUhDCJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaN1L8gAKCRByNAaPFqFW\n\tPJcfD/9d+8tZozpFTBjBOXtQ9wh+XOziqRCUQktWxTpZ+SariGABdLutUl0C3Nl5Wp6dnzmmYjR\n\tYCa45NJGGCVlIO7aQmnH0qnO0CDkA070x13mG9SsNOybz1P3ry1GWUEnCaQDLG2A+BJmCdbLskV\n\txiU1e7yiViqoFh2JIi9QrzgbaSKXCAIYUqzeKmjzCA+aLRLgdkbXZkolMv8E3nTOeRkVhYiNfVD\n\t8zdjo/BjXyCp2zcqxYucKdqSEdUMX6DLaI2IC2s2oVhQv6aXuesx4bzbHnsJgGA/UDSH/XzOkzg\n\tO9317P6gyCAKEG8vCoEEYe4pPW7YlCfAu9CiZ2tHrnB+DdU2k4ruRH9JOmserE1ZYxJV1OTA0LP\n\twqs7FzzY342VGrDCyf76a4fpIzLP/82GAxEowTeIRiVOJjeFcbWHG03dTI+d6SrpT1uZHLzhPpo\n\tjcNBbOUY33St5bF3+7MgK05wSxiimKQD73Q/z1fvw6EAANXWV5ZI81qlOHDTAtMiMw4UPeil4Qd\n\t8iqkqAwpe7ovxcPX0/Gqy4er7erGGsGCZoOP+ilygy1mz2wLfoHSlRs1hR+CHvyPkMNl5awzF1M\n\tbPU59A7GvmlMgk2FUDoaojwqNMZZEUyTu4Nd2WAnoJxb+xq8x0Vps4Gd3DPP5QsmjWgXitayUq8\n\tgIPYB03GAAMNMxA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Import the v4l2-isp.h header from the Linux kernel sources.\n\nThe file has not been merged in mainline Linux yet but is available\nat:\nhttps://lore.kernel.org/all/20250915-extensible-parameters-validation-v5-0-e6db94468af3@ideasonboard.com/\n\nCreate the include/linux/media/ directory so that header files\nexported from the kernel which include this file do not need\nto be adjusted when imported in libcamera.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nTested-By: Antoine Bouyer <antoine.bouyer@nxp.com>\n---\n include/linux/media/v4l2-isp.h | 100 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 100 insertions(+)", "diff": "diff --git a/include/linux/media/v4l2-isp.h b/include/linux/media/v4l2-isp.h\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..fed89b5678585a3565d33cf873d0313dc089524f\n--- /dev/null\n+++ b/include/linux/media/v4l2-isp.h\n@@ -0,0 +1,100 @@\n+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */\n+/*\n+ * Video4Linux2 generic ISP parameters and statistics support\n+ *\n+ * Copyright (C) 2025 Ideas On Board Oy\n+ * Author: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n+ */\n+\n+#ifndef _V4L2_ISP_H_\n+#define _V4L2_ISP_H_\n+\n+#include <linux/stddef.h>\n+#include <linux/types.h>\n+\n+#define V4L2_PARAMS_FL_BLOCK_DISABLE\t(1U << 0)\n+#define V4L2_PARAMS_FL_BLOCK_ENABLE\t(1U << 1)\n+\n+/*\n+ * Reserve the first 8 bits for V4L2_PARAMS_FL_* flag.\n+ *\n+ * Driver-specific flags should be defined as:\n+ * #define PLATFORM_SPECIFIC_FLAG0 ((1U << V4L2_PARAMS_FL_DRIVER_FLAGS(0))\n+ * #define PLATFORM_SPECIFIC_FLAG1 ((1U << V4L2_PARAMS_FL_DRIVER_FLAGS(1))\n+ */\n+#define V4L2_PARAMS_FL_DRIVER_FLAGS(n) ((n) + 8)\n+\n+/**\n+ * struct v4l2_params_block_header - V4L2 extensible parameters block header\n+ *\n+ * This structure represents the common part of all the ISP configuration\n+ * blocks. Each parameters block shall embed an instance of this structure type\n+ * as its first member, followed by the block-specific configuration data. The\n+ * driver inspects this common header to discern the block type and its size and\n+ * properly handle the block content.\n+ *\n+ * The @type field is an ISP driver-specific value that identifies the block\n+ * type. The @size field specifies the size of the parameters block.\n+ *\n+ * The @flags field is a bitmask of per-block flags V4L2_PARAMS_FL_* and\n+ * driver-specific flags specified by the driver header.\n+ *\n+ * @type: The parameters block type (driver-specific)\n+ * @flags: A bitmask of block flags (driver-specific)\n+ * @size: Size (in bytes) of the parameters block, including this header\n+ */\n+struct v4l2_params_block_header {\n+\t__u16 type;\n+\t__u16 flags;\n+\t__u32 size;\n+} __attribute__((aligned(8)));\n+\n+/**\n+ * v4l2_params_buffer_size - Calculate size of v4l2_params_buffer for a platform\n+ *\n+ * Users of the v4l2 extensible parameters will have differing sized data arrays\n+ * depending on their specific parameter buffers. Drivers and userspace will\n+ * need to be able to calculate the appropriate size of the struct to\n+ * accommodate all ISP configuration blocks provided by the platform.\n+ * This macro provides a convenient tool for the calculation.\n+ *\n+ * @max_params_size: The total size of the ISP configuration blocks\n+ */\n+#define v4l2_params_buffer_size(max_params_size) \\\n+\t(offsetof(struct v4l2_params_buffer, data) + (max_params_size))\n+\n+/**\n+ * struct v4l2_params_buffer - V4L2 extensible parameters configuration\n+ *\n+ * This struct contains the configuration parameters of the ISP algorithms,\n+ * serialized by userspace into a data buffer. Each configuration parameter\n+ * block is represented by a block-specific structure which contains a\n+ * :c:type:`v4l2_params_block_header` entry as first member. Userspace populates\n+ * the @data buffer with configuration parameters for the blocks that it intends\n+ * to configure. As a consequence, the data buffer effective size changes\n+ * according to the number of ISP blocks that userspace intends to configure and\n+ * is set by userspace in the @data_size field.\n+ *\n+ * The parameters buffer is versioned by the @version field to allow modifying\n+ * and extending its definition. Userspace shall populate the @version field to\n+ * inform the driver about the version it intends to use. The driver will parse\n+ * and handle the @data buffer according to the data layout specific to the\n+ * indicated version and return an error if the desired version is not\n+ * supported.\n+ *\n+ * For each ISP block that userspace wants to configure, a block-specific\n+ * structure is appended to the @data buffer, one after the other without gaps\n+ * in between nor overlaps. Userspace shall populate the @data_size field with\n+ * the effective size, in bytes, of the @data buffer.\n+ *\n+ * @version: The parameters buffer version (driver-specific)\n+ * @data_size: The configuration data effective size, excluding this header\n+ * @data: The configuration data\n+ */\n+struct v4l2_params_buffer {\n+\t__u32 version;\n+\t__u32 data_size;\n+\t__u8 data[] __counted_by(data_size);\n+};\n+\n+#endif /* _V4L2_ISP_H_ */\n", "prefixes": [ "v4", "1/5" ] }