Patch Detail
Show a patch.
GET /api/patches/24531/?format=api
{ "id": 24531, "url": "https://patchwork.libcamera.org/api/patches/24531/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24531/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250930122726.1837524-33-stefan.klug@ideasonboard.com>", "date": "2025-09-30T12:26:53", "name": "[v1,32/33] libcamera: rkisp1: Implement LensDewarpEnable control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4c16bf9ba7487fe476766eb4cae7c8b70eec8d37", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24531/mbox/", "series": [ { "id": 5468, "url": "https://patchwork.libcamera.org/api/series/5468/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5468", "date": "2025-09-30T12:26:21", "name": "Full dewarper support on imx8mp", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5468/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24531/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24531/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAAF8C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Sep 2025 13:39:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFC656B5F0;\n\tTue, 30 Sep 2025 15:39:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4B0062C35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Sep 2025 15:39:34 +0200 (CEST)", "from ideasonboard.com (unknown [94.31.94.171])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7DBFD16A;\n\tTue, 30 Sep 2025 15:38:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sGLql67Z\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759239486;\n\tbh=HYR0dFKeUd4S6eti4IokHq1N4OQaEVFRHX4DAIOKSxs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sGLql67ZUULZGeD/X8/z0Cbvg+OA0BTIhjm2LG3YeOjnvjXBnhJBW/9WjeQDC22j3\n\t5kbUUPTaEalnYwuCp7jg807flGm3QAw4zMBVeavlImZsCr+ibaL0sK21qi/1QErb6j\n\tWS2YHysi0bBgC2OrtLTxS8hHX4iqZYno1mwGZylo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 32/33] libcamera: rkisp1: Implement LensDewarpEnable\n\tcontrol", "Date": "Tue, 30 Sep 2025 14:26:53 +0200", "Message-ID": "<20250930122726.1837524-33-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250930122726.1837524-1-stefan.klug@ideasonboard.com>", "References": "<20250930122726.1837524-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Implement the LensDewarpEnable control for the rkisp1 pipeline using the\ndw100 converter.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 13d82c9957bc..98521c804d84 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1514,12 +1514,13 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\t\t\t\t\t\t\t maxCrop);\n \t\t}\n \n-\n \t\tif (dewarper_->supportsRequests()) {\n \t\t\tcontrols[&controls::draft::Dw100Scale] = ControlInfo(0.2f, 8.0f, 1.0f);\n \t\t\tcontrols[&controls::draft::Dw100Rotation] = ControlInfo(-180.0f, 180.0f, 0.0f);\n \t\t\tcontrols[&controls::draft::Dw100Offset] = ControlInfo(Point(-10000, -10000), Point(10000, 10000), Point(0, 0));\n \t\t\tcontrols[&controls::draft::Dw100ScaleMode] = ControlInfo(controls::draft::Dw100ScaleModeValues, controls::draft::Fill);\n+\t\t\tif (data->dewarpParams_.has_value())\n+\t\t\t\tcontrols[&controls::LensDewarpEnable] = ControlInfo(false, true, true);\n \t\t} else {\n \t\t\tLOG(RkISP1, Warning)\n \t\t\t\t<< \"dw100 kernel driver has no requests support.\"\n@@ -1873,6 +1874,9 @@ void PipelineHandlerRkISP1::imageBufferReady(FrameBuffer *buffer)\n \tmeta.set(controls::draft::Dw100Rotation, vertexMap.rotation());\n \tmeta.set(controls::draft::Dw100Offset, vertexMap.effectiveOffset());\n \tmeta.set(controls::ScalerCrop, vertexMap.effectiveScalerCrop());\n+\n+\tif (vertexMap.dewarpParamsValid())\n+\t\tmeta.set(controls::LensDewarpEnable, vertexMap.lensDewarpEnable());\n }\n \n void PipelineHandlerRkISP1::dewarpRequestReady(V4L2Request *request)\n", "prefixes": [ "v1", "32/33" ] }