Patch Detail
Show a patch.
GET /api/patches/24499/?format=api
{ "id": 24499, "url": "https://patchwork.libcamera.org/api/patches/24499/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24499/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250930122726.1837524-3-stefan.klug@ideasonboard.com>", "date": "2025-09-30T12:26:23", "name": "[v1,02/33] libcamera: v4l2: Support fromEntityName with shared_ptr<MediaDevice>", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ca12c702ea1625164b98307f9f7f1dfa46d916ab", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24499/mbox/", "series": [ { "id": 5468, "url": "https://patchwork.libcamera.org/api/series/5468/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5468", "date": "2025-09-30T12:26:21", "name": "Full dewarper support on imx8mp", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5468/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24499/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24499/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BB6BC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Sep 2025 12:34:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 527556B5F3;\n\tTue, 30 Sep 2025 14:34:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4679E62C35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Sep 2025 14:34:22 +0200 (CEST)", "from ideasonboard.com (unknown [94.31.94.171])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E158F220;\n\tTue, 30 Sep 2025 14:32:53 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C1R8xuMn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759235574;\n\tbh=il1MPl9gegwLqBk2WXmpryeIZ0Js/Yid7F7UPXStGWk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=C1R8xuMnRuxo6hBbCSIQaHDVb+7VeXpn/adQqxv7aBNcOwl1IhoX639zDdlNxdUVp\n\tkXet4DPLlva3UKz2xBD4j04pTpeMIr2sS2LWMqEkhcoEqIbycqBnHid7qeY1Zg6RBQ\n\tKUA65etvLFsftcgZbyMgr13QWqXq7SRe/v2cu5P4=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v1 02/33] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>", "Date": "Tue, 30 Sep 2025 14:26:23 +0200", "Message-ID": "<20250930122726.1837524-3-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250930122726.1837524-1-stefan.klug@ideasonboard.com>", "References": "<20250930122726.1837524-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nTo facilitate expanding the use of a shared_ptr<MediaDevice> in\npreference of a raw MediaDevice* pointer, add an additional\nimplementation for fromEntityName for both of v4l2_videodevice and\nv4l2_subdevice to support this type.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/v4l2_subdevice.h | 2 ++\n include/libcamera/internal/v4l2_videodevice.h | 2 ++\n src/libcamera/v4l2_subdevice.cpp | 15 +++++++++++++++\n src/libcamera/v4l2_videodevice.cpp | 15 +++++++++++++++\n 4 files changed, 34 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex c1cde1df2e36..d1c8b838d49b 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -163,6 +163,8 @@ public:\n \n \tstatic std::unique_ptr<V4L2Subdevice>\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n+\tstatic std::unique_ptr<V4L2Subdevice>\n+\tfromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n \n protected:\n \tstd::string logPrefix() const override;\ndiff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex 6caafc4dcf08..4f80f7176174 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -228,6 +228,8 @@ public:\n \n \tstatic std::unique_ptr<V4L2VideoDevice>\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n+\tstatic std::unique_ptr<V4L2VideoDevice>\n+\tfromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n \n \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat) const;\n \ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 31a2ac72a7ee..1825e9e55ca4 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -1768,6 +1768,21 @@ V4L2Subdevice::fromEntityName(const MediaDevice *media,\n \treturn std::make_unique<V4L2Subdevice>(mediaEntity);\n }\n \n+/**\n+ * \\brief Create a new video subdevice instance from \\a entity in media device\n+ * \\a media\n+ * \\param[in] media The media device where the entity is registered\n+ * \\param[in] entity The media entity name\n+ *\n+ * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n+ */\n+std::unique_ptr<V4L2Subdevice>\n+V4L2Subdevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n+\t\t\t const std::string &entity)\n+{\n+\treturn fromEntityName(media.get(), entity);\n+}\n+\n std::string V4L2Subdevice::logPrefix() const\n {\n \treturn \"'\" + entity_->name() + \"'\";\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 7b48d911db73..9be5cfbc0395 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -2114,6 +2114,21 @@ V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n \treturn std::make_unique<V4L2VideoDevice>(mediaEntity);\n }\n \n+/**\n+ * \\brief Create a new video device instance from \\a entity in media device\n+ * \\a media\n+ * \\param[in] media The media device where the entity is registered\n+ * \\param[in] entity The media entity name\n+ *\n+ * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n+ */\n+std::unique_ptr<V4L2VideoDevice>\n+V4L2VideoDevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n+\t\t\t\tconst std::string &entity)\n+{\n+\treturn fromEntityName(media.get(), entity);\n+}\n+\n /**\n * \\brief Convert \\a PixelFormat to a V4L2PixelFormat supported by the device\n * \\param[in] pixelFormat The PixelFormat to convert\n", "prefixes": [ "v1", "02/33" ] }