Patch Detail
Show a patch.
GET /api/patches/24490/?format=api
{ "id": 24490, "url": "https://patchwork.libcamera.org/api/patches/24490/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24490/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250929201924.45019-3-mzamazal@redhat.com>", "date": "2025-09-29T20:19:19", "name": "[v5,2/7] libcamera: software_isp: Clarify SwStatsCpu::setWindow use", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a9bdc60f0cde972d2aa58b292d402ef9d067349", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24490/mbox/", "series": [ { "id": 5466, "url": "https://patchwork.libcamera.org/api/series/5466/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5466", "date": "2025-09-29T20:19:17", "name": "Fix stats related problems in software ISP", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5466/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24490/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24490/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF9CEC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Sep 2025 20:19:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B104A6B608;\n\tMon, 29 Sep 2025 22:19:46 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 588886B5AA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Sep 2025 22:19:44 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-613-vNEewdM9M6KhS64Gtq-a3Q-1;\n\tMon, 29 Sep 2025 16:19:40 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id C6A571800447; Mon, 29 Sep 2025 20:19:38 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.35])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id ECA6C19560B4; Mon, 29 Sep 2025 20:19:36 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Lx2ghXNE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1759177183;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ZpM7qgEkfxJ1HoluNj1IKEk3XxxwHeTLA5SiE1Wi6xA=;\n\tb=Lx2ghXNEHWgnAmKxGvz2v6p6zCgbDE2+XWirBHXzl69KAJXu+FPHvt2woniz3Cl3eDHBZp\n\teHfMvkfphQZG7VJNGjPzYj0nI+AexSGG4ISGM1ixs8tHzw3v0BPMj2qmDsm3t0ywnt6NsH\n\t8bkMIjZ92BWh6lIjSXNzIub+TS1aGio=", "X-MC-Unique": "vNEewdM9M6KhS64Gtq-a3Q-1", "X-Mimecast-MFC-AGG-ID": "vNEewdM9M6KhS64Gtq-a3Q_1759177179", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name, hansg@kernel.org", "Subject": "[PATCH v5 2/7] libcamera: software_isp: Clarify\n\tSwStatsCpu::setWindow use", "Date": "Mon, 29 Sep 2025 22:19:19 +0200", "Message-ID": "<20250929201924.45019-3-mzamazal@redhat.com>", "In-Reply-To": "<20250929201924.45019-1-mzamazal@redhat.com>", "References": "<20250929201924.45019-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "vvzT7ZrzIMPSiBGRlNsbZOHmib2QSQRYDADVP8xAeZM_1759177179", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The window coordinates passed to SwStatsCpu::setWindow are confusing.\nLet's clarify what the coordinates should be.\n\nA source of confusion is that the specified window is relative to the\nprocessed area. Debayering adjusts line pointers for its processed area\nand this is what's also passed to stats processing. The window passed\nto SwStatsCpu::setWindow should either specify the size of the whole\nprocessed (not image) area, or its cropping in case the stats shouldn't\nbe gathered over the whole processed area. This patch should clarify\nthis in the code.\n\nReviewed-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>\nReviewed-by: Hans de Goede <hansg@kernel.org>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/software_isp/debayer_cpu.cpp | 6 +++++-\n src/libcamera/software_isp/swstats_cpu.cpp | 24 ++++++++++++++++++++++\n 2 files changed, 29 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 2dc85e5e0..bcaaa5dee 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -554,7 +554,11 @@ int DebayerCpu::configure(const StreamConfiguration &inputCfg,\n \twindow_.width = outputCfg.size.width;\n \twindow_.height = outputCfg.size.height;\n \n-\t/* Don't pass x,y since process() already adjusts src before passing it */\n+\t/*\n+\t * Set the stats window to the whole processed window. Its coordinates are\n+\t * relative to the debayered area since debayering passes only the part of\n+\t * data to be processed to the stats; see SwStatsCpu::setWindow.\n+\t */\n \tstats_->setWindow(Rectangle(window_.size()));\n \n \t/* pad with patternSize.Width on both left and right side */\ndiff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex e8a1d52f2..4031c1a9e 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -416,9 +416,33 @@ int SwStatsCpu::configure(const StreamConfiguration &inputCfg)\n /**\n * \\brief Specify window coordinates over which to gather statistics\n * \\param[in] window The window object.\n+ *\n+ * This method specifies the image area over which to gather the statistics.\n+ * It must be called to set the area, otherwise the default zero-sized\n+ * \\a Rectangle is used and no statistics is gathered.\n+ *\n+ * The specified \\a window is relative to what is passed to the processLine*\n+ * methods. For example, if statistics are to be gathered from the entire\n+ * processed area, then \\a window should be a rectangle with the top-left corner\n+ * of (0,0) and the same size as the processed area. If only a part of the\n+ * processed area (e.g. its centre) is to be considered for statistics, then\n+ * \\a window should specify such a restriction accordingly.\n+ *\n+ * It is the responsibility of the callers to provide sensible \\a window values,\n+ * most notably not exceeding the original image boundaries. This means, among\n+ * other, that neither coordinate of the top-left corner shall be negative.\n+ *\n+ * Due to limitations of the implementation, the method may adjust the window\n+ * slightly if it is not aligned according to the bayer pattern determined in\n+ * \\a SwStatsCpu::configure(). In that case the window will be modified such that\n+ * the sides are no larger than the original, and that the new bottom-left\n+ * corner will be no further from (0,0) (along either axis) than the original\n+ * was.\n */\n void SwStatsCpu::setWindow(const Rectangle &window)\n {\n+\tASSERT(window.x >= 0 && window.y >= 0);\n+\n \twindow_ = window;\n \n \twindow_.x &= ~(patternSize_.width - 1);\n", "prefixes": [ "v5", "2/7" ] }