Patch Detail
Show a patch.
GET /api/patches/24465/?format=api
{ "id": 24465, "url": "https://patchwork.libcamera.org/api/patches/24465/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24465/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250925221708.7471-4-hansg@kernel.org>", "date": "2025-09-25T22:17:05", "name": "[v2,3/6] ipa: software_isp: AGC: Raise exposure or gain not both at the same time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1f3aab39be3c9ed8e010e20f3ea5fe88022d79de", "submitter": { "id": 239, "url": "https://patchwork.libcamera.org/api/people/239/?format=api", "name": "Hans de Goede", "email": "hansg@kernel.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24465/mbox/", "series": [ { "id": 5459, "url": "https://patchwork.libcamera.org/api/series/5459/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5459", "date": "2025-09-25T22:17:02", "name": "ipa: software_isp: AGC: Fox AGC oscillation bug", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5459/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24465/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24465/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B4D8BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Sep 2025 22:17:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE3A66B601;\n\tFri, 26 Sep 2025 00:17:25 +0200 (CEST)", "from sea.source.kernel.org (sea.source.kernel.org\n\t[IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2522E69367\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Sep 2025 00:17:17 +0200 (CEST)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id D96A24057B;\n\tThu, 25 Sep 2025 22:17:15 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id AA2ECC4CEF7;\n\tThu, 25 Sep 2025 22:17:14 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"lhjpssgI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1758838635;\n\tbh=doDwnVpI3Y2qcYJ1FHiqEpl0+kdSx6c6kK2Df8Avxew=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lhjpssgI4D/q9AHqyV7zwPlVUKL4X3nodn1athKhuy+G0z3hnOv/SZw421jeEqpVk\n\trY659GEaXu8Xe/SAHM5hKmyv94sMs3aG9MGRiq8SuWzAGnTb/ZQ0eZcliYDbgCs2II\n\tvbz0LSLzP53BEOWmNXj/o8FYF66c7pZznuvJAb0zPCW5XM+PcKdZdxCuCP8cW/jTAA\n\tnm5v4pfy/0/94OQ1fErYInJrqVg2NhPpeHxuY1MuzeinpjODhkI1FmoybEAFw2grP4\n\tgfWx+JNDDooXooA6GVkUauRDB/uoYoywdU4i48GFMkZaeuhxDcMhErEYHNj3cZz4f1\n\tbSNxI8sE+EUAw==", "From": "Hans de Goede <hansg@kernel.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Hans de Goede <hansg@kernel.org>, Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 3/6] ipa: software_isp: AGC: Raise exposure or gain not\n\tboth at the same time", "Date": "Fri, 26 Sep 2025 00:17:05 +0200", "Message-ID": "<20250925221708.7471-4-hansg@kernel.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20250925221708.7471-1-hansg@kernel.org>", "References": "<20250925221708.7471-1-hansg@kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Raise either exposure or gain; not both at the same time.\n\nBefore this change when the last exposure raise is done, hitting\nexposure-max, gain would be increased at the same time.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nTested-by: Milan Zamazal <mzamazal@redhat.com>\nTested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Hans de Goede <hansg@kernel.org>\n---\n src/ipa/simple/algorithms/agc.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex 1fc8d7f4..f7f73451 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -56,12 +56,13 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n \tdouble &again = frameContext.sensor.gain;\n \n \tif (exposureMSV < kExposureOptimal - kExposureSatisfactory) {\n-\t\tnext = exposure * kExpNumeratorUp / kExpDenominator;\n-\t\tif (next - exposure < 1)\n-\t\t\texposure += 1;\n-\t\telse\n-\t\t\texposure = next;\n-\t\tif (exposure >= context.configuration.agc.exposureMax) {\n+\t\tif (exposure < context.configuration.agc.exposureMax) {\n+\t\t\tnext = exposure * kExpNumeratorUp / kExpDenominator;\n+\t\t\tif (next - exposure < 1)\n+\t\t\t\texposure += 1;\n+\t\t\telse\n+\t\t\t\texposure = next;\n+\t\t} else {\n \t\t\tnext = again * kExpNumeratorUp / kExpDenominator;\n \t\t\tif (next - again < context.configuration.agc.againMinStep)\n \t\t\t\tagain += context.configuration.agc.againMinStep;\n", "prefixes": [ "v2", "3/6" ] }