Patch Detail
Show a patch.
GET /api/patches/24461/?format=api
{ "id": 24461, "url": "https://patchwork.libcamera.org/api/patches/24461/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24461/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250925192856.77881-8-mzamazal@redhat.com>", "date": "2025-09-25T19:28:56", "name": "[v4,7/7] ipa: simple: agc: Prevent division by zero in AGC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a9f874f09af504b37b52144ceb0635a4135d210e", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24461/mbox/", "series": [ { "id": 5458, "url": "https://patchwork.libcamera.org/api/series/5458/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5458", "date": "2025-09-25T19:28:49", "name": "Fix stats related problems in software ISP", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5458/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24461/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24461/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB839BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Sep 2025 19:29:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EB736B60E;\n\tThu, 25 Sep 2025 21:29:32 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F20EB6B614\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Sep 2025 21:29:26 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-543-eFNHN-hPPoS2o9SEGshnEw-1;\n\tThu, 25 Sep 2025 15:29:22 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id A2A811800350; Thu, 25 Sep 2025 19:29:21 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.62])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 9174F19540EB; Thu, 25 Sep 2025 19:29:19 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"CjsEwzVk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1758828566;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=8Ar7rPvF0560/BLcKfYhFP4NTCURP5c0LZstSfMrNDk=;\n\tb=CjsEwzVkp8EvYqe+4Z4qtB/OnLYK4QQXasAGwOeeiDw1F4ciZ90Zf6rxehs/vI48xoVA9/\n\tGAdKghuyR8bEr4io3BZgmHnyO4GrhGL5us9g9guCWTXag2faQhkY2vPYY44iLwc3gz6Lcj\n\tWGbGNKCgSwN2bXNVcsY6iJAS7333aBw=", "X-MC-Unique": "eFNHN-hPPoS2o9SEGshnEw-1", "X-Mimecast-MFC-AGG-ID": "eFNHN-hPPoS2o9SEGshnEw_1758828562", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v4 7/7] ipa: simple: agc: Prevent division by zero in AGC", "Date": "Thu, 25 Sep 2025 21:28:56 +0200", "Message-ID": "<20250925192856.77881-8-mzamazal@redhat.com>", "In-Reply-To": "<20250925192856.77881-1-mzamazal@redhat.com>", "References": "<20250925192856.77881-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "UnSpxnjQ9oUGsPBJBei72wCXmGdHVG2t8FSX4PrLHpo_1758828562", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the histogram size is non-zero but lower than the number of bins,\nyHistValsPerBin is zero and then the AGC processing crashes on division\nby it. Let's check yHistValsPerBin for being zero and stop AGC\nprocessing in such a case. The condition also covers the cases where\nhistogramSize or yHistValsPerBinMod are zero.\n\nTested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/agc.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex c46bb0ebe..e47949ec4 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -124,6 +124,12 @@ void Agc::process(IPAContext &context,\n \tunsigned int denom = 0;\n \tunsigned int num = 0;\n \n+\tif (yHistValsPerBin == 0) {\n+\t\tLOG(IPASoftExposure, Debug)\n+\t\t\t<< \"Not adjusting exposure due to insufficient histogram data\";\n+\t\treturn;\n+\t}\n+\n \tfor (unsigned int i = 0; i < histogramSize; i++) {\n \t\tunsigned int idx = (i - (i / yHistValsPerBinMod)) / yHistValsPerBin;\n \t\texposureBins[idx] += histogram[blackLevelHistIdx + i];\n", "prefixes": [ "v4", "7/7" ] }