Patch Detail
Show a patch.
GET /api/patches/24434/?format=api
{ "id": 24434, "url": "https://patchwork.libcamera.org/api/patches/24434/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24434/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250919173709.220881-6-mzamazal@redhat.com>", "date": "2025-09-19T17:37:08", "name": "[v3,5/6] ipa: simple: blc: Prevent division by zero in BLC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c54121ce6191e7ef51b24f065d0f979cee6e20f5", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24434/mbox/", "series": [ { "id": 5451, "url": "https://patchwork.libcamera.org/api/series/5451/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5451", "date": "2025-09-19T17:37:03", "name": "Fix stats related problems in software ISP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5451/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24434/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24434/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 447D3BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Sep 2025 17:37:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 017A06B5B2;\n\tFri, 19 Sep 2025 19:37:47 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B503B6B5A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Sep 2025 19:37:44 +0200 (CEST)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-222-RodfM-rrMxilSm7KoglnTg-1;\n\tFri, 19 Sep 2025 13:37:39 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id C3ABC19560B2; Fri, 19 Sep 2025 17:37:35 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.9])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 93FC11800451; Fri, 19 Sep 2025 17:37:33 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RjXQ4Yg0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1758303463;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=lmNWTOBg6UB3HS/T/mVXkajSkni9mVLeYsp5zO1MAq8=;\n\tb=RjXQ4Yg0727krumJDg6p4pOXwlWglOFOlYfb0Haf/PC5OWgB9N8x01ppNC/h+zvPK7Vli5\n\tRkWeeyTAtiTfYLoNBjr0XmL7qCx41hoAwEt94EqXiwmeeAi0e0ULGTvYIl/D6gvPKx3cvP\n\tvinxvFu4QGFVrtjyHQBvLfhivyUX6qI=", "X-MC-Unique": "RodfM-rrMxilSm7KoglnTg-1", "X-Mimecast-MFC-AGG-ID": "RodfM-rrMxilSm7KoglnTg_1758303456", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v3 5/6] ipa: simple: blc: Prevent division by zero in BLC", "Date": "Fri, 19 Sep 2025 19:37:08 +0200", "Message-ID": "<20250919173709.220881-6-mzamazal@redhat.com>", "In-Reply-To": "<20250919173709.220881-1-mzamazal@redhat.com>", "References": "<20250919173709.220881-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "pfQT4TJF7w7nCN0C3i1K-qqxjuSKU4tjv2r30MlPIvM_1758303456", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When there are no values in the histogram, BLC simple IPA can crash on\ndivision by zero. We cannot get anything meaningful in such a case\nanyway, let's simply return from `process()' then.\n\nTested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/blc.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex 8c1e9ed08..ea5356443 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -77,6 +77,11 @@ void BlackLevel::process(IPAContext &context,\n \tconstexpr float ignoredPercentage = 0.02;\n \tconst unsigned int total =\n \t\tstd::accumulate(begin(histogram), end(histogram), 0);\n+\tif (total == 0) {\n+\t\tLOG(IPASoftBL, Debug) << \"Not guessing black level, histogram is empty\";\n+\t\treturn;\n+\t}\n+\n \tconst unsigned int pixelThreshold = ignoredPercentage * total;\n \tconst unsigned int histogramRatio = 256 / SwIspStats::kYHistogramSize;\n \tconst unsigned int currentBlackIdx =\n", "prefixes": [ "v3", "5/6" ] }