Patch Detail
Show a patch.
GET /api/patches/24433/?format=api
{ "id": 24433, "url": "https://patchwork.libcamera.org/api/patches/24433/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24433/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250919173709.220881-5-mzamazal@redhat.com>", "date": "2025-09-19T17:37:07", "name": "[v3,4/6] libcamera: simple: Avoid incorrect arithmetic in AWB", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b7029706aa86bbb6b63d5eebaab29c1aebae2638", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24433/mbox/", "series": [ { "id": 5451, "url": "https://patchwork.libcamera.org/api/series/5451/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5451", "date": "2025-09-19T17:37:03", "name": "Fix stats related problems in software ISP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5451/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24433/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24433/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0C7DBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Sep 2025 17:37:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33CBE6B5AA;\n\tFri, 19 Sep 2025 19:37:40 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 327EF6B59C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Sep 2025 19:37:36 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-370-5ukR9rScNAS5tHuLfGzMqw-1;\n\tFri, 19 Sep 2025 13:37:34 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 222FA19560B2; Fri, 19 Sep 2025 17:37:33 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.9])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 8B9FF1800451; Fri, 19 Sep 2025 17:37:31 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OMy7hT1f\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1758303455;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=LyZsWx5DwXfv2ZPUtHNL2o3r3JWEFuo++LnL2EVHaVQ=;\n\tb=OMy7hT1fOWio6FYRxXrci44HKs6XJaVtTyzSePux3pzcpicq7UssK/Tyn4FwuhUIhI46S2\n\tenENzBok0f0H53codC/DQadwJxXmg8DyNznbJiFS1cYKLbmAfIkKXq0iyzL8JUXDoZ1lIa\n\tgSgR3IJ7zTVT4dkFIPbP2oMkJeAnJfY=", "X-MC-Unique": "5ukR9rScNAS5tHuLfGzMqw-1", "X-Mimecast-MFC-AGG-ID": "5ukR9rScNAS5tHuLfGzMqw_1758303453", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name", "Subject": "[PATCH v3 4/6] libcamera: simple: Avoid incorrect arithmetic in AWB", "Date": "Fri, 19 Sep 2025 19:37:07 +0200", "Message-ID": "<20250919173709.220881-5-mzamazal@redhat.com>", "In-Reply-To": "<20250919173709.220881-1-mzamazal@redhat.com>", "References": "<20250919173709.220881-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "SZlnbpFWRDemdq9yL2c5LrMIBuG3vliXMTbReW9a0aA_1758303453", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The R/G/B sums computed in AWB simple IPA may be zero or perhaps even\nnegative. Let's make sure the sums are always positive, to prevent\ndivision by zero or completely nonsense results.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex cf567e894..8231a4968 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -7,6 +7,7 @@\n \n #include \"awb.h\"\n \n+#include <algorithm>\n #include <numeric>\n #include <stdint.h>\n \n@@ -68,10 +69,11 @@ void Awb::process(IPAContext &context,\n \t */\n \tconst uint64_t nPixels = std::accumulate(\n \t\thistogram.begin(), histogram.end(), 0);\n-\tconst uint64_t offset = blackLevel * nPixels;\n-\tconst uint64_t sumR = stats->sumR_ - offset / 4;\n-\tconst uint64_t sumG = stats->sumG_ - offset / 2;\n-\tconst uint64_t sumB = stats->sumB_ - offset / 4;\n+\tconst int64_t offset = blackLevel * nPixels;\n+\tconst int64_t minValid = 1;\n+\tconst uint64_t sumR = std::max(static_cast<int64_t>(stats->sumR_) - offset / 4, minValid);\n+\tconst uint64_t sumG = std::max(static_cast<int64_t>(stats->sumG_) - offset / 2, minValid);\n+\tconst uint64_t sumB = std::max(static_cast<int64_t>(stats->sumB_) - offset / 4, minValid);\n \n \t/*\n \t * Calculate red and blue gains for AWB.\n", "prefixes": [ "v3", "4/6" ] }