Patch Detail
Show a patch.
GET /api/patches/24426/?format=api
{ "id": 24426, "url": "https://patchwork.libcamera.org/api/patches/24426/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24426/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250919094041.183031-18-stefan.klug@ideasonboard.com>", "date": "2025-09-19T09:40:32", "name": "[v5,17/19] rkisp1: agc: Agc add yTarget to frame context", "commit_ref": "026f25f32b1369b16a420b4edd4deb7f42668c5c", "pull_url": null, "state": "accepted", "archived": false, "hash": "fab15431dbf38b2a5be515b500b44462936bec80", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24426/mbox/", "series": [ { "id": 5450, "url": "https://patchwork.libcamera.org/api/series/5450/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5450", "date": "2025-09-19T09:40:15", "name": "Implement WDR algorithm", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5450/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24426/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24426/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93192C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Sep 2025 09:41:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6F836B5F1;\n\tFri, 19 Sep 2025 11:41:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDA0E6B59A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Sep 2025 11:41:43 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4d54:eab8:98ca:163b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AF555842;\n\tFri, 19 Sep 2025 11:40:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R2pG337H\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758274823;\n\tbh=Hf8pcymcjtAho++wmGoIxgQhaksSfOG8IgrUvraKMos=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=R2pG337HyQSLGZflAmzw2gKv+UbQ+WVCD4ArMWoYwOBgu5YSfQImzJKgdG5fxUtkz\n\t8jsOMsE0Nz0WSAHJ81a6FqcF8YQwedqGUhP9fuYwdqmyt8ab7EqI0SumxGpiW7DjTT\n\taT+NFGs2dK/T3e0nrfM6rK+m7CgHRvJauqIOmZCU=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v5 17/19] rkisp1: agc: Agc add yTarget to frame context", "Date": "Fri, 19 Sep 2025 11:40:32 +0200", "Message-ID": "<20250919094041.183031-18-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "References": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The upcoming WDR algorithm needs access to the effective yTarget value\nfor its calculations. Add it to the frame context.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v4:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 5 +++++\n src/ipa/rkisp1/ipa_context.h | 2 ++\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex d1b6bb7196f4..046a1ac9caa2 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -208,6 +208,8 @@ int Agc::configure(IPAContext &context, const IPACameraSensorInfo &configInfo)\n \t\t context.configuration.sensor.minAnalogueGain,\n \t\t context.configuration.sensor.maxAnalogueGain, {});\n \n+\tcontext.activeState.agc.automatic.yTarget = effectiveYTarget();\n+\n \tresetFrameCount();\n \n \treturn 0;\n@@ -375,6 +377,8 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n \t\tframeContext.compress.gain = frameContext.agc.quantizationGain;\n \t}\n \n+\tframeContext.agc.yTarget = context.activeState.agc.automatic.yTarget;\n+\n \tif (frame > 0 && !frameContext.agc.updateMetering)\n \t\treturn;\n \n@@ -627,6 +631,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \tactiveState.agc.automatic.exposure = newExposureTime / lineDuration;\n \tactiveState.agc.automatic.gain = aGain;\n \tactiveState.agc.automatic.quantizationGain = qGain;\n+\tactiveState.agc.automatic.yTarget = effectiveYTarget();\n \t/*\n \t * Expand the target frame duration so that we do not run faster than\n \t * the minimum frame duration when we have short exposures.\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 67427c01ac68..113b90428008 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -83,6 +83,7 @@ struct IPAActiveState {\n \t\t\tuint32_t exposure;\n \t\t\tdouble gain;\n \t\t\tdouble quantizationGain;\n+\t\t\tdouble yTarget;\n \t\t} automatic;\n \n \t\tbool autoExposureEnabled;\n@@ -139,6 +140,7 @@ struct IPAFrameContext : public FrameContext {\n \t\tdouble exposureValue;\n \t\tdouble quantizationGain;\n \t\tuint32_t vblank;\n+\t\tdouble yTarget;\n \t\tbool autoExposureEnabled;\n \t\tbool autoGainEnabled;\n \t\tcontrols::AeConstraintModeEnum constraintMode;\n", "prefixes": [ "v5", "17/19" ] }