Patch Detail
Show a patch.
GET /api/patches/24415/?format=api
{ "id": 24415, "url": "https://patchwork.libcamera.org/api/patches/24415/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24415/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250919094041.183031-7-stefan.klug@ideasonboard.com>", "date": "2025-09-19T09:40:21", "name": "[v5,06/19] libipa: exposure_mode_helper: Remove unnecessary clamp calls", "commit_ref": "3c3b9f1091b09a29d7f03d3d6bdaf6d913f26b8e", "pull_url": null, "state": "accepted", "archived": false, "hash": "36d9730852d9bb7af5ca36f4b2205dc00f2d3d2c", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24415/mbox/", "series": [ { "id": 5450, "url": "https://patchwork.libcamera.org/api/series/5450/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5450", "date": "2025-09-19T09:40:15", "name": "Implement WDR algorithm", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5450/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24415/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24415/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBBD6C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Sep 2025 09:41:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B7AA6B5AA;\n\tFri, 19 Sep 2025 11:41:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 729546B5A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Sep 2025 11:41:11 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4d54:eab8:98ca:163b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 10BD8842;\n\tFri, 19 Sep 2025 11:39:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hdma1xc5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758274791;\n\tbh=wuVocP0PxGUEMxd0Ahj37h1AcvbUWZUDWSbY5rD3MIA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hdma1xc575D0jBjuGHw712k7NuyYm/K6JsneWFuPyN+PDSNnWvTsovRcElaouQdI0\n\tznynJm8prYhFb9s7tl2dpturAjNYvbevEGB4LUSUuFdMVc57zeXkNxhJDX9hB9fASN\n\tnhz3r1e6fH6dHl2feX9EgZirQtGR9p1e1/x28vhU=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tIsaac Scott <isaac.scott@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v5 06/19] libipa: exposure_mode_helper: Remove unnecessary\n\tclamp calls", "Date": "Fri, 19 Sep 2025 11:40:21 +0200", "Message-ID": "<20250919094041.183031-7-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "References": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Except for the first iteration of the loop and in the case of an empty\ngains_ vector, the values were run through clamp two times which is\nunnecessary. Remove that by clamping the initial value.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v4:\n- Collected tag\n\nChanges in v3:\n- Collected tags\n---\n src/ipa/libipa/exposure_mode_helper.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\nindex e806731047cf..f2de1d8e4229 100644\n--- a/src/ipa/libipa/exposure_mode_helper.cpp\n+++ b/src/ipa/libipa/exposure_mode_helper.cpp\n@@ -197,8 +197,8 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \t\treturn { minExposureTime_, minGain_, exposure / (minExposureTime_ * minGain_) };\n \n \tutils::Duration exposureTime;\n-\tdouble stageGain = 1.0;\n-\tdouble lastStageGain = 1.0;\n+\tdouble stageGain = clampGain(1.0);\n+\tdouble lastStageGain = stageGain;\n \tdouble gain;\n \n \tfor (unsigned int stage = 0; stage < gains_.size(); stage++) {\n@@ -215,7 +215,7 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \t\t/* Clamp the gain to lastStageGain and regulate exposureTime. */\n \t\tif (stageExposureTime * lastStageGain >= exposure) {\n-\t\t\texposureTime = clampExposureTime(exposure / clampGain(lastStageGain));\n+\t\t\texposureTime = clampExposureTime(exposure / lastStageGain);\n \t\t\tgain = clampGain(exposure / exposureTime);\n \n \t\t\treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n@@ -223,7 +223,7 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \t\t/* Clamp the exposureTime to stageExposureTime and regulate gain. */\n \t\tif (stageExposureTime * stageGain >= exposure) {\n-\t\t\texposureTime = clampExposureTime(stageExposureTime);\n+\t\t\texposureTime = stageExposureTime;\n \t\t\tgain = clampGain(exposure / exposureTime);\n \n \t\t\treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n@@ -239,7 +239,7 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \t * stages to use then the default stageGain of 1.0 is used so that\n \t * exposure time is maxed before gain is touched at all.\n \t */\n-\texposureTime = clampExposureTime(exposure / clampGain(stageGain));\n+\texposureTime = clampExposureTime(exposure / stageGain);\n \tgain = clampGain(exposure / exposureTime);\n \n \treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n", "prefixes": [ "v5", "06/19" ] }