Patch Detail
Show a patch.
GET /api/patches/24396/?format=api
{ "id": 24396, "url": "https://patchwork.libcamera.org/api/patches/24396/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24396/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250918144333.108695-8-stefan.klug@ideasonboard.com>", "date": "2025-09-18T14:43:16", "name": "[v4,07/19] libipa: agc_mean_luminance: Fix constraint logging", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7f700187c4a28fe4afa47a0e42b1f70dbadf9d7a", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24396/mbox/", "series": [ { "id": 5449, "url": "https://patchwork.libcamera.org/api/series/5449/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5449", "date": "2025-09-18T14:43:09", "name": "Implement WDR algorithm", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5449/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24396/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24396/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C23CCC328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Sep 2025 14:44:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4E7669381;\n\tThu, 18 Sep 2025 16:44:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CC0F6937B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Sep 2025 16:44:06 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ace3:d2c2:5eff:9cc5])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AA58B55A;\n\tThu, 18 Sep 2025 16:42:46 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L3ZHzf5A\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758206566;\n\tbh=GT3SNiwf5b0a23Lu4SX6u1wUMPaGCvMLW+NqlVuAkrw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=L3ZHzf5Af3Ig/N1EhiHWv7SRyU3O4jbnfvxThc1jQtwQ0K3KuoqCdIm5vWE62mFcQ\n\t7n5nTADLKeK3hHWnDh9G35NPak90BCP3TpuoZkmxa1TrcMnkfPTzrD3gHA7EvwyIzW\n\txIcbL6bMJa31ck/hOA4k0u5sqU6Y39q3V+vKFRDM=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v4 07/19] libipa: agc_mean_luminance: Fix constraint logging", "Date": "Thu, 18 Sep 2025 16:43:16 +0200", "Message-ID": "<20250918144333.108695-8-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250918144333.108695-1-stefan.klug@ideasonboard.com>", "References": "<20250918144333.108695-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The debug log statements in constraintClampGain() are after the\nassignment of gain. So they correctly log when the constraint applies,\nbut the gain values logged are the same. Fix that.\n\nFixes: 42e18c96bcb7 (\"libipa: agc_mean_luminance: Add debug logging\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v4:\n- Collected tags\n\nChanges in v3:\n- Added this patch\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex ff96a381ffce..fce1a5064870 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -488,18 +488,18 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Lower &&\n \t\t newGain > gain) {\n-\t\t\tgain = newGain;\n \t\t\tLOG(AgcMeanLuminance, Debug)\n \t\t\t\t<< \"Apply lower bound: \" << gain << \" to \"\n \t\t\t\t<< newGain;\n+\t\t\tgain = newGain;\n \t\t}\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Upper &&\n \t\t newGain < gain) {\n-\t\t\tgain = newGain;\n \t\t\tLOG(AgcMeanLuminance, Debug)\n \t\t\t\t<< \"Apply upper bound: \" << gain << \" to \"\n \t\t\t\t<< newGain;\n+\t\t\tgain = newGain;\n \t\t}\n \t}\n \n", "prefixes": [ "v4", "07/19" ] }