Patch Detail
Show a patch.
GET /api/patches/24277/?format=api
{ "id": 24277, "url": "https://patchwork.libcamera.org/api/patches/24277/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24277/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250901111952.2155555-1-naush@raspberrypi.com>", "date": "2025-09-01T11:19:41", "name": "libcamera: clock_recovery: Fix for nanosecond conversion for FrameWallClock", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "44ac353f513d030730248edf7003ef84853102b5", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24277/mbox/", "series": [ { "id": 5419, "url": "https://patchwork.libcamera.org/api/series/5419/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5419", "date": "2025-09-01T11:19:41", "name": "libcamera: clock_recovery: Fix for nanosecond conversion for FrameWallClock", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5419/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24277/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24277/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 313EBBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Sep 2025 11:20:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 037B569325;\n\tMon, 1 Sep 2025 13:20:18 +0200 (CEST)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96B3669318\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Sep 2025 13:20:05 +0200 (CEST)", "by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-45b76f3b24eso4616675e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 01 Sep 2025 04:20:05 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3cf3458a67esm14982519f8f.62.2025.09.01.04.20.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Sep 2025 04:20:03 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"WKuctMk5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1756725604; x=1757330404;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=zZLTI8Uz6nppH+jsJ31I8VP7tIAsMxi5bsHht8JjEIo=;\n\tb=WKuctMk57ykIoiFzu9VeSzcUSOOjFMj84b63vUvJFqyDMJc27JO3f0V/6L5nP5Zg8D\n\t3WoNw+DGpsegfAo/UDz+91yp0Sb8kQUndZJhfzWiyxOMye4U4ljFTgVW39oYk32cxAq6\n\t/3tqCJuxd9Z7jPwcQQkhoo3hblimW4lN9W0vdcCUnhZKo6/Q+TE48S7Qtt5lmTxAuV5V\n\txT5gt1zr3j8sLgox2QO48uWWF1FXjH0yDEzUqMU8AuYTuqVQIrM0UGt+Q0Dq81MxkSC1\n\ttOFFIOmN9+zoFGJhxHeG/p82ApF1rqJJLT0HMi39+sOx9D5oDw6W8WOZOrBTR8HPklOV\n\trKzw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756725604; x=1757330404;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=zZLTI8Uz6nppH+jsJ31I8VP7tIAsMxi5bsHht8JjEIo=;\n\tb=YvTgRxQcBa/LP/KBW2J5aMG2qJLJDB+3gArtjTIwQ1zJmm1e4xfGe3XQNECpZXS7DO\n\t+uY3uLFYUwmSdyKZ87bjqkVqoL5hBI9Ds4qVZr1oeqpp06PEC3A9aF4p1eno2DvXseC7\n\tdYwkTyw5s6QQZUsyCGFgaRgLYrliOxmShEaAezUJ3VQqcaX/HrDwI8wW7Zek5aNtXnus\n\tyvkCJA+0SuOssr7Y8i3Urvg6u+o1A0DwLTJwb2rXbj8tPFV7op18l7HcUqDmMlalGLgy\n\tSkxmqHT8A3XG+V4pIgTx1jytDcPhSdluhHB7Bl6py44+lsEDeblOUmbveoaivoxyVqoo\n\tLimw==", "X-Gm-Message-State": "AOJu0YyBPUkkt8eC7OBvMR95dxEOVLQnsH0jxy4C1xdQ60bh0kG6HIsS\n\t6VLJx0GOy+Jiq9S0nvR5pghQcw7ifEKcOkhku9mbxg+NHZnwCJXcGDrDHp1/L85IjFcaiyL7Wtm\n\tYvncz", "X-Gm-Gg": "ASbGncuKzcAiiKTcpmis58Ze2ZMW7SbT2JqRWcaOiIHv/yaKDCOeWSPg/Ql5QkPuGsM\n\tPAlFCW1ogOW2chlhWlmu/4smok21Jq9sJCm6hojT7BOgeCRsEGa1Ecvnpj0gJTH91AuFkwBLe0I\n\tE/UEeUHzasnxRM1zOZV6M8Wbg/Kin7u1OUkeJX6kEpqJFAQ0TUiPBSjc/VHVpnWV3cftqyMleOI\n\tRh0X9xPaegaX3GWIl3P0mXhgqaARIr6JiYeHaHWu6tMSOoqvgT+eGb+j81/XJXYnGovMkK7MsXL\n\tgHpvgV2ZiRPdampXn83elHSZIGVX3VRX+mCQsUzruyMXIKt1UQtiJvGzkSZiE1q1mL4ov1RPEKR\n\tdur+btrjSz57VOxoPrPaleV9WkEtUBZpEsAkv1BfZ8A==", "X-Google-Smtp-Source": "AGHT+IG1E55FIlADQNQ03XLt8jfofn68Zm/cF0YvpqqOd/ob0AMckVBI98rBx3FiAh1ysLIE9trz8g==", "X-Received": "by 2002:a05:6000:4304:b0:3cd:edee:c7e9 with SMTP id\n\tffacd0b85a97d-3d0fc0b0e9emr3921926f8f.6.1756725604165; \n\tMon, 01 Sep 2025 04:20:04 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "david.plowman@raspberrypi.com, kieran.bingham@ideasonboard.com,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH] libcamera: clock_recovery: Fix for nanosecond conversion for\n\tFrameWallClock", "Date": "Mon, 1 Sep 2025 12:19:41 +0100", "Message-ID": "<20250901111952.2155555-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When switching the FrameWallClock to use nanoseconds instead of\nmicroseconds, the clock recovery class was left untouched. This would\ncause an inaccurate clock model and return spurious results for\nkernel -> wallclock timestamping.\n\nAnnoyingly this was missed as there were no application level consumers\nof FrameWallClock until now.\n\nFixes: 29a88d85b730 (\"libcamera: controls: Use nanoseconds units for FrameWallClock\")\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/clock_recovery.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/clock_recovery.cpp b/src/libcamera/clock_recovery.cpp\nindex abacf444fbf8..f9ccb6ae2144 100644\n--- a/src/libcamera/clock_recovery.cpp\n+++ b/src/libcamera/clock_recovery.cpp\n@@ -118,10 +118,10 @@ void ClockRecovery::addSample()\n \tclock_gettime(CLOCK_BOOTTIME, &bootTime1);\n \tclock_gettime(CLOCK_REALTIME, &wallTime);\n \tclock_gettime(CLOCK_BOOTTIME, &bootTime2);\n-\tuint64_t boot1 = bootTime1.tv_sec * 1000000ULL + bootTime1.tv_nsec / 1000;\n-\tuint64_t boot2 = bootTime2.tv_sec * 1000000ULL + bootTime2.tv_nsec / 1000;\n+\tuint64_t boot1 = bootTime1.tv_sec * 1000000000ULL + bootTime1.tv_nsec;\n+\tuint64_t boot2 = bootTime2.tv_sec * 1000000000ULL + bootTime2.tv_nsec;\n \tuint64_t boot = (boot1 + boot2) / 2;\n-\tuint64_t wall = wallTime.tv_sec * 1000000ULL + wallTime.tv_nsec / 1000;\n+\tuint64_t wall = wallTime.tv_sec * 1000000000ULL + wallTime.tv_nsec;\n \n \taddSample(boot, wall);\n }\n", "prefixes": [] }