Patch Detail
Show a patch.
GET /api/patches/24244/?format=api
{ "id": 24244, "url": "https://patchwork.libcamera.org/api/patches/24244/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24244/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250827090739.86955-7-david.plowman@raspberrypi.com>", "date": "2025-08-27T09:07:33", "name": "[RFC,06/12] ipa: rpi: cam_helper: Add CamHelperDefault class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "95fa3a148a6882ca12637bbe37e230942d67866e", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24244/mbox/", "series": [ { "id": 5407, "url": "https://patchwork.libcamera.org/api/series/5407/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5407", "date": "2025-08-27T09:07:27", "name": "Bayer Re-Processing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5407/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24244/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24244/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCF20C32BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Aug 2025 09:08:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6CBA692F9;\n\tWed, 27 Aug 2025 11:08:02 +0200 (CEST)", "from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FBC5692FA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Aug 2025 11:07:49 +0200 (CEST)", "by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-45a1b0c82eeso56313375e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Aug 2025 02:07:49 -0700 (PDT)", "from raspberrypi.pitowers.org\n\t([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b6f30fe02sm21498675e9.18.2025.08.27.02.07.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 27 Aug 2025 02:07:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qATNoWiE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1756285668; x=1756890468;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=T42Vu1sKWJ+klwmelqzNqd2d2nbWbW0AIllMHaePkcM=;\n\tb=qATNoWiEz6/N6tdJU8xrM+AZXR9frbhXm6SBd89rwPCEqyIuM0HU2bZK9dKuHa+fa8\n\tvTM5iVStVu14NtZ22ERaYcgFJXhZirH+pdKNnKgeOCmPIpJIs5N8jiJSL2xO/92SVt1y\n\toQkR7AHq2WVJ6dEGjZMGr2ebGCMVvl64icsVZtBgBM8rgdHhlI8ZsMdbSW1DaoEhQ21P\n\tZ7vLPZ0m+dV0XK5+YMY7kHtYmdW+M8pDQMV5BpcbhQiLFgTqjobDtSjarxH6VcIzBXrH\n\tvVn/tM+sA7v2dfTUUPuIxmkwoavk5lUBlCRsNXoj+u+k0hVVtMBqoL3+uIZN/9ld9a+d\n\tPm1g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756285668; x=1756890468;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=T42Vu1sKWJ+klwmelqzNqd2d2nbWbW0AIllMHaePkcM=;\n\tb=rtcf49YFsiwpFI/85nPDrp7hCLtd0UB9GX2/5x+tUx1G4y5hhHrSrc6XriCcKCWDur\n\tEkJkHkDjz0C78UYYyqWyqPDWrMn88gjzQH0vManbxL54BLvP42D6S/amv5GgoCUFcy43\n\tM5x8NUmdAOIXnoN8sisNjXVMZZY5mUG622pJ34e0h1jzt9YtjYH2MrhilkVLERgL9vIc\n\tKoCY/8FNp6VBC1XKUdv0ftIuhHZODhpAzdVfHXhBGsYYb0c1Djz7U1J9+/WgV/p3VD1T\n\tfSXfPUtkN5ORRVe5ElwFzAFSZ1/TFqJlemVBPPOQFETRlo1nsFwEp5CSM6H64o5CD820\n\tes2w==", "X-Gm-Message-State": "AOJu0Yxkm/eGHCMPxd/iOLLXqAOxwu0kIwIaRh6MIfKNgZ+scDWN92fH\n\tBesk98ClZUAxTcMKk6svz7eTgkGH961rUNRxyO5YKM+o6wBMZi+aEjgQB/sl34STcPlyM/SOdML\n\t852KW", "X-Gm-Gg": "ASbGncu+rvF3Pz3bKXMENNpcI6ZxXQZtuCVJ4EnnY/6+KSjcQ+g5BZcPNq3i7iOoIFQ\n\t6lhicZBZZg4m2IorcGxYRTi5sK1wEaExicN2cSwOmsPBmXwmrkNdJSAMoXI6FdVLyy8vq62cIwe\n\toa5GJEmnO/lwN1L7ht8B2eKjyzmdEsKvjyKMhr2WQBVhIffmOsSYQ/EA4tGvvG5kiiawujxmbq8\n\td9PGpW389mwWg7hcFB9Qs/mZQFnedlmfHAmbM4ItnygIgszZbfiWxXCORNdE9622jXC6uNUC4jh\n\tMVD4x8Yor2F6i3SGhUl81e60+aP5SAftuqf9Hv2f5ic/0MD/NVqmB/5un3W0x5/BBTD3alxw41q\n\tmlY78NZsDPzALQNfCz9lJIVRWGrXYEf1kQj+T6lvkfm8W0tWn2srmZQaIWhCouGDy84/WPg7US8\n\tlWX1vCuBk3g7/fgrZ4QZu0xHdbpaJOf3om5YwnVIY=", "X-Google-Smtp-Source": "AGHT+IFVeAbZPY13Bbs3QXAlqrAwgB+1pWvQwSdNED+RoIYRL63nPnVv/tIE37cp2Ujg1hFLbIUVqQ==", "X-Received": "by 2002:a05:600c:4853:b0:458:bb0e:8cda with SMTP id\n\t5b1f17b1804b1-45b5974de01mr97933265e9.17.1756285667591; \n\tWed, 27 Aug 2025 02:07:47 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[RFC PATCH 06/12] ipa: rpi: cam_helper: Add CamHelperDefault class", "Date": "Wed, 27 Aug 2025 10:07:33 +0100", "Message-Id": "<20250827090739.86955-7-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.39.5", "In-Reply-To": "<20250827090739.86955-1-david.plowman@raspberrypi.com>", "References": "<20250827090739.86955-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This will help make \"memory cameras\" work where there is no real\nsensor.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/rpi/cam_helper/cam_helper_default.cpp | 45 +++++++++++++++++++\n src/ipa/rpi/cam_helper/meson.build | 1 +\n 2 files changed, 46 insertions(+)\n create mode 100644 src/ipa/rpi/cam_helper/cam_helper_default.cpp", "diff": "diff --git a/src/ipa/rpi/cam_helper/cam_helper_default.cpp b/src/ipa/rpi/cam_helper/cam_helper_default.cpp\nnew file mode 100644\nindex 00000000..99801cc3\n--- /dev/null\n+++ b/src/ipa/rpi/cam_helper/cam_helper_default.cpp\n@@ -0,0 +1,45 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2025, Raspberry Pi Ltd\n+ *\n+ * default camera helper for unknown sensors\n+ */\n+\n+#include <assert.h>\n+#include <stddef.h>\n+#include <stdio.h>\n+#include <stdlib.h>\n+\n+#include \"cam_helper.h\"\n+\n+using namespace RPiController;\n+\n+class CamHelperDefault : public CamHelper\n+{\n+public:\n+\tCamHelperDefault();\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+};\n+\n+CamHelperDefault::CamHelperDefault()\n+\t: CamHelper({}, 0)\n+{\n+}\n+\n+uint32_t CamHelperDefault::gainCode([[maybe_unused]] double gain) const\n+{\n+\treturn 0;\n+}\n+\n+double CamHelperDefault::gain([[maybe_unused]] uint32_t gainCode) const\n+{\n+\treturn 1.0;\n+}\n+\n+static CamHelper *create()\n+{\n+\treturn new CamHelperDefault();\n+}\n+\n+static RegisterCamHelper reg(\"default\", &create);\ndiff --git a/src/ipa/rpi/cam_helper/meson.build b/src/ipa/rpi/cam_helper/meson.build\nindex 7433cffd..6f4c86e7 100644\n--- a/src/ipa/rpi/cam_helper/meson.build\n+++ b/src/ipa/rpi/cam_helper/meson.build\n@@ -2,6 +2,7 @@\n \n rpi_ipa_cam_helper_sources = files([\n 'cam_helper.cpp',\n+ 'cam_helper_default.cpp',\n 'cam_helper_ov5647.cpp',\n 'cam_helper_imx219.cpp',\n 'cam_helper_imx283.cpp',\n", "prefixes": [ "RFC", "06/12" ] }