Patch Detail
Show a patch.
GET /api/patches/24216/?format=api
{ "id": 24216, "url": "https://patchwork.libcamera.org/api/patches/24216/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24216/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-32-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:44", "name": "[v2,32/37] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c2b0388f24b2d1f17f8c3ee9c8d91441a4acc897", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24216/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24216/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24216/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81AFBC32BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D15F6933E;\n\tSun, 24 Aug 2025 02:49:44 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C371869322\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:49:05 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-45a1b05a49cso25529425e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:49:05 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.49.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:49:04 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"BYMnFYl3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996545; x=1756601345;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=ESRMJTblPPvZq2GFxDEIxtOdNxshCNwucJs6WtvfNbE=;\n\tb=BYMnFYl355tbMsxuWcC+Rk1iPWAeD/hqAalu3PvYdv3b6rCOiNx/tkuFztVuMv1o1J\n\tvk8HX/ZBtP4gPxiKF6YYHdjtg78h51mHDs90vCIgUvoJlBvDCh9mHTriE/BOOyp93BAT\n\tyeEj21Dn5QKkZU3W8Cd+1PQImjT8Kp5uL4sSjneKLHkxD2JyB/XFtxTNZvud+5wPEoaN\n\tHHarqkITgsr91DWneyF5gnmulh40CxrvWzwShMvWawaZuOnUXWI+CsZz86eJr36Pk19S\n\tACxZJ1yaElK4BBlNRA5lPtNQr0BBAzwHnMb3XkCXOD3KNVwRaT3Wf5rcfPHW0s8jeeWe\n\tznjQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996545; x=1756601345;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=ESRMJTblPPvZq2GFxDEIxtOdNxshCNwucJs6WtvfNbE=;\n\tb=gS6Xj5j1Q7uucV+Zw/08BaBzKnsGlliTqnjsrHNiCH/fvBlGJCBcvFuPccBx4jTltw\n\t5/EedIo+5LffacHbRKTApPAiYP6WyEK3dBBLQ53CgLXMh2rgfgcxhSMiLAvkoWIYg9bZ\n\tOj2qr36AtzVxQtfl9r3FPqP7mBbg4iI6/2Gd8eH5nWpLPqtCcSeAMutR6fFqC+2YbPiq\n\tNtBQ/jgfB7H8Bz0cEyLU8AhnPNyfZwY9LW5pMAS05lcc1ZE7Yj9SnMRc7xA/2H9ln6e7\n\tzT6YU95auyCoE8K9FFG6p0n7h+erTwDmSkmeKZtXbceU4Lr57jMCG4C4a+V4ienkUtmz\n\trsUw==", "X-Gm-Message-State": "AOJu0YwwIJlNB2PttUz7Fy8sdBYWyj80Na2RysFZleYomxNqspsn8OcC\n\tTUiqGZWQM1RnaURpboeE4vswAb9tcw62N2Z3NgufuB0DYpiNPO1k7ujgLNGKcWlf9Kc=", "X-Gm-Gg": "ASbGncvXeJLafY+VJe5dkK97RQAVzZHOLPW71Eo3nbuVt4UaIsnPYO1rmR1fENHYt1r\n\tI/fYnmcDUa4eFKS2X/G9RaPuPaivUQP93U+67zf5KEq57EGxdiakA3V99De0MvaXE1FgFpn4CHA\n\tckDTGec17MUFCxkVvuoXU+koOSWRK3Y4+v6lR4fc4f1JQBXZlOYoh4CikkQ0NhJUAotRsrXCdJj\n\tbnlHe2Kd6TiEN7lRZgdHxmJlRTR1/6gu7Vh/qsfsw+dYU+0+wigIEu07iUBWxl9ALOlImYpOtkY\n\tnH4V5+sgN0NDwiojyGpaimTo2vTjkaNTdyHKIdslePAP+m6wsLecg3IVl5GTwLizg8GKGj5tOTt\n\tykwaw9FiGTgXdLrQYIXPq76NJQw18BGWBMFqjFQ3f4nLKxkQxLbif9AmIYIsv+VCU00mDH2PRYZ\n\tLhSW6HkK0wGPNqdhmQhJ2P", "X-Google-Smtp-Source": "AGHT+IERtlDc63AGtTIOKTaXXl+Nik/ssWCk8hAnfKNbJ/nhl6shrxoLWRsm8ilkuYJWNNMzhI4c8w==", "X-Received": "by 2002:a05:600c:4687:b0:459:4441:1c07 with SMTP id\n\t5b1f17b1804b1-45b517cba51mr62510545e9.20.1755996545262; \n\tSat, 23 Aug 2025 17:49:05 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:44 +0100", "Subject": "[PATCH v2 32/37] libcamera: shaders: Extend bayer shaders to\n\tsupport swapping R and B on output", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-32-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>, \n\tMilan Zamazal <mzamazal@redhat.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1571;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=Ib7hryM3y+nj3Dvp5/I7OoKBgzicY5DGoVAJZWOVdiw=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFiRLDbsLQxoedzZH3XvYuFi41e+qF19dSgh\n\tD80P66df1KJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYgAKCRAicTuzoY3I\n\tOl2nD/449du316Nb4JhRUrUcNI15eTuGVx/+tAf+j+ffJwzsySC/mUZoXH4YQsybWt0CVE4qti8\n\teP1Me7UYVRdGAQh8/VEN69cmeYFMtNOZW+lE5QZtS8nIVxD6hBU5e1KJjT5gVAWi7/EiDg/n3Ev\n\tZdowfEv0CwQm8PjQfN3l+RQXr/64e61+H5YYyFhQj3ejQkugweVpg9bSZGa1YYwLB1JeNyAfP+t\n\tjH6p9wetu2+3zBla+B4W0SQj/LaDHtDD7I3gSbsa31Bflu3yr9izT70fUUSwiYqdRG7AmhRprD+\n\tNrumrij7vhO0Kl315RJpCBdZJ3uQSTf0jaY7+saKMmIev1dUnZVAmXhpXWW8RmAdRLlpkRYEKfZ\n\tri5J6IBysCXxn10p2rJob9843CxoPYbjP/8q+zsvxUsA22LRpktsB7j7X/tebPsiizBo3oAE41S\n\tSNqRZ8EQwxgu3MAmmkcUQ/BjuLPrsRtMuZjiYvS1TacT5rNn/nyoToWlZLtkoPniOQAO5hWXysg\n\t2p++Gk6rwTrK62WSrhg3MqadqKatq5UfRkasZCW6QuqiqhvNVuTdRjOdgmLUrtcGzRiqRD+6Kdv\n\twnXbn2ZVTrXMSrHyU2rYtroKOJsT3b25+1CzScs8h9nqEXlOy3vm9rLHqRb2ASlPTwx39C1bIVW\n\tZ3JeZGDpfoYE9wQ==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 4 ++++\n include/libcamera/internal/shaders/bayer_8.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex 90bd645709e02d8cf9bee112b25cbb26c681db0a..c0632eb1f2089522cadb548a163607354bf7688f 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -268,5 +268,9 @@ void main(void)\n \trgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_8.frag\nindex 5955c2eafbe03678158b240740e18c7f00e58057..74ce15096ac0b8a221175d111d982d1222b7db38 100644\n--- a/include/libcamera/internal/shaders/bayer_8.frag\n+++ b/include/libcamera/internal/shaders/bayer_8.frag\n@@ -163,5 +163,9 @@ void main(void) {\n \trgb.b = texture2D(red_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+\tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v2", "32/37" ] }