Patch Detail
Show a patch.
GET /api/patches/24215/?format=api
{ "id": 24215, "url": "https://patchwork.libcamera.org/api/patches/24215/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24215/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-31-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:43", "name": "[v2,31/37] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4332d9c2287e66c06675e1d2dd88742998b215e1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24215/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24215/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24215/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85637BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7AD76930B;\n\tSun, 24 Aug 2025 02:49:42 +0200 (CEST)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C485C6930B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:49:04 +0200 (CEST)", "by mail-wr1-x433.google.com with SMTP id\n\tffacd0b85a97d-3c68ac7e238so724802f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:49:04 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.49.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:49:03 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"h76ciJwy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996544; x=1756601344;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=DCqHCxet1Q73SPTtfGHoaCKptnhz0Gi4nTZH0aC6nUA=;\n\tb=h76ciJwyGdkU+e866Er71iARwIHga9E3TzWdY/5B8yG0ZO3togOqebsKRIG42o4cnI\n\tmHDJqTeFZwYG9MfDtnNq1Dr+tWYAcKoHrEhhBZKKMGZmmG37VnEdK7QHZJCh9dbNm+x2\n\tz4FLUoB9wDANInC8Yh7wj+wL0V8jX9jnLNs9k4Mu/B0Kh2VBpM6V7GL3FvkoAMnSXG3l\n\t3yz3ppSfSZ77vYYAAEu+ZRs7kgkvHmHUKt3fNDNTgU0DJZSn3kKSG8FOpyyEWqgLmFr1\n\tWpuqsZF/j2ouSH50yCFSYukacHijlJbTaNmzH7dn+22/HIG45zQ47i1ZWeyJ393XgpXJ\n\tSNdA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996544; x=1756601344;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=DCqHCxet1Q73SPTtfGHoaCKptnhz0Gi4nTZH0aC6nUA=;\n\tb=p5UCeL7U15NE8VvgmZ8y3/AShUB8ZXr+ZFieJjAG7iNvgh+NjtmLIVdpSPerDhfrR9\n\tELOjUmeSDdK6Sq4U7bSxqDl1GZyx84J6m3z3RkD9gv8FkAIwwdN8aPOgy2bEQIR6niUf\n\tmFD8W8U8ysXb1opKuru94fAxwUyC0kkIdPdgHvss2OKObql/eHf8754qiW0Pc+ZMM3Aj\n\ttyYoI1o+7Gt+0vQKJ1HWCxYPTYaUPj2D8vihCAZq/fkUGI4KFqPUzqULdFnJmb0GGhJ9\n\taX3FhzWaH6uJk4EE8NPD66dRt3uo6aS0NmlsPlpRff+r/B1oP65yWAH9oHHqAfYLINVO\n\tGyZg==", "X-Gm-Message-State": "AOJu0YxuI9ugLJAobs7BNJIINzN8AfgzI4THRkfowwijxhBj/HCfqgJz\n\tX+bNzUTfpoTuHUa2qCFDyFTzyCM/JMFxCDUpchmPnTEiC1xKMTVkX3Bb+Xlb+RDapBS/bpGbRnE\n\tosiXLdmc=", "X-Gm-Gg": "ASbGncvI3xNGG3nHIz23y0QgYwpW1o2cRm5ItT//dEz9WjKqetssaZ5E8lsCq0GjWaU\n\tQZJSH8aK/DZKLtawfnFJYPWjw0qZ9cLeSLb3nxTSXP71f/rN5P4zIyLe8Rl+99Km/4kahsHSqV8\n\tguC+sTSiKmMvkqbJoTe6i7DGGB7CDaHk4svpNQr4y1sos5cvD+hISh/UAKG74xFrvK4YclJ1eZs\n\txmfOtAPwGasUfMCOTAY52aNZiESzd38dim1DWlCPWwsMb8MHPJ1JGGqMXz2tdAtr0mF5S6PMEDi\n\tAnpkr/VevChUp8a4YSIytB0NPEuqbSEfMcdMmxUQz7zYURe6FQ0RKITD0kYc/Uz4refyNt16TAF\n\toBXJvo/fKsPGvGQkOdu6Ij2oVHgYsBa10lj+e5fwV3bWMPQ4ZLcOaN+4CB61mrEAZ1+COB5Bk4p\n\tIAPyz4hwr3mezUygL7eLVd", "X-Google-Smtp-Source": "AGHT+IFnPwGQndyghYCISxXw9NDWzLmjB29eNNcvoHjtoul1ztFmmccfp5gusOCAg1gAgkQNgfe52A==", "X-Received": "by 2002:a5d:66ca:0:b0:3c7:2491:a2e with SMTP id\n\tffacd0b85a97d-3c724911079mr2607611f8f.44.1755996544327; \n\tSat, 23 Aug 2025 17:49:04 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:43 +0100", "Subject": "[PATCH v2 31/37] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-31-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1447;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=DekyQy3uJSqo4rRn9kndIfkU+fGKhdQvubE9arMaarc=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFipwGj+ZbhCzxGk7+xP71T5U+AW054gmK7K\n\tYHSYg4aKoCJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYgAKCRAicTuzoY3I\n\tOrMwEACUjaXSuGnCd3d91oVOg7X6fqGDPzo4/d9qRheQT80Z7evk6AZPbuP+sWzbGM8GHeEDOy2\n\trJ+UnqSRdk+zU5Ab/kQqLK2RqtZQEx1/9fURfmhMZ1n1JI0FZMgvlnVq5XFjwAHIbBDc9xDpwl/\n\t+jLhzWa9ZihJAJywNMhs3FgT9gKf5h7+lYJrMWDODMc3xOU+SRKs0r1e3kI1z9vJvvJzWKtUFfq\n\t//CDOZ/rhyG31ZZ7P0MwQf55ug5MwNfjW0zTrdl5xDioJYaOn9tnOsFvAb8OTbzeXOdKsjOao5q\n\twWZ70L0C8UGpJpEJey1uPWvZaXjDodX2AZrd0uZOnf0W1HT/MW8m+Kg3JuBcc7vOxNPGHnDXFIh\n\t5l/lldStqwLqcrnEX43M7cvr9OWN9vR4CANuVo8HlWkjNuzgQ//7vwcx+oN8aV4Ym2knTS8zPBp\n\tB3N2ldZuKMLHRS/4KOm+NQYlgsmQn2b+7jpUA3VP8aM6o39c194+f3FVqhziPJqrgwh+FoDyLug\n\tXKzdQ+zIhzPQZjNFQSqXjn8cyYvh2HcdqWfeQfMyoy5f7jAEH4UTXYg73x3gKmZZXoMoXo6rd3M\n\tX/ZuWKz+ndZEcpStc5aJT246kPKwsJVnZhuQvAknd9kVF5Vuy4IZtL5zTKrcBzXIf+i7hoOoDGe\n\tDvoqJhnOanPKClQ==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make getInputConfig and getOutputConfig static so as to allow for\ninterrogation of the supported pixel formats prior to object instantiation.\nDo this so as to allow the higher level logic make an informed choice\nbetween CPU and GPU ISP based on which pixel formats are supported.\n\nCurretnly CPU ISP supports more diverse input and output schemes.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex a043a954134e71c625a8d2e493c45f9ed22624cf..999e3421c5152380926ec46e4233f053a089803e 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -102,8 +102,8 @@ private:\n \ttemplate<bool addAlphaByte, bool ccmEnabled>\n \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n \n-\tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n-\tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n+\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n+\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint setupStandardBayerOrder(BayerFormat::Order order);\n \tint setDebayerFunctions(PixelFormat inputFormat,\n \t\t\t\tPixelFormat outputFormat,\n", "prefixes": [ "v2", "31/37" ] }