Patch Detail
Show a patch.
GET /api/patches/24206/?format=api
{ "id": 24206, "url": "https://patchwork.libcamera.org/api/patches/24206/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24206/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-23-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:35", "name": "[v2,23/37] libcamera: utils: Move ALIGN_TO from camera_metadata.c to utils.h", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9c0f9379dc88f7ce9a04ccaf61d4efa62eb55ef1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24206/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24206/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24206/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BB61BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4A076932D;\n\tSun, 24 Aug 2025 02:49:26 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7999F692E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:48:57 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-45b4d89217aso16725425e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:48:57 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:56 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"UjxTMeyI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996537; x=1756601337;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=yLq21F5yRryLv7x5cIsVnUA+04op7PybL91l/CYRfb8=;\n\tb=UjxTMeyIFK960KLhHQLxt+44vUmkJlbJWG45nh04nh1CcL/eJzVXhgAlFOwZ4r1mdb\n\tjKHsueetkPsEhwpMjoSIRPMRf3LOYs1S4lEF2i9jwOn/7B0HEDznhjd6wJNVJZZDHWop\n\teLmKTPt4xKECHr+EiOWnBd8b/MMeCsjq6zdbGrMeq2iHuMrghZRzaF9N+aaX4iNmfjWh\n\tRL/nQjqpLPq9wI9acqBbBySDWJxextFml/Qkzp0soAByFRWTb1eYhqy+Z3nndIDDhoTa\n\tiFfBLzGVQ9E0AuI8L1zq+oSLahWIi2/5Pvsh7sRY92cYbzCcuNlGJKtpaWT+U91FjwVx\n\t/uGg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996537; x=1756601337;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=yLq21F5yRryLv7x5cIsVnUA+04op7PybL91l/CYRfb8=;\n\tb=gQxX6eeqz6AXVfKxkcHoZGP0DV/WCE8ySCyj6gM16vPOuVQhUkGxjRMQ/iUoy1kzpl\n\tUj8W8Hs2mylmJBdMhqIGFEQawo5N0ph3tbojK+f+ldLkNoElh3MbMK4d7V72gNa/l5XA\n\tfNo/pUS0GgFzbtQ335b+9bRTVtOqCLbRGrWTAVxScD4kvT5znwC2rD/4pAFHX4Cxm82c\n\t4qsGiB2jM96KUzOtDyiynqeMSQkrWZgZEOQcubIIqy7ewzrMkU7Z9e/hG0fM1U/4Xodi\n\tWEvWBV0CWxEyxQZQF4eNkJD7pLePaxpO43+yZWLOHIaMziIc6ulJdpGWin/GmiueQpN/\n\txYxw==", "X-Gm-Message-State": "AOJu0YzGMrrMTKuH/XaiGpQmXP1c69yJQpZJXiIQORH0uf/1ZYZ+A29a\n\t90sAmdNy1YpLebxddMVYYE2ONQ5r9n/4N0HYMyphkKUQsxiDvItvMK6+qKlEppaNHWJWuYtWxec\n\taKZvKFoU=", "X-Gm-Gg": "ASbGnctzwQWcnaBwN/+X20+BFzaB2GqYyZGvtq0natsqNpRGXfoHMFy8+8U85i2/C/4\n\tLgatJIhWntqARNLQh1iddTgGCzlagH22S7NECIrp1zIgp8AGK9LKk/h04rmMlpIELfD3l9by5Gs\n\tV8GOj4PxIcClyse1FLGdeQsACQF1QNgpP+E4q/IR/rtlg1qJZv8FqFrdhA3DsC9CKmSRg5H+fu0\n\tQIASsXUyXsCIpgIGHX513Udo1xMPtPLAEATT7Q/xndvBvyLcBsJBJpVULOfOoqIxZwYFBCqoT/M\n\tPIk3+OLklK0XP1MSDfxzkSkP0Ih1KBrn8A1ugCBFgdy+WBVarRv/w/cWviOVMz4iU2vMG6cUS9e\n\tjbcQecqmZfR2h6iyjIZWTTS8djiLF9L6HAQUqL7s4hDYIaRyTyezP1PHRMfR9vBEXTtbKTSrYzh\n\tq+L21xfG8YeNhyBqqCvLoT", "X-Google-Smtp-Source": "AGHT+IHgep8TtyKon7npTUgFygnm5xKCcKaFXbtRlS/j+/kvgxhqPhagwUPkk0pb5V1e6/0VPV3ZCw==", "X-Received": "by 2002:a05:600c:5494:b0:459:94a7:220f with SMTP id\n\t5b1f17b1804b1-45b517dd998mr53252775e9.26.1755996536801; \n\tSat, 23 Aug 2025 17:48:56 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:35 +0100", "Subject": "[PATCH v2 23/37] libcamera: utils: Move ALIGN_TO from\n\tcamera_metadata.c to utils.h", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-23-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1627;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=EwojlEA7u5QGO/oFAUMxFKVPV5YgZWQoU9hMLxM2CFs=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFg+Wa+wvgh4Bw8ub4iobUKHQtFoM72/DpBC\n\thImn6QALG6JAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYAAKCRAicTuzoY3I\n\tOkttD/9wPFft/k5nU1HlyRTQA6QcyBkTp27Bk5VxJZKkvUHW1XaSCNq9EmiDrnKN5a0HFDKQLw+\n\tiXtrS8avTcPcPFq1sXov9Bq3B9QAcs/DyLm1TLU3ZCMgqreRynbTPY8dSQwEOUf7DDWccpKptHr\n\tqiWUbbeKv47jEOYqFbhXXBq8xJEnUOVsTnZ/lpuLa8kvYlJK5p35Kgm4vc/ggnwrTKUnQgEbXJY\n\t/s62FlSZ3hCfQG0QcCgOlY7LDdJCpjqfhUemcN4E0Uyvj4rDRL96Vr0tm4FDUpjXYHgHlsqV7Sx\n\tWgRox+v9y6gvuw4aa1M//GeeGlxH4NcClfsE3NbFD8Gtx/LINnwfZYZewNY28vuMsx0PR8tfbjr\n\tftuXf9vpThq2u1Hkh4hrCvBtUT29T0n4JQoxBwUwxtz3AK4UDuHqX0mLB18S1P+f0c3t5K49wKV\n\tMNUrk5dbL1XaznTZTjEIMwi39MKMQXpsq6fENu+oYXejTa2uq+0qBwY2J2kD9/FiL07Xxdb5b/R\n\tOoodgbVYxMqQK2D0NpIWgI6tTg5z5Vq+opi67erfcPt9qza9Spw9pAQ9hIRM62c9tvwbs+RylUO\n\tBMQ4SGVgrD8xXnLFMjGYQsq4nlmbpydWBag2U3joW/f7BFoVk1SzvLuUTi7c1IKT0BBhdmkvu+F\n\twaSl/iXPzn7CZVw==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "ALIGN_TO() is useful to the GPU debayer logic, move to a shared header to\nfacilitate its reuse.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/base/utils.h | 3 +++\n src/android/metadata/camera_metadata.c | 4 +---\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex f21c6dc016ece00e9842ad17ae4dd036fb5683c2..a0d3ffc27804d27c6b225d7da8c74feb3c261f3d 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -33,6 +33,9 @@\n \n #endif\n \n+#define ALIGN_TO(val, alignment) \\\n+ (((uintptr_t)(val) + ((alignment) - 1)) & ~((alignment) - 1))\n+\n namespace libcamera {\n \n namespace utils {\ndiff --git a/src/android/metadata/camera_metadata.c b/src/android/metadata/camera_metadata.c\nindex b86586a7e6857a0920234ea312eb5181b27c3ac0..4fafb54076a4a4be41a31f5ce3bd8c74bf649f59 100644\n--- a/src/android/metadata/camera_metadata.c\n+++ b/src/android/metadata/camera_metadata.c\n@@ -24,6 +24,7 @@\n */\n #define ALOGE(...) fprintf(stderr, LOG_TAG __VA_ARGS__)\n \n+#include <libcamera/base/utils.h>\n #include <system/camera_metadata.h>\n #include <camera_metadata_hidden.h>\n \n@@ -39,9 +40,6 @@\n #define NOT_FOUND (-ENOENT)\n #define SN_EVENT_LOG_ID 0x534e4554\n \n-#define ALIGN_TO(val, alignment) \\\n- (((uintptr_t)(val) + ((alignment) - 1)) & ~((alignment) - 1))\n-\n /**\n * A single metadata entry, storing an array of values of a given type. If the\n * array is no larger than 4 bytes in size, it is stored in the data.value[]\n", "prefixes": [ "v2", "23/37" ] }