Patch Detail
Show a patch.
GET /api/patches/24203/?format=api
{ "id": 24203, "url": "https://patchwork.libcamera.org/api/patches/24203/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24203/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-20-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:32", "name": "[v2,20/37] libcamera: software_isp: ccm: Populate CCM table to Debayer params structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3f4be1ea7b9772f798bbce3fe46ad17095ae498d", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24203/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24203/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24203/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18ABBBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4D5E6930D;\n\tSun, 24 Aug 2025 02:49:20 +0200 (CEST)", "from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0AC269313\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:48:54 +0200 (CEST)", "by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-3c7aa4ce85dso315408f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:48:54 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:53 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Tfht90DB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996534; x=1756601334;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=8ylZnKUZSQFRqy6Q0Mt40bxE9kZ4CGqpwqvqE7SvScQ=;\n\tb=Tfht90DBUq7bfx43Ymxs2Q3teVFnceaxOvH0N2tmFXIxBFn891MFELMe1MzpvV9vVc\n\t/uiNEFj9SGy3+TLx1/az2YidPCTzqjnmNUg0q2wMfTONS09UbCGcS50oytlL7X5c+Nnx\n\t9Hn5E4X+sQ/EXgR76MhPipqQJ7ZQn6sI7oPUAlzCMZoN5dKcrFFeyDkDg9RLfoqOltyN\n\tEfV1D2Pb35Ivl29cwHzngFizbu2c3vyr8B07GwYYHBIAwoizDB5RyaB/mrgKYeZYljMp\n\tnwjBEmXSwkX96Iu1w13b3/sTpWKuqPtAKtDijEOt/wOfv5VVvQggN9G/W/i76lX9EseS\n\tIxfQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996534; x=1756601334;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=8ylZnKUZSQFRqy6Q0Mt40bxE9kZ4CGqpwqvqE7SvScQ=;\n\tb=gy27qH6Q0Lpzh/UtvMebZmJ9kQzxlI6oPuvVIkUH41aVe/UbZ1ub/UypsrPlZykCUX\n\tXKA5uePj8o6Cldy2s8GOnBvyPd31zD5fgKd1U9m6b4lUDWLgREzWwjbI5HS6N8hxsMxp\n\tpnImZOlqLRnU/dcxCLDTDDw4lNuvxwydbpk0xTDn1+vqYnoYgIbv0sscgtuqtz66PpmC\n\tctTsxSkVad2kaW3mCb61sWKtbY0LMwMbZxOvkbtH8pwX3zEFqdjEGxNnS19+8uAfxpKh\n\txrMwUPP6qfDRbZ4ylC36RtYufLQVCMJvc+KP0J0vbWe/SFlmturkvFgSbPlP8Ly1zCX7\n\t0Ygw==", "X-Gm-Message-State": "AOJu0YyJI8J6KcqtIRizfbgHm0wRcIzaoAru/CKikXDVfkU9bVLyBk3f\n\t3stvJcnlNPDa2epLF8SdXXQWwYpiGZZaHLeNxHnB9MNVWWZJ51dhETfxNL8GJdOKMtiuURoSMca\n\tMEOYZ3eg=", "X-Gm-Gg": "ASbGncs3u19YPy1tv/Qa1Y+Hd2USRh4LY0XYDCvEsqyzDQvZTyQSlO02IKQwoQmmC/M\n\tlKUtchgO4RlkYApQAR4SQhavN0JXoPn9eeXUcor+REabDJVkS//wW+GRYsQdQuGt7sdNlpzAEfx\n\t9TT70JKskimFss3b2epygh2LV4sFj0hdcWZIUDy7KqGqDhfsmI2D2fFQlYH7s11onfDyhqYLLSk\n\t0r+jMHZMUlnu0QAhhJpo/ppU/xrO+lJXYAJzRDqdH7EzpgtbcCIeuZKqD6w8PediFE2JosJT7Ym\n\ta5s3DojY7gsQ/JIE5to3QE3X7AGB4yN+BcJ8RZ6JHm3d+O1Xxbc7GO3/Z0skPoniBsWYsphZsOH\n\tICGdHT6YbGZEUwjrEAZaJ4n9buAvgn1yF3rNQCSYGBiQeOxEcvOXN+KxhcWFxj+SkR9LgyLLQxf\n\t4Y/Gfb+bWfbo0zn5Mo1ncpztrTy8ZWyQs=", "X-Google-Smtp-Source": "AGHT+IFODisU8EAO6N68UtZF/xKm4fwkbfEINAgmsySIfrk8e5nbdhLE9PSG2kBQyjns//G6vmkVWg==", "X-Received": "by 2002:a05:6000:238a:b0:3b8:d79a:6a60 with SMTP id\n\tffacd0b85a97d-3c5daa27b08mr5948313f8f.3.1755996534258; \n\tSat, 23 Aug 2025 17:48:54 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:32 +0100", "Subject": "[PATCH v2 20/37] libcamera: software_isp: ccm: Populate CCM table\n\tto Debayer params structure", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-20-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1374;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=NbGlfVoohNS/JTmXncJUftH1APwEXtQE51HMVXCz0vo=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFgHC9C2+cF7SBz3BenmquZ8cd0RP5GpvLIs\n\tRzFQdsfMR+JAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYAAKCRAicTuzoY3I\n\tOoBcEACMc307LbotS6MIuU5oeP/18nLspTcdCZrj861B10oLJ8qXBkgvkva8AKG+MS6CoDMrUX0\n\tnRkdkjzq0qwDlCBN/3W6GdxQQxA+DitFhPDIz5ApGfYObIbS6UggRT77jiKNfFfPdBSSHbQDbRj\n\tivdqy4k2D07R4MjIJblOdeQ15vl6+KF0Yneu5acMqZxdcvSSMQxpetoWL3HuA98sMsK+9neuOWF\n\t3xlLWV3XwG/STFUJj/frgrfeL+mzNaMY3yc/6MtksCB8Y9r2//I+4QT60nGTeQ8GJ3S198SkBlZ\n\tChQUUamSyeGgFtn2G3xrm3EiKuzhlQyocHJrovv+kjMW7Z6fBcM8TjWkslxAvK/tId1jr1JeitS\n\tGl95mH0TaNCE/49gq5FrnuOuY4oWS1VVoVzec1m714Myef5dw5Lgf/N3vIPQEMVX/nLZsHFxbQZ\n\t/nNAJjr1PByBeOd5xFGDV3N8zSrKT0/XwCXtxldaL7r04g6bquTktLlgrrLDhITGuCVHvbx/5eb\n\tPgABcaita+Fc/NtsBVALGW1GIPUWwKXSqbadYGVDjHlL1qVE4IFpEW3iZFmi4T6I+7We7OxcnQc\n\trJMzrmEG23eMd5HR+H+fnQvz96qxDGRp2s3Aoo9aGXpsqHL/pM4Uv8v9BHNUkKzxTHjRbcZmll0\n\tWaMGiZQEL9Cu7pQ==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Populate the DebayerParams CCM table during ccm::prepare(). A copy is made\nof the CCM into the DebayerParams structure.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/ipa/simple/algorithms/ccm.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex 0a98406c1a3aef84b39e40fbab5ed028fa249c30..cb023878d82a6ee08628ea75b61f173b03403f9d 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -14,6 +14,7 @@\n #include <libcamera/control_ids.h>\n \n #include \"libcamera/internal/matrix.h\"\n+#include \"libcamera/internal/software_isp/debayer_params.h\"\n \n namespace {\n \n@@ -84,7 +85,7 @@ void Ccm::applySaturation(Matrix<float, 3, 3> &ccm, float saturation)\n }\n \n void Ccm::prepare(IPAContext &context, const uint32_t frame,\n-\t\t IPAFrameContext &frameContext, [[maybe_unused]] DebayerParams *params)\n+\t\t IPAFrameContext &frameContext, DebayerParams *params)\n {\n \tauto &saturation = context.activeState.knobs.saturation;\n \n@@ -108,6 +109,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tcontext.activeState.ccm.ccm = ccm;\n \tframeContext.ccm.ccm = ccm;\n \tframeContext.saturation = saturation;\n+\tparams->ccm = ccm;\n \tcontext.activeState.ccm.changed = true;\n }\n \n", "prefixes": [ "v2", "20/37" ] }