Patch Detail
Show a patch.
GET /api/patches/24202/?format=api
{ "id": 24202, "url": "https://patchwork.libcamera.org/api/patches/24202/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24202/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-19-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:31", "name": "[v2,19/37] meson: Automatically generate glsl_shaders.h from specified shader programs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "315dfd48cde74cf55e53e006da1f91f24d8df561", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24202/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24202/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24202/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECC51C32BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D6FB6930C;\n\tSun, 24 Aug 2025 02:49:19 +0200 (CEST)", "from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D72086930D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:48:53 +0200 (CEST)", "by mail-wr1-x42d.google.com with SMTP id\n\tffacd0b85a97d-3c79f0a606fso432881f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:48:53 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:52 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"jkSXwsym\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996533; x=1756601333;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=WVq5cziKKrzTB/f1IlQrFIPwt3j05ogaLlswzu8kTYA=;\n\tb=jkSXwsymgmRj1GIh8OwMtOp3bBWZnGaYK7HdPtpjWexY5st/78WMZpzB706m9afWe7\n\tgRll8zTAF7WXJXrNX7vPQM2Utsz85seliEUAlkOkNGfzOiXqonsYvSBw2bdKJImJsC4m\n\to7HPiiCK/AP5sBz2+Zdfu2pn3GbFAKfxbjSqeSOImcqzoKKoZ5t7RUYvZUqXjuDsQJvf\n\tmx5zu9zXXjzBD8+4/6h+Wd/tqVmXT8zyvf0DvzMrrITJ74Sz8IF+MRC+dxhm0Vko7RMz\n\tkN8ycmCGj6WFPijBwKtN9pXh+nAqbjAidSQ7OyOdrp+RWWijp4rjC9IazOq0lvu/kzyL\n\tRVUw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996533; x=1756601333;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=WVq5cziKKrzTB/f1IlQrFIPwt3j05ogaLlswzu8kTYA=;\n\tb=CiDnXa+jrdp1RoiHAlCsLdPomTNmdbZpvCPM8ZAHfQ/yjhzDiQzIUOwYX6/nHZ80GV\n\tgMzRIqDKFpMbRRgFTT8iCP2eQS7T2L74HvuS4QG04r2q/wN2fkNwv4kh7ZdillADCYJQ\n\ty5WRXePQMDLI3RmSle6GMR+OeoSdsYyU7t3V8jsrV6T4oQK+XWujqCyNbgPZQz1WBsGw\n\tM1H98W5EDmFGX9BGH8G6xZ+iGW6NFScYXuUdf3Nfljdtjja2/CfAQBLoevjSJq6MDb7z\n\tdMXaKcDu9zfxkyJa6Jq322r+iE9/C32aD2aM8Kuk0OXpJR21sp9uQlhbj55yVITn0tMl\n\tdjuQ==", "X-Gm-Message-State": "AOJu0Yy8Qez53AVmojdK/GqWj2e1TJcXhb8ZxNaSLaA6h7pvOGcj1sx4\n\tuguyzaLq758nL/ZOwOVWdTLaGTcRJw97jgNW8qnqreqR83iZQ5BztJkKl39WDDA+P+c=", "X-Gm-Gg": "ASbGncvidUjGCIJuB9fHluZfP9MTWroC9aH2tVh0tD3BlTRgXFAyvYGEFuTDQUX/9ky\n\tz8k0wBa/Sj/LPCqW1O4VV2PLeYGk1oTd7n6Pb57NyAvkpwppR29wia8uWpzWjaaYDFP16gVph+y\n\tF+inoFc6LZsFdpev6pEmyN87BriNTKxn1tp5pLHXIT6SfdUWTiqAMadwf8uosJtW2sGHfzDtz51\n\tFlgWBHDWXgMR9CPEbR+8ZEUfiaGUdZVN0/xo/sG68ZflZIc/CDXAgWH8nmwnFAcshiNlfWzkz8j\n\tTQvFI28UGidwZ7KY3z3BA1Kts1b7HkRFZePNSx90fwwnV6Zfp+3P8A9JhjDn1ycEnqqTVqOxL1W\n\tceG+k2v6kvONBUu2DdOgdMM70Ln+dV2uIDMnpmqmglgn0dJJw3EuWShM5YSlUY+jxkk370etTLf\n\tAj5uDrACvS097c2ZTC+uCylsYnszsHPiM=", "X-Google-Smtp-Source": "AGHT+IFdcmiRfTJtzXWM+sRlUY+F/J/OXy4wf86k3s8P4CB529VjZo/+eJ4LAFEFoe7BMrdGuwSC7g==", "X-Received": "by 2002:a05:6000:2510:b0:3c8:c469:64d7 with SMTP id\n\tffacd0b85a97d-3c8c478ad55mr95402f8f.45.1755996533438; \n\tSat, 23 Aug 2025 17:48:53 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:31 +0100", "Subject": "[PATCH v2 19/37] meson: Automatically generate glsl_shaders.h from\n\tspecified shader programs", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-19-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2511;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=Fx1AlOY28NC0VR0sz9yn6g9uTYfxDKucQo96QZW6id4=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFfMcwSWukyNqyw0S274eEoqL9XgoX31JQx1\n\tjqJnT9W5yuJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXwAKCRAicTuzoY3I\n\tOhjiD/9TObNQk69qfj/Oqzobs32yX2swpWdlKXaoAGIZO5Ald9CU5oYYPbO6ZGtWSTsJRsc0m98\n\tuUczS/HYnh1DAyp/EVAkeKQ4+XOOhLl1h1Z0JdyU4WvvORItPOUhEWQWcRPUdiw7XaaP6y9QJ0y\n\t/F1RMckXWlnArgYXndeMlm6ZE9pyca3q1pcLPSXIzezf0RPki6EV3h7UPk74u0uzZScNh85ffdt\n\tgLulVh4cu7n/imucSnNuCEXXd2FotEVeF9MMTHwiRlc01MR1l+AGkpxabKrkuU+MoSwP5250rrc\n\tKXycubBpeF5IuZ8+1sNi7ux1RlkYzUSzixDUuEfJXCeK7Kq2m87EznP23s0YzF00ZoVFUEguUku\n\t1WI7r5qx691kCugjy5IYu93G8mykAHZ4d2BVUFtZ7IoAFDJtLdekyw1aCVTVG0GOtMDXF5idBOH\n\tgVPOL8SNoIGb7V8Ag+KymHuI7k70GJncnPS6wzgTm7o6lmV4gHG9mN4E433S9lqDB8ESUIHdFUF\n\tLcclfE0yUTQZm9jFFQfmnptpfbXe2/F0LCmvpOOBoGov9SgeaB70nww6ggA7roCk8ywduYbbg43\n\t/HUS5eJpwE6BoqTn7u98bc2yxADLlFTHdKqMTOjZaxG7JaqCTlTOJ3xSBxsP/oGr7lzJwenKILN\n\tayaybSc5uugkSiQ==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Encode the bayer shader files into a header as part of the build process.\nQcam already compiles the shader files down into a QT resource file which\nit references internally.\n\nIn order to share the debayering shader programs outside of qcam create a\ngeneric header which both qcam and libcamera can operate from.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/meson.build | 10 ++++++++++\n include/libcamera/internal/shaders/meson.build | 10 ++++++++++\n utils/meson.build | 2 ++\n 3 files changed, 22 insertions(+)", "diff": "diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 5c80a28c4cbe6af5f0eef713eee995d61fa48a4b..90155857e44fc64803df5b5a054ad62e48b8e2f5 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -1,6 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n \n subdir('tracepoints')\n+subdir('shaders')\n \n libcamera_internal_headers = files([\n 'bayer_format.h',\n@@ -58,5 +59,14 @@ tracepoints_h = custom_target(\n \n libcamera_internal_headers += tracepoints_h\n \n+libcamera_shader_headers = custom_target(\n+ 'gen-shader-headers',\n+ input : [shader_files],\n+ output : 'glsl_shaders.h',\n+ command : [gen_shader_headers, meson.project_source_root(), meson.project_build_root(), '@OUTPUT@', '@INPUT@'],\n+)\n+\n+libcamera_internal_headers += libcamera_shader_headers\n+\n subdir('converter')\n subdir('software_isp')\ndiff --git a/include/libcamera/internal/shaders/meson.build b/include/libcamera/internal/shaders/meson.build\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..386b342d03b106e8303121ae9b84b2d2ee4e96d8\n--- /dev/null\n+++ b/include/libcamera/internal/shaders/meson.build\n@@ -0,0 +1,10 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+# List of shader files to convert to header hex\n+# for the purposes of inclusion in OpenGL debayering\n+shader_files = files([\n+ 'bayer_1x_packed.frag',\n+ 'bayer_8.frag',\n+ 'bayer_8.vert',\n+ 'identity.vert',\n+])\ndiff --git a/utils/meson.build b/utils/meson.build\nindex 95d657ac965fefc06ea2c0c445bd46b125e56564..3deed8ad4d7e6d18cd99d5d4302b19458e6b9f4b 100644\n--- a/utils/meson.build\n+++ b/utils/meson.build\n@@ -3,5 +3,7 @@\n subdir('codegen')\n subdir('ipu3')\n \n+gen_shader_headers = files('gen-shader-headers.sh')\n+\n ## Module signing\n gen_ipa_priv_key = files('gen-ipa-priv-key.sh')\n", "prefixes": [ "v2", "19/37" ] }