Patch Detail
Show a patch.
GET /api/patches/24194/?format=api
{ "id": 24194, "url": "https://patchwork.libcamera.org/api/patches/24194/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24194/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-11-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:23", "name": "[v2,11/37] libcamera: software_isp: Move isStandardBayerOrder to base class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "aa95ef7227cfe58fd445d9442d39cb40a6b7a890", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24194/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24194/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24194/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33DECBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A452769310;\n\tSun, 24 Aug 2025 02:49:01 +0200 (CEST)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2F24692FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:48:46 +0200 (CEST)", "by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-3c68ac7e238so724713f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:48:46 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:45 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"bp64ZIm4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996526; x=1756601326;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=BSbX7C6RruZ0Vo2tdf4h+8oPbP0c8nchKXGky/xmrks=;\n\tb=bp64ZIm42XrHcuyfY4tE7aeefLmY8+/NGE7Td2Q4XXVf02QVUCGNpXm2ts5h6eOJDW\n\tWiPcmml7y4dZbTYtNy9Cdv7BwAY6f+KrmFm4CaebDJcI+LMo7Akq6GsRvMom/YCJD3Dv\n\tFAkdD6Wjqb1XAeq9tf41jD7Zrkp+Dw/Mc/JEK8Lh0AW2MrNdV3u9QI2YGO3J9v8bMBpm\n\tkbJhmlCS7A+R6kFTahS3sn1aDUlNM/Xzy7QSczeV9iv9Uxn4spApBirdjc+QrAjgT7Ob\n\tKyhrCr+KSGWM11wThhOPT3HjtNqcwtLKPu8oJBJ0sn8T5MbXsR+K7BwFaCngPeoAtNwy\n\tHtfw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996526; x=1756601326;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=BSbX7C6RruZ0Vo2tdf4h+8oPbP0c8nchKXGky/xmrks=;\n\tb=oyFs1MN9kd9FvxfabHFWSjfTgAHDl1IBFOqZH4HFBS9H9QJgJV0JabINodUX001aeq\n\tVAo9+gH778a415rkbw8KZYkZKUFdz+dfmbPr0jrx9yzFGknpkAuZ1XHMNg8yOpcHTv5y\n\teAJ2A4qFmn2X8cY24Cqgi+aUCbEQn4ZjSaRE+m6lQ+U0fr/kCeKpN+06JFbHzv03OIzd\n\tWWMy/UOtO9RLBJTmZ1iWPskQSn8v9OCtZHn3g3Q7TJrEgYjql2MhyZrR5caMZCex+0dA\n\tOgo1THUnd6brK479eI2OjMNKicTXCJz037dz6kLh9SKBQeSSuUemA111Tj2QM7fPZt7K\n\tJPNw==", "X-Gm-Message-State": "AOJu0YyLMJNAmPsV3bh9gjHVnoh8nhOw72jAGDdqo1oHM7BdaiE6QJkG\n\tynvfKb5SI04rGtYlmTnU4u/w8f8Ut+DVMRDvmL89CQbF5KKkD57n0ffkKL350E+Q4qUqxXGWO5d\n\te24Ldl/4=", "X-Gm-Gg": "ASbGncvggKFSvHrjzJxsWs7j/xYKxHXUKto/aQSuIZb0rpL80i0ntkLvIYljYhNzsrn\n\tWzYayCVHapLyWImqCs9a31CJj1LCdMcQ137yc+eVso1F97HYkBLHMgIe15eUkQLUCd6DfWiCB/m\n\txUTPMoa9ldfFBe9L11x3O/OWqG18TLzbkzCpOkI3OBQrCmzRQiOcHB1NPyWymBNsTQ81hqyTCuB\n\tXNu1vaYxrTrUePfxXtQ0PRStUN1p9umrejrmzX44eJF6g6EcVAgu9TGOYm/l4apXFDSwS/Kb6B1\n\tFvXQJ0Cdw7Pilm7yTDf99L1AWh72jwTLzLP2rElhToRbGCWPrct739neU10wuBLl1RAb1Z1YPZz\n\tC3QUyzqrX08Bdv7wUxwgpaplpeUtRSZQW662+JWMKSsjMhoItpl8bWmPm/lJ1TVkZ8LQvC1EG2j\n\t4gBcQZwp8/+jQelrrSGMOM", "X-Google-Smtp-Source": "AGHT+IHTEmKUIzNdLgvEQRbO50q1BZhjiXvUCcwaLg2H2qjiXiq/J2JisVHT46P76rEeOWgp2DvE5Q==", "X-Received": "by 2002:a05:600c:4ed0:b0:459:dfde:3323 with SMTP id\n\t5b1f17b1804b1-45b517cfb81mr60478385e9.27.1755996526351; \n\tSat, 23 Aug 2025 17:48:46 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:23 +0100", "Subject": "[PATCH v2 11/37] libcamera: software_isp: Move\n\tisStandardBayerOrder to base class", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-11-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3477;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=ezFIPvA5CNelaul8+zGJV48vGwnX3ZJIvKfBKS23Dik=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFeY1KzCNiftSUNIYmZ5WwHfSnjo/ZVKGNN/\n\tJmnRekeGvyJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXgAKCRAicTuzoY3I\n\tOiiKEACfSVFx9TwAEomoRAhwpJb1NhQtvWRNUN4zwczuNMCF0c6Jt71ddSFER4tkPdGDbelgZuv\n\tCdq4CYU/yVAhtqeS7iCg5uLNtlOGJrZ8B9Q7LQdxy0rraOrZttsX2RH2lG9AVk8nawBabjDTg8j\n\tKtr5P+j/fPYnzBVhrNSR6KL/3MJjkFLfmGKCGZb125aALbsdILlI6Eiq8oB625CZ/Cja9vy3dY8\n\t7PiuhKum/USLwT81Zur/bMXCXvC6wW43GciP21DYkhRnEygv3qx+zBUe6CzI0F01AVNWeL+B7nS\n\tdRly1LwLk/tOypL9Xg9q+Jsr76vq+/vM8HvsEtqecyFncGXt4qCFdkny9jQVnrxzn/qA0e0KRsM\n\tUSj0ALuOY0dVJ1yubZ1p2v6ikEqfO4Qw410CMYDOqp0FIsq1fEH6myM5mNSrMBVMBgoGEmpXVMP\n\tj2FgTikmpqkWE3HtBn+M5CQiEgrb5Q5v5688iVtAD5B65FmJBAYsycNiIwOv6nBvl5qHCqZCtvC\n\tBFuNu8AOU+OHGoKLfE/tKhApsH7xEKM3oJG7fxH/IYWl8RhZfuB9g7KS4JTadDNYCsgIDkqXzSs\n\t0FmydNrSQCHHLrPjc87tisSlsj+V1HzZl3BlMLYBhP6a5oK7a8ujM22nfUb4s03EEJIqKVmCZhO\n\tMWoMKHgLu6ykqFw==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "isStandardBayerOrder is useful to both CPU and GPU debayer logic and\nreusable as-is for both.\n\nMove to shared location in base class.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 10 ++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n src/libcamera/software_isp/debayer_cpu.cpp | 6 ------\n src/libcamera/software_isp/debayer_cpu.h | 1 -\n 4 files changed, 12 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 75e4bffab0f082bdf6e5bdf3030b9f49d4877524..c16ce44b181edfb94f2532db76ffa4fc222c588d 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -227,4 +227,14 @@ void Debayer::dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *inpu\n \t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n }\n \n+/**\n+ * \\fn void Debayer::isStandardBayerOrder(BayerFormat::Order order)\n+ * \\brief Common method to validate standard 2x2 Bayer pattern of 2 Green, 1 Blue, 1 Red pixels.\n+ */\n+bool Debayer::isStandardBayerOrder(BayerFormat::Order order)\n+{\n+\treturn order == BayerFormat::BGGR || order == BayerFormat::GBRG ||\n+\t order == BayerFormat::GRBG || order == BayerFormat::RGGB;\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 0af66b556bbf8993a66042a3a76cd50582209bce..214bcdd3c535bae7851d6e0221ba68c19785507d 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -20,6 +20,7 @@\n #include <libcamera/geometry.h>\n #include <libcamera/stream.h>\n \n+#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/software_isp/benchmark.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n@@ -87,6 +88,7 @@ private:\n protected:\n \tvoid setParams(DebayerParams ¶ms);\n \tvoid dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *input, FrameBuffer *output);\n+\tbool isStandardBayerOrder(BayerFormat::Order order);\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 9fce2a143ac9585eadcea41744d680bc9589c507..7bd1fc39266f651845cc7a87ac991aa67c36c094 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -282,12 +282,6 @@ void DebayerCpu::debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[])\n \t}\n }\n \n-static bool isStandardBayerOrder(BayerFormat::Order order)\n-{\n-\treturn order == BayerFormat::BGGR || order == BayerFormat::GBRG ||\n-\t order == BayerFormat::GRBG || order == BayerFormat::RGGB;\n-}\n-\n /*\n * Setup the Debayer object according to the passed in parameters.\n * Return 0 on success, a negative errno value on failure\ndiff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex 0b4b16e1a3b64f8eed25b6017274b21c9a89a1ee..a043a954134e71c625a8d2e493c45f9ed22624cf 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -17,7 +17,6 @@\n \n #include <libcamera/base/object.h>\n \n-#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/software_isp/swstats_cpu.h\"\n \n #include \"debayer.h\"\n", "prefixes": [ "v2", "11/37" ] }