Patch Detail
Show a patch.
GET /api/patches/24181/?format=api
{ "id": 24181, "url": "https://patchwork.libcamera.org/api/patches/24181/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24181/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250822123709.16966-7-david.plowman@raspberrypi.com>", "date": "2025-08-22T12:37:09", "name": "[6/6] ipa: rpi: sdn: Remove legacy denoise warning", "commit_ref": "ad891914c61baf5f16455425d28b641a50828c97", "pull_url": null, "state": "accepted", "archived": false, "hash": "1bd3d9915927c95252c34f18db1afba6da60991e", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24181/mbox/", "series": [ { "id": 5398, "url": "https://patchwork.libcamera.org/api/series/5398/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5398", "date": "2025-08-22T12:37:03", "name": "Camera tuning updates for Raspberry Pi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5398/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24181/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24181/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DCDABD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Aug 2025 12:37:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39999692F1;\n\tFri, 22 Aug 2025 14:37:28 +0200 (CEST)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5534F692F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Aug 2025 14:37:18 +0200 (CEST)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-45b4d8921f2so12910775e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Aug 2025 05:37:18 -0700 (PDT)", "from raspberrypi.pitowers.org\n\t([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3c07487986fsm16685787f8f.1.2025.08.22.05.37.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 22 Aug 2025 05:37:17 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Ccuy3kA9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1755866237; x=1756471037;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=dU7J13NSut7B4IXKbFasfDqJ2OiBxOotiJwfrFWeKDQ=;\n\tb=Ccuy3kA97d0zOM8DpZe4ZlorXVWs1fAEyXbwoGx0ll923rKP4M5jQVe6712js+z/Eu\n\tRgJGjcA371JyZgw6c2FBsaQcPaFYENy4XRCNz+uBFN7ZPYnm2kwT64NZIZXthxfFWmF7\n\tGCsG2ZsuqCk/sooHwxii/OnIqCRBXWEIq2GWwBQ9wLrlTJCHA9+f+M9NV8251bnzCcfP\n\thDjObbP7eccNvI3bzmjEbssNZ3Wwf6FgIIVzQfbDo/HV9qTHIxHwqGBSoWcwHINv8K5O\n\tDFl0CweIaYRU3vKMR5CM4jKJ4tR7nei8DfhXNRwKNzYfQAoQo9pyhqUvek6zH6SNxlgG\n\tkM4Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755866237; x=1756471037;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=dU7J13NSut7B4IXKbFasfDqJ2OiBxOotiJwfrFWeKDQ=;\n\tb=e518Dv4unagE/+8KsZhpSovCiP/1FBqFwb9hCL3PXXvZwPNGzdH8h7OqF1NVG3pK0Y\n\tYSpMgxkw+VVwodREm7CEuo5rbSlXG2O/B+jhI65JsTMZsdgGvVKoV7MhWBZPNrE12fIj\n\tHfGb+7na63Ku8boDMSelNg+mi1VmJRbR1jwjq1SpKbFkCzp2xmWTl3CT2tkWJB2zy6XI\n\trHvpkBql8quS9jBmLrzFJdqQhuuCalURXMz/tck3hNvz/zCusFobOK7LjFIoIvUybzu+\n\tbei6iN3MNCHg4CZwUzmrD3pbQoNp4zn0R+ASc0O0dacQeDFdez7I6ERIF32IrsjZSGM5\n\t7fhw==", "X-Gm-Message-State": "AOJu0YzOsFZbTNcf9fAE+pI3R4Tlyvj0lOYnNfe/PB9dWWAf2N54JTCQ\n\t23J8rDdPhVYMnUCS0AevptzdcGwn3JNfxcAFu3eDHCO0oc27OZq64KkXf24/rBYmdqLWWV7YzZO\n\tEYLXU", "X-Gm-Gg": "ASbGncthl6zD4SixttC/m3aG35Urz7KzMdQbYxSVh6MAqsVK7fkh7k79NKdI4myoYjx\n\tV/VnHk+6RnD60dEjhfnfqLdES2RrbpnH3x1utqYV641mXPM1F7LLeG9D/GKZ7hzrbXNgVp4k1qZ\n\tqF7cM9damQPxz951z9rhkP3zibn3EwKMysD5SfpJIj7Nf1kgyCP9J6i2m7RF3PmSQm7ARAU05Zg\n\tcRswE2kS4ngO7j51FkyDqF2OMfhSKmFzqM9dy14XRv8XQMhljuT8/YBunZX4WwUIp2EDldNqa+b\n\tq4Nd5HUUI20nPIZv/Zriq6bcF4kP42R+cumyXCwiFcdKwnsCZF43tIEc0YC+HGWJk7TWbujsK4B\n\tuosR5MgDKUAIArNJQvpL/P8C4sXb0f7Um9AMJbkakRTvwFWN+O/ZEi/zeUEAstn73kEbFS3uDFH\n\tY9It8YNaedMVxj10n9VpQpaF+vlHg4w510DFR+bLdHgNxa/BtUpw==", "X-Google-Smtp-Source": "AGHT+IGhjL140dX94YApZ7+pNushWYPQBlE0RJ+eOAmCgZ0MDJuf2sb9afDPK45yQ7vrcv0rbPrLmw==", "X-Received": "by 2002:a05:600c:5493:b0:459:d709:e5a1 with SMTP id\n\t5b1f17b1804b1-45b53af6c77mr19948285e9.6.1755866237511; \n\tFri, 22 Aug 2025 05:37:17 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH 6/6] ipa: rpi: sdn: Remove legacy denoise warning", "Date": "Fri, 22 Aug 2025 13:37:09 +0100", "Message-Id": "<20250822123709.16966-7-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.39.5", "In-Reply-To": "<20250822123709.16966-1-david.plowman@raspberrypi.com>", "References": "<20250822123709.16966-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We use the legacy format for the VC4 platform, and are not planning to\nchange this. So remove the warning.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/rpi/controller/rpi/sdn.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/rpi/controller/rpi/sdn.cpp b/src/ipa/rpi/controller/rpi/sdn.cpp\nindex 619178a8..594ea701 100644\n--- a/src/ipa/rpi/controller/rpi/sdn.cpp\n+++ b/src/ipa/rpi/controller/rpi/sdn.cpp\n@@ -37,8 +37,6 @@ char const *Sdn::name() const\n \n int Sdn::read(const libcamera::YamlObject ¶ms)\n {\n-\tLOG(RPiSdn, Warning)\n-\t\t<< \"Using legacy SDN tuning - please consider moving SDN inside rpi.denoise\";\n \tdeviation_ = params[\"deviation\"].get<double>(3.2);\n \tstrength_ = params[\"strength\"].get<double>(0.75);\n \treturn 0;\n", "prefixes": [ "6/6" ] }