Patch Detail
Show a patch.
GET /api/patches/24148/?format=api
{ "id": 24148, "url": "https://patchwork.libcamera.org/api/patches/24148/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24148/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250815142522.2237088-1-barnabas.pocze@ideasonboard.com>", "date": "2025-08-15T14:25:22", "name": "[RFC,v1] apps: cam: Do not overwrite name when adding camera model", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "02221efb33818249ff29ee0ef16f00c4a35a2d4c", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24148/mbox/", "series": [ { "id": 5388, "url": "https://patchwork.libcamera.org/api/series/5388/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5388", "date": "2025-08-15T14:25:22", "name": "[RFC,v1] apps: cam: Do not overwrite name when adding camera model", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5388/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24148/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24148/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3134CBDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Aug 2025 14:25:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F29926925A;\n\tFri, 15 Aug 2025 16:25:26 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E257369251\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Aug 2025 16:25:25 +0200 (CEST)", "from pb-laptop.local (185.221.141.188.nat.pool.zt.hu\n\t[185.221.141.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E498B56D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Aug 2025 16:24:30 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ceJF/pe7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755267871;\n\tbh=5fWLZ+WyHO8f2nz2P9Yj+205dlEftXbrW2foKAoUBSI=;\n\th=From:To:Subject:Date:From;\n\tb=ceJF/pe7awVHnUaYr8sTbKVTNxQ/rVrCnXUg3oQ/xfaC4xjj43e+A2Ct20Q4V8a2a\n\truE1vQKxvEsO8ErsH1IUt2F9yk7akCLeyaTJrBvq7QcTQdjmg7BhqG+cw9ROGH90U3\n\ttbJOjWMie+vwQ8qEowYU0mIrAw2/Zy7FffrRWZ3k=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1] apps: cam: Do not overwrite name when adding camera\n\tmodel", "Date": "Fri, 15 Aug 2025 16:25:22 +0200", "Message-ID": "<20250815142522.2237088-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.50.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If `addModel` is true, then the previously set `name` will be overwritten.\nThis does not seem to be the intended behaviour, so fix it by using `+=`.\n\nBefore:\n\n Available cameras:\n 1: 'imx219' (/base/soc@0/bus@30800000/i2c@30a30000/camera@10)\n\nAfter:\n\n Available cameras:\n 1: External camera 'imx219' (/base/soc@0/bus@30800000/i2c@30a30000/camera@10)\n\nFixes: aab49f903e858a (\"cam: Do not assume Location is available\")\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/main.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\nindex cbc85b59f..ad6bde68a 100644\n--- a/src/apps/cam/main.cpp\n+++ b/src/apps/cam/main.cpp\n@@ -322,7 +322,7 @@ std::string CamApp::cameraName(const Camera *camera)\n \t\t */\n \t\tconst auto &model = props.get(properties::Model);\n \t\tif (model)\n-\t\t\tname = \"'\" + *model + \"' \";\n+\t\t\tname += \"'\" + *model + \"' \";\n \t}\n \n \tname += \"(\" + camera->id() + \")\";\n", "prefixes": [ "RFC", "v1" ] }