Patch Detail
Show a patch.
GET /api/patches/24118/?format=api
{ "id": 24118, "url": "https://patchwork.libcamera.org/api/patches/24118/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24118/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250815102945.1602071-9-stefan.klug@ideasonboard.com>", "date": "2025-08-15T10:29:28", "name": "[v3,08/19] libipa: agc_mean_luminance: Configure the exposure mode helpers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "38ac32f4d2854fefd1952b6f2b5179eaedc816f8", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24118/mbox/", "series": [ { "id": 5382, "url": "https://patchwork.libcamera.org/api/series/5382/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5382", "date": "2025-08-15T10:29:20", "name": "Implement WDR algorithm", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5382/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24118/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24118/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CA3BC3295\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Aug 2025 10:30:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3634B69257;\n\tFri, 15 Aug 2025 12:30:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 899196924E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Aug 2025 12:30:16 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:83d1:ae5d:93a6:6837])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A827263B;\n\tFri, 15 Aug 2025 12:29:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U7q3U9Lh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755253761;\n\tbh=EAeMdJL6USh73Isp5+04TPUdbDYGE5rwJ3nRoZd1cXY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=U7q3U9LhDnCbhV4OdlZI0ydDFhvDNCyBDCOHfB7I/DeZmty1GTYNbqa5qwG3c4vFk\n\t/qc79O9JtK6Ave3RGyF3ydhWM28a2XGUjU4zsk6feErC/ZB79gtEo3QfWdYECnk5Zb\n\tYdgsEyYPG3Kri2n3dq6fgrcBlvvWRY/f95qvkCjk=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v3 08/19] libipa: agc_mean_luminance: Configure the exposure\n\tmode helpers", "Date": "Fri, 15 Aug 2025 12:29:28 +0200", "Message-ID": "<20250815102945.1602071-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250815102945.1602071-1-stefan.klug@ideasonboard.com>", "References": "<20250815102945.1602071-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a function to configure the exposure mode helpers with the line\nlength and sensor helper to take quantization effects into account.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Renamed lineLength to lineDuration\n- Collected tag\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 15 +++++++++++++++\n src/ipa/libipa/agc_mean_luminance.h | 1 +\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex fce1a5064870..1cbb3a0f9818 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -311,6 +311,21 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n \treturn 0;\n }\n \n+/**\n+ * \\brief Configure the exposure mode helpers\n+ * \\param[in] lineLength The sensor line length\n+ * \\param[in] sensorHelper The sensor helper\n+ *\n+ * This function configures the exposure mode helpers so they can correctly\n+ * take quantization effects into account.\n+ */\n+void AgcMeanLuminance::configure(utils::Duration lineDuration,\n+\t\t\t\t const CameraSensorHelper *sensorHelper)\n+{\n+\tfor (auto &[id, helper] : exposureModeHelpers_)\n+\t\thelper->configure(lineDuration, sensorHelper);\n+}\n+\n /**\n * \\brief Parse tuning data for AeConstraintMode and AeExposureMode controls\n * \\param[in] tuningData the YamlObject representing the tuning data\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex cad7ef845487..49985481ac51 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -42,6 +42,7 @@ public:\n \t\tdouble yTarget;\n \t};\n \n+\tvoid configure(utils::Duration lineDuration, const CameraSensorHelper *sensorHelper);\n \tint parseTuningData(const YamlObject &tuningData);\n \n \tvoid setExposureCompensation(double gain)\n", "prefixes": [ "v3", "08/19" ] }