Patch Detail
Show a patch.
GET /api/patches/24067/?format=api
{ "id": 24067, "url": "https://patchwork.libcamera.org/api/patches/24067/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24067/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250807072123.35523-1-uajain@igalia.com>", "date": "2025-08-07T07:21:23", "name": "gstreamer: Drop a redundant conditional check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d4b091e2823c621b312a791f25c047fd7df07939", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24067/mbox/", "series": [ { "id": 5360, "url": "https://patchwork.libcamera.org/api/series/5360/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5360", "date": "2025-08-07T07:21:23", "name": "gstreamer: Drop a redundant conditional check", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5360/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24067/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24067/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D58A3BE086\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Aug 2025 07:21:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 044466921E;\n\tThu, 7 Aug 2025 09:21:18 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45B7C69154\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Aug 2025 09:21:15 +0200 (CEST)", "from [49.36.71.143] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ujuw4-00AtLb-Pe; Thu, 07 Aug 2025 09:21:13 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"GGWmn/nX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=K+ij2UbUYG2HC2eUCyXpv2xiTAJlYfIfOmQCPHGyn6A=;\n\tb=GGWmn/nXuxYCU9QWbhNUZIpGpt\n\tXBLmUZlPTGPpc5u6lpZeRRyaXPHYGpFJBtyotgsat2ID+2DUFG92hzyGOBGMJDUO7VBPqwpVu4GZB\n\tTOqJ3UUbgXreQzfQ+q/7gM/ZdaOmldaPWv5fsd2gTj9omvT56rtEy/yOGXHdOGYU0Vu9KhU+xec+g\n\tchVEKOo/QCiZB+gN+O2OX2bpoM0n3vf+/6GVVmwGHMzm5FVtDLUO+C2Xc8OHkVCUq3onbwrQZLTNu\n\tYuv12c/BDUCvTUE84d19VdQjOL+ts0Pl2WzwXm8QA+fZD1+WVarvPLXvEzi7yu4ojEk0OPb6lJfP6\n\tbpIRoESg==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tUmang Jain <uajain@igalia.com>", "Subject": "[PATCH] gstreamer: Drop a redundant conditional check", "Date": "Thu, 7 Aug 2025 12:51:23 +0530", "Message-ID": "<20250807072123.35523-1-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "RequestWrap `wrap` is set only if completedRequests_ queue\nis not empty, and if the `wrap` remains unset, -ENOBUFS is returned\nby GstLibcameraSrcState::processRequest().\n\nThere is no need to set the `err` variable to -ENOBUFS,\nby checking the completedRequests_ queue again. Hence, drop this\nconditional check from the processRequest() hotpath.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 79a025a5..3adb34f9 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -346,9 +346,6 @@ int GstLibcameraSrcState::processRequest()\n \t\t\twrap = std::move(completedRequests_.front());\n \t\t\tcompletedRequests_.pop();\n \t\t}\n-\n-\t\tif (completedRequests_.empty())\n-\t\t\terr = -ENOBUFS;\n \t}\n \n \tif (!wrap)\n", "prefixes": [] }