Patch Detail
Show a patch.
GET /api/patches/23962/?format=api
{ "id": 23962, "url": "https://patchwork.libcamera.org/api/patches/23962/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23962/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250725-multicontext-v1-8-ea558291e101@ideasonboard.com>", "date": "2025-07-25T10:33:53", "name": "[DNI,8/9] libcamera: rpi/pisp: Bind devices in a context", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f9008cff183e55b52d3e3800b704f77447b002e9", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23962/mbox/", "series": [ { "id": 5329, "url": "https://patchwork.libcamera.org/api/series/5329/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5329", "date": "2025-07-25T10:33:45", "name": "libcamera: Support for multi-context operations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5329/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23962/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23962/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 380C5C332A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Jul 2025 10:34:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95C7C690D4;\n\tFri, 25 Jul 2025 12:34:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDE79690C1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jul 2025 12:34:00 +0200 (CEST)", "from [192.168.0.172] (mob-5-90-139-29.net.vodafone.it\n\t[5.90.139.29])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C198AE9B;\n\tFri, 25 Jul 2025 12:33:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pkr+jGc+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753439601;\n\tbh=cvrNmyHuY4zMvLFKpyeMUlm71YVcNgYowpc8no0CGeo=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=pkr+jGc+LP4yVpAoCjmrcYssGRB3HcNKBnCdBlLsBjPVlO5/LX4lfiO8ItEaGlTml\n\tydPoIRvV5nJDrbDbg/UHmMxau8m/T4GxEXztFORanvL8V6LblbIjkNVmRgol63RoWk\n\tneUEqHrC+v6M/cZjpp3DG3rAUqHb8uDWoSY8nV6o=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 25 Jul 2025 12:33:53 +0200", "Subject": "[PATCH DNI 8/9] libcamera: rpi/pisp: Bind devices in a context", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250725-multicontext-v1-8-ea558291e101@ideasonboard.com>", "References": "<20250725-multicontext-v1-0-ea558291e101@ideasonboard.com>", "In-Reply-To": "<20250725-multicontext-v1-0-ea558291e101@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2537;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=cvrNmyHuY4zMvLFKpyeMUlm71YVcNgYowpc8no0CGeo=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBog12UhuJ9z9YjRKe8uEfLSClxp9sDWlloXEQ15\n\tdWm3sS1OgKJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaINdlAAKCRByNAaPFqFW\n\tPPkTD/9aYroHvwT8Ae25nmgtzdkNjkc5/VqshBEYV1ecygcAYbMEtwqywepBH3aV8FVhgRo+/1p\n\tmEdSObaQiw3TraoCmmQ6uWUSxfleo0oanyZ1+IDc8Qpb8GACuY/zLfbkNpzTiGWd786sAyfRgo/\n\tzad/BScmZiYvMwkumYcz+QeELSJgbSfjPwcGJ/VUBS6A3NnQ0tUFqUE9L+jOGExMwYTfOujT6nU\n\te+H+rbWEVfPdUjd8XyoYyc69SekjTEJL0K9H/ofPoCvnxDskAxqsFMI7bE2CbjZNfQaDB0feXN3\n\tHuUl4jmsLkJLiSAOmGN7CT48ZMOuyovjXH+nBtsG8sUmZbbgIO2MVdz4a86oFdXQoJnNZk8QxGV\n\ts/3KH02w495CIkLu7uh+Xa+VVJCHY3gT+p3zMBAi1BfWlETw6Rq3aPQ3ESCs6Vv348lI0Dsroqn\n\t8RvxBoPY+XLsIgW80OVHOhYAPJSwG0jj98nlPZONTyC2tIlJEke6CLFlgoMK/1RLMSPNTpb2Ptl\n\tlY7URZQu/TzD2bAjnJXyt0HNZMyTOQb/+sL0bpFrasZapTJ0iUsCJisYoa3bHfprqYsxwAJD2fK\n\t7tdjMKDkDV/d4MACfCMyOagKPJFqS0104H+a9wkLJXsvGQxoTOGxaygA2bZUYl4BI3VdjHWFaIM\n\tTVV/tRFjQ7yU/rA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Create a MediaContext for each detected camera sensor and bind the\nISP video devices to it.\n\nThis allows multi-camera operations with a single, multiplexed, ISP\ndevice.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 23 +++++++++++++++++++++++\n 1 file changed, 23 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rpi/pisp/pisp.cpp b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\nindex 15dd950682eeff9dc1a9b4ae2f927da85c0eaac6..49a97415c67f0c7c36b3c0b8bd597c278af16838 100644\n--- a/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n+++ b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n@@ -740,6 +740,16 @@ public:\n \t\treturn cfe_[Cfe::Output0].dev();\n \t}\n \n+\tint bindDevice(V4L2VideoDevice *dev)\n+\t{\n+\t\treturn mediaContext_->bindDevice(dev);\n+\t}\n+\n+\tint bindDevice(V4L2Subdevice *dev)\n+\t{\n+\t\treturn mediaContext_->bindDevice(dev);\n+\t}\n+\n \tCameraConfiguration::Status\n \tplatformValidate(RPi::RPiCameraConfiguration *rpiConfig) const override;\n \n@@ -776,6 +786,8 @@ public:\n \tunsigned int tdnInputIndex_;\n \tunsigned int stitchInputIndex_;\n \n+\tstd::unique_ptr<MediaContext> mediaContext_;\n+\n \tstruct Config {\n \t\t/*\n \t\t * Number of CFE config and stats buffers to allocate and use. A\n@@ -935,6 +947,7 @@ bool PipelineHandlerPiSP::match(DeviceEnumerator *enumerator)\n \t\t\t\t\t(\"pisp_frontend\", true, pisp->pispVariant_);\n \t\t\tpisp->be_ = SharedMemObject<BackEnd>\n \t\t\t\t\t(\"pisp_backend\", BackEnd::Config({}), pisp->pispVariant_);\n+\t\t\tpisp->mediaContext_ = ispDevice->createContext();\n \n \t\t\tif (!pisp->fe_.fd().isValid() || !pisp->be_.fd().isValid()) {\n \t\t\t\tLOG(RPI, Error) << \"Failed to create ISP shared objects\";\n@@ -1155,6 +1168,16 @@ int PipelineHandlerPiSP::platformRegister(std::unique_ptr<RPi::CameraData> &came\n \t\t\treturn ret;\n \t}\n \n+\t/* Bind devices to the media device. */\n+\tdata->bindDevice(data->isp_[Isp::Input].dev());\n+\tdata->bindDevice(data->isp_[Isp::Output0].dev());\n+\tdata->bindDevice(data->isp_[Isp::Output1].dev());\n+\tdata->bindDevice(data->isp_[Isp::Config].dev());\n+\tdata->bindDevice(data->isp_[Isp::TdnInput].dev());\n+\tdata->bindDevice(data->isp_[Isp::TdnOutput].dev());\n+\tdata->bindDevice(data->isp_[Isp::StitchInput].dev());\n+\tdata->bindDevice(data->isp_[Isp::StitchOutput].dev());\n+\n \t/* Write up all the IPA connections. */\n \tdata->ipa_->prepareIspComplete.connect(data, &PiSPCameraData::prepareIspComplete);\n \tdata->ipa_->processStatsComplete.connect(data, &PiSPCameraData::processStatsComplete);\n", "prefixes": [ "DNI", "8/9" ] }