Patch Detail
Show a patch.
GET /api/patches/23941/?format=api
{ "id": 23941, "url": "https://patchwork.libcamera.org/api/patches/23941/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23941/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250724103948.9971-1-laurent.pinchart@ideasonboard.com>", "date": "2025-07-24T10:39:48", "name": "libcamera: Drop remaining file names from header comment blocks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "358d6320d5c25bb594fdb80459c5b0f9586b6583", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23941/mbox/", "series": [ { "id": 5321, "url": "https://patchwork.libcamera.org/api/series/5321/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5321", "date": "2025-07-24T10:39:48", "name": "libcamera: Drop remaining file names from header comment blocks", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5321/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23941/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23941/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98026BDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Jul 2025 10:39:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BC2869105;\n\tThu, 24 Jul 2025 12:39:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 340C0690E2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Jul 2025 12:39:52 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 191D5C79\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Jul 2025 12:39:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UYPDkG6Q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753353553;\n\tbh=ACQWfnyGjyMTZk2R5HD+NxejM0MKIE80amvKVqG8kns=;\n\th=From:To:Subject:Date:From;\n\tb=UYPDkG6Q32PhR+3683pq/yL0xBxzs8p4Yhqyf7DlJeOA+gwtkZq8ludyF+wpllwCu\n\te61wIiNhciKV1REXG4t1fVFltwUzXAB9vmhoQ6rUptg+1mbnqVNl0e0MqGCBjyQjg2\n\tbhA4SJCCwLcJfAd17Lla0ZvMRVH3mYj/KlgUIFbc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] libcamera: Drop remaining file names from header comment\n\tblocks", "Date": "Thu, 24 Jul 2025 13:39:48 +0300", "Message-ID": "<20250724103948.9971-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Header comment blocks used to contain the file name. Considered as\nuseless information, the names have been removed, with the last ones\nsupposed to be dropped in commit d3bf27180ef1 (\"libcamera: Drop\nremaining file names from header comment blocks\"). A few have however\nbeen forgotten, and more crept back since. Remove them.\n\nWhile at it, fix one typo in a header comment block by replacing\n'MaliC55 with Mali-C55', and add a missing blank line in\nsrc/ipa/rpi/pisp/pisp.cpp.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/apps/lc-compliance/test_base.cpp | 2 +-\n src/apps/lc-compliance/test_base.h | 2 +-\n src/ipa/mali-c55/algorithms/agc.cpp | 2 +-\n src/ipa/mali-c55/algorithms/agc.h | 2 +-\n src/ipa/mali-c55/algorithms/algorithm.h | 2 +-\n src/ipa/mali-c55/algorithms/awb.cpp | 2 +-\n src/ipa/mali-c55/algorithms/awb.h | 2 +-\n src/ipa/mali-c55/algorithms/lsc.cpp | 2 +-\n src/ipa/mali-c55/algorithms/lsc.h | 2 +-\n src/ipa/mali-c55/ipa_context.cpp | 2 +-\n src/ipa/mali-c55/ipa_context.h | 2 +-\n src/ipa/mali-c55/mali-c55.cpp | 2 +-\n src/ipa/mali-c55/module.h | 2 +-\n src/ipa/rkisp1/algorithms/lux.cpp | 2 +-\n src/ipa/rkisp1/algorithms/lux.h | 2 +-\n src/ipa/rpi/cam_helper/cam_helper_imx283.cpp | 2 +-\n src/ipa/rpi/controller/af_algorithm.h | 2 +-\n src/ipa/rpi/controller/rpi/cac.h | 2 +-\n src/ipa/rpi/controller/rpi/denoise.h | 2 +-\n src/ipa/rpi/controller/rpi/saturation.h | 2 +-\n src/ipa/rpi/controller/rpi/tonemap.h | 2 +-\n src/ipa/rpi/pisp/pisp.cpp | 3 ++-\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2 +-\n src/libcamera/sensor/camera_sensor_legacy.cpp | 2 +-\n src/libcamera/sensor/camera_sensor_raw.cpp | 2 +-\n test/gstreamer/gstreamer_memory_lifetime_test.cpp | 2 +-\n 26 files changed, 27 insertions(+), 26 deletions(-)\n\n\nbase-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe\n--\nRegards,\n\nLaurent Pinchart", "diff": "diff --git a/src/apps/lc-compliance/test_base.cpp b/src/apps/lc-compliance/test_base.cpp\nindex c9957b9efd36..3e9ec1aa0368 100644\n--- a/src/apps/lc-compliance/test_base.cpp\n+++ b/src/apps/lc-compliance/test_base.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2021, Collabora Ltd.\n *\n- * test_base.cpp - Base definitions for tests\n+ * Base definitions for tests\n */\n\n #include \"test_base.h\"\ndiff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h\nindex 52347749ab10..0f32e3c21d0e 100644\n--- a/src/apps/lc-compliance/test_base.h\n+++ b/src/apps/lc-compliance/test_base.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2021, Collabora Ltd.\n *\n- * test_base.h - Base definitions for tests\n+ * Base definitions for tests\n */\n\n #ifndef __LC_COMPLIANCE_TEST_BASE_H__\ndiff --git a/src/ipa/mali-c55/algorithms/agc.cpp b/src/ipa/mali-c55/algorithms/agc.cpp\nindex 70667db34f1e..15963994b2d6 100644\n--- a/src/ipa/mali-c55/algorithms/agc.cpp\n+++ b/src/ipa/mali-c55/algorithms/agc.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board Oy\n *\n- * agc.cpp - AGC/AEC mean-based control algorithm\n+ * AGC/AEC mean-based control algorithm\n */\n\n #include \"agc.h\"\ndiff --git a/src/ipa/mali-c55/algorithms/agc.h b/src/ipa/mali-c55/algorithms/agc.h\nindex c5c574e57fed..0b4bf7eda1c2 100644\n--- a/src/ipa/mali-c55/algorithms/agc.h\n+++ b/src/ipa/mali-c55/algorithms/agc.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2023, Ideas on Board Oy\n *\n- * agc.h - Mali C55 AGC/AEC mean-based control algorithm\n+ * Mali C55 AGC/AEC mean-based control algorithm\n */\n\n #pragma once\ndiff --git a/src/ipa/mali-c55/algorithms/algorithm.h b/src/ipa/mali-c55/algorithms/algorithm.h\nindex 36a3bff0103e..ec8dd3973eaf 100644\n--- a/src/ipa/mali-c55/algorithms/algorithm.h\n+++ b/src/ipa/mali-c55/algorithms/algorithm.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board\n *\n- * algorithm.h - Mali-C55 control algorithm interface\n+ * Mali-C55 control algorithm interface\n */\n\n #pragma once\ndiff --git a/src/ipa/mali-c55/algorithms/awb.cpp b/src/ipa/mali-c55/algorithms/awb.cpp\nindex 050b191b7478..3d546e5a854b 100644\n--- a/src/ipa/mali-c55/algorithms/awb.cpp\n+++ b/src/ipa/mali-c55/algorithms/awb.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board Oy\n *\n- * awb.cpp - Mali C55 grey world auto white balance algorithm\n+ * Mali C55 grey world auto white balance algorithm\n */\n\n #include \"awb.h\"\ndiff --git a/src/ipa/mali-c55/algorithms/awb.h b/src/ipa/mali-c55/algorithms/awb.h\nindex 800c2e8349b9..2351d4055530 100644\n--- a/src/ipa/mali-c55/algorithms/awb.h\n+++ b/src/ipa/mali-c55/algorithms/awb.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas on Board Oy\n *\n- * awb.h - Mali C55 grey world auto white balance algorithm\n+ * Mali C55 grey world auto white balance algorithm\n */\n\n #include \"algorithm.h\"\ndiff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali-c55/algorithms/lsc.cpp\nindex c5afc04dd539..c43d034a181e 100644\n--- a/src/ipa/mali-c55/algorithms/lsc.cpp\n+++ b/src/ipa/mali-c55/algorithms/lsc.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board Oy\n *\n- * lsc.cpp - Mali-C55 Lens shading correction algorithm\n+ * Mali-C55 Lens shading correction algorithm\n */\n\n #include \"lsc.h\"\ndiff --git a/src/ipa/mali-c55/algorithms/lsc.h b/src/ipa/mali-c55/algorithms/lsc.h\nindex e613277a5298..d11e23bc7c34 100644\n--- a/src/ipa/mali-c55/algorithms/lsc.h\n+++ b/src/ipa/mali-c55/algorithms/lsc.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board Oy\n *\n- * lsc.h - Mali-C55 Lens shading correction algorithm\n+ * Mali-C55 Lens shading correction algorithm\n */\n\n #include <map>\ndiff --git a/src/ipa/mali-c55/ipa_context.cpp b/src/ipa/mali-c55/ipa_context.cpp\nindex 99f76ecd00ad..1b203e2b2605 100644\n--- a/src/ipa/mali-c55/ipa_context.cpp\n+++ b/src/ipa/mali-c55/ipa_context.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board\n *\n- * ipa_context.cpp - MaliC55 IPA Context\n+ * Mali-C55 IPA Context\n */\n\n #include \"ipa_context.h\"\ndiff --git a/src/ipa/mali-c55/ipa_context.h b/src/ipa/mali-c55/ipa_context.h\nindex 5e3e2fbde438..13885eb83b5c 100644\n--- a/src/ipa/mali-c55/ipa_context.h\n+++ b/src/ipa/mali-c55/ipa_context.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board\n *\n- * ipa_context.h - Mali-C55 IPA Context\n+ * Mali-C55 IPA Context\n */\n\n #pragma once\ndiff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp\nindex 5877f29984dc..7d45e7310aec 100644\n--- a/src/ipa/mali-c55/mali-c55.cpp\n+++ b/src/ipa/mali-c55/mali-c55.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2023, Ideas on Board Oy\n *\n- * mali-c55.cpp - Mali-C55 ISP image processing algorithms\n+ * Mali-C55 ISP image processing algorithms\n */\n\n #include <map>\ndiff --git a/src/ipa/mali-c55/module.h b/src/ipa/mali-c55/module.h\nindex 1d85ec1f6f05..4f6a4f18bfaf 100644\n--- a/src/ipa/mali-c55/module.h\n+++ b/src/ipa/mali-c55/module.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board\n *\n- * module.h - Mali-C55 IPA Module\n+ * Mali-C55 IPA Module\n */\n\n #pragma once\ndiff --git a/src/ipa/rkisp1/algorithms/lux.cpp b/src/ipa/rkisp1/algorithms/lux.cpp\nindex a467767e1298..dd05f18d5e94 100644\n--- a/src/ipa/rkisp1/algorithms/lux.cpp\n+++ b/src/ipa/rkisp1/algorithms/lux.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board\n *\n- * lux.cpp - RkISP1 Lux control\n+ * RkISP1 Lux control\n */\n\n #include \"lux.h\"\ndiff --git a/src/ipa/rkisp1/algorithms/lux.h b/src/ipa/rkisp1/algorithms/lux.h\nindex 8a90de55b8ff..8dcadc284a84 100644\n--- a/src/ipa/rkisp1/algorithms/lux.h\n+++ b/src/ipa/rkisp1/algorithms/lux.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas On Board\n *\n- * lux.h - RkISP1 Lux control\n+ * RkISP1 Lux control\n */\n\n #pragma once\ndiff --git a/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\nindex efc03193f165..073f3910e428 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Raspberry Pi Ltd\n *\n- * cam_helper_Imx283.cpp - camera information for Imx283 sensor\n+ * camera information for Imx283 sensor\n */\n\n #include <assert.h>\ndiff --git a/src/ipa/rpi/controller/af_algorithm.h b/src/ipa/rpi/controller/af_algorithm.h\nindex 382609f9b2d8..39a8de5a35e2 100644\n--- a/src/ipa/rpi/controller/af_algorithm.h\n+++ b/src/ipa/rpi/controller/af_algorithm.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2022, Raspberry Pi Ltd\n *\n- * af_algorithm.hpp - auto focus algorithm interface\n+ * Auto focus algorithm interface\n */\n #pragma once\n\ndiff --git a/src/ipa/rpi/controller/rpi/cac.h b/src/ipa/rpi/controller/rpi/cac.h\nindex a7b14c0003d9..533cca44424b 100644\n--- a/src/ipa/rpi/controller/rpi/cac.h\n+++ b/src/ipa/rpi/controller/rpi/cac.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2023, Raspberry Pi Ltd\n *\n- * cac.hpp - CAC control algorithm\n+ * CAC control algorithm\n */\n #pragma once\n\ndiff --git a/src/ipa/rpi/controller/rpi/denoise.h b/src/ipa/rpi/controller/rpi/denoise.h\nindex 92ff4f93edf2..79946c979fcb 100644\n--- a/src/ipa/rpi/controller/rpi/denoise.h\n+++ b/src/ipa/rpi/controller/rpi/denoise.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2022, Raspberry Pi Ltd\n *\n- * denoise.hpp - Denoise (spatial, colour, temporal) control algorithm\n+ * Denoise (spatial, colour, temporal) control algorithm\n */\n #pragma once\n\ndiff --git a/src/ipa/rpi/controller/rpi/saturation.h b/src/ipa/rpi/controller/rpi/saturation.h\nindex 97da412ad59a..c67d496ef065 100644\n--- a/src/ipa/rpi/controller/rpi/saturation.h\n+++ b/src/ipa/rpi/controller/rpi/saturation.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2022, Raspberry Pi Ltd\n *\n- * saturation.hpp - Saturation control algorithm\n+ * Saturation control algorithm\n */\n #pragma once\n\ndiff --git a/src/ipa/rpi/controller/rpi/tonemap.h b/src/ipa/rpi/controller/rpi/tonemap.h\nindex ba0cf5c40de9..4e513b1d00da 100644\n--- a/src/ipa/rpi/controller/rpi/tonemap.h\n+++ b/src/ipa/rpi/controller/rpi/tonemap.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2022, Raspberry Pi Ltd\n *\n- * tonemap.hpp - Tonemap control algorithm\n+ * Tonemap control algorithm\n */\n #pragma once\n\ndiff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp\nindex ab70d8f42636..829b91258522 100644\n--- a/src/ipa/rpi/pisp/pisp.cpp\n+++ b/src/ipa/rpi/pisp/pisp.cpp\n@@ -2,8 +2,9 @@\n /*\n * Copyright (C) 2023, Raspberry Pi Ltd\n *\n- * pisp.cpp - Raspberry Pi PiSP IPA\n+ * Raspberry Pi PiSP IPA\n */\n+\n #include <algorithm>\n #include <cmath>\n #include <mutex>\ndiff --git a/src/libcamera/pipeline/rpi/pisp/pisp.cpp b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\nindex 15dd950682ee..082724c5a0fb 100644\n--- a/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n+++ b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2023, Raspberry Pi Ltd\n *\n- * pisp.cpp - Pipeline handler for PiSP based Raspberry Pi devices\n+ * Pipeline handler for PiSP based Raspberry Pi devices\n */\n\n #include <algorithm>\ndiff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex 32989c19c019..ba0a5c331d06 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * camera_sensor_legacy.cpp - A V4L2-backed camera sensor\n+ * A V4L2-backed camera sensor\n */\n\n #include <algorithm>\ndiff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\nindex ab75b1f8204c..f9aef054e677 100644\n--- a/src/libcamera/sensor/camera_sensor_raw.cpp\n+++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Ideas on Board Oy.\n *\n- * camera_sensor_raw.cpp - A raw camera sensor using the V4L2 streams API\n+ * A raw camera sensor using the V4L2 streams API\n */\n\n #include <algorithm>\ndiff --git a/test/gstreamer/gstreamer_memory_lifetime_test.cpp b/test/gstreamer/gstreamer_memory_lifetime_test.cpp\nindex 1738cf56a48d..99d1c4e55bfc 100644\n--- a/test/gstreamer/gstreamer_memory_lifetime_test.cpp\n+++ b/test/gstreamer/gstreamer_memory_lifetime_test.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024, Nicolas Dufresne\n *\n- * gstreamer_memory_lifetime_test.cpp - GStreamer memory lifetime test\n+ * GStreamer memory lifetime test\n */\n\n #include <iostream>\n", "prefixes": [] }