Patch Detail
Show a patch.
GET /api/patches/2392/?format=api
{ "id": 2392, "url": "https://patchwork.libcamera.org/api/patches/2392/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2392/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191204132106.21582-9-jacopo@jmondi.org>", "date": "2019-12-04T13:21:04", "name": "[libcamera-devel,08/10] libcamera: camera: Add Camera properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2f7d3587787891ebf7dba43203cb60b8d9ec4755", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2392/mbox/", "series": [ { "id": 581, "url": "https://patchwork.libcamera.org/api/series/581/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=581", "date": "2019-12-04T13:20:56", "name": "Introduce camera properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/581/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2392/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2392/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63D0E61CF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Dec 2019 14:21:24 +0100 (CET)", "from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id EAD40240002;\n\tWed, 4 Dec 2019 13:21:23 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Dec 2019 14:21:04 +0100", "Message-Id": "<20191204132106.21582-9-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191204132106.21582-1-jacopo@jmondi.org>", "References": "<20191204132106.21582-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 08/10] libcamera: camera: Add Camera\n\tproperties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 04 Dec 2019 13:21:24 -0000" }, "content": "Add an operation to the Camera class to retrive the Camera properties\nregistered by the pipeline handler.\n\nWhile at it, rewords the Camera::controls() operation documentation to\nspecify that the camera control information are constant during the\ncamera lifetime not their value, while the camera properties value are\nthe actually static information.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/camera.h | 1 +\n src/libcamera/camera.cpp | 16 +++++++++++++++-\n 2 files changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex ef6a37bb142c..72d5d62cc902 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -85,6 +85,7 @@ public:\n \tint release();\n \n \tconst ControlInfoMap &controls();\n+\tconst ControlList &properties();\n \n \tconst std::set<Stream *> &streams() const;\n \tstd::unique_ptr<CameraConfiguration> generateConfiguration(const StreamRoles &roles);\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex e810fb725d81..44031ffdb4b3 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -551,7 +551,8 @@ int Camera::release()\n /**\n * \\brief Retrieve the list of controls supported by the camera\n *\n- * Camera controls remain constant through the lifetime of the camera.\n+ * The list of controls supported by the camera and their associated\n+ * constraints remain constant through the lifetime of the camera.\n *\n * \\return A ControlInfoMap listing the controls supported by the camera\n */\n@@ -560,6 +561,19 @@ const ControlInfoMap &Camera::controls()\n \treturn pipe_->controls(this);\n }\n \n+/**\n+ * \\brief Retrieve the list of properties of the camera\n+ *\n+ * Camera properties are static information that remain constant through the\n+ * lifetime of the camera.\n+ *\n+ * \\return A ControlList of properties supported by the camera\n+ */\n+const ControlList &Camera::properties()\n+{\n+\treturn pipe_->properties(this);\n+}\n+\n /**\n * \\brief Retrieve all the camera's stream information\n *\n", "prefixes": [ "libcamera-devel", "08/10" ] }